mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kees Cook <kees@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Andy Shevchenko <andy@kernel.org>,
	Christopher Fore <csfore@posteo.net>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Junjie Cao <junjie.cao@intel.com>,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Nathan Chancellor <nathan@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vegard Nossum <vegard.nossum@oracle.com>
Subject: Re: [GIT PULL] hardening updates for v6.18-rc1
Date: Mon, 29 Sep 2025 19:06:23 -0700	[thread overview]
Message-ID: <202509291904.479E322AE9@keescook> (raw)
In-Reply-To: <CAHk-=wgZjUk4Cy2XgNkTrQoO8XCmNUHrTe5D519Fij1POK+3qw@mail.gmail.com>

On Mon, Sep 29, 2025 at 05:59:17PM -0700, Linus Torvalds wrote:
> On Mon, 29 Sept 2025 at 12:15, Kees Cook <kees@kernel.org> wrote:
> >
> > Please pull these hardening updates for v6.18-rc1. One notable addition
> > is the creation of the "transitional" keyword for kconfig so CONFIG
> > renaming can go more smoothly. This has been a long-standing deficiency,
> > and with the renaming of CONFIG_CFI_CLANG to CONFIG_CFI (since GCC will
> > soon have KCFI support), this came up again. The breadth of the diffstat
> > is mainly this renaming.
> 
> So I really like this addition conceptually, but it doesn't actually
> seem to work.
> 
> My clang-building tree config had
> 
>     CONFIG_ARCH_SUPPORTS_CFI_CLANG=y
>     # CONFIG_CFI_CLANG is not set
>     CONFIG_HAVE_CFI_ICALL_NORMALIZE_INTEGERS_CLANG=y
> 
> but then when I pulled this and did a "make oldconfig" I get Kconfig asking me
> 
>     Use Kernel Control Flow Integrity (kCFI) (CFI) [N/y/?] (NEW)
> 
> anyway, in order to get
> 
>     CONFIG_ARCH_SUPPORTS_CFI=y
>     # CONFIG_CFI is not set
>     CONFIG_HAVE_CFI_ICALL_NORMALIZE_INTEGERS=y
> 
> and I thought the whole point was that it would recognize the old
> Kconfig names and transition them to the new ones. And it very clearly
> does not.
> 
> So I'm a bit disappointed. Possibly because I expected the
> "transitional" keyword to be doing more than it does. But possibly
> because it's buggy and doesn't actually do what it is *supposed* to
> do.

Ah, the existing "=n" didn't persist. That's not expected. I will take
a look.

-- 
Kees Cook

  reply	other threads:[~2025-09-30  2:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-29 19:15 Kees Cook
2025-09-30  0:59 ` Linus Torvalds
2025-09-30  2:06   ` Kees Cook [this message]
2025-09-30  1:13 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202509291904.479E322AE9@keescook \
    --to=kees@kernel.org \
    --cc=andy@kernel.org \
    --cc=csfore@posteo.net \
    --cc=gustavoars@kernel.org \
    --cc=junjie.cao@intel.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nathan@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=torvalds@linux-foundation.org \
    --cc=vegard.nossum@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®