From: Peter Zijlstra <peterz@infradead.org>
To: Pingfan Liu <piliu@redhat.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>
Subject: Re: [PATCH] sched/deadline: Derive root domain from active cpu in task's cpus_ptr
Date: Tue, 30 Sep 2025 11:03:34 +0200 [thread overview]
Message-ID: <20250930090334.GI4067720@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <CAF+s44Q4SDXPRfYc4Ms5TcJgRU07QJB5H5VOHvyrZ31x9z49nw@mail.gmail.com>
On Tue, Sep 30, 2025 at 09:47:33AM +0800, Pingfan Liu wrote:
> > > This patch uses the rd from the run queue of still-active CPU to get the
> > > correct root domain.
> >
>
> Sorry that I haven't explained it clearly. I mean the still-active CPU
> in task->cpus_ptr,
>
> > That doesn't seem right in general. What if there are multiple root
> > domains; how does it know which to use?
> >
>
> In the case of task->cpus_ptr, there should be only one root domain, right?
IIRC there was a corner case somewhere; something like clearing the old
cpuset load_balance flag on the root domain would not iterate all tasks
or so.
The result would be tasks with all-set cpumasks (the default value)
spread over multiple root domains. Every task would be caught in
whatever root domain it was at the time of toggle.
This might have been fixed, but I can't remember.
next prev parent reply other threads:[~2025-09-30 9:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-29 13:36 Pingfan Liu
2025-09-29 13:53 ` Peter Zijlstra
2025-09-30 1:47 ` Pingfan Liu
2025-09-30 7:20 ` Juri Lelli
2025-09-30 9:04 ` Peter Zijlstra
2025-10-06 10:20 ` Pierre Gondois
[not found] ` <45e40d5e-f0b9-4c77-af1e-6ac915518acc@arm.com>
2025-10-06 12:12 ` Juri Lelli
2025-10-10 16:25 ` Pierre Gondois
2025-10-14 13:09 ` Pingfan Liu
2025-10-15 9:35 ` Juri Lelli
2025-10-16 11:37 ` Pierre Gondois
2025-10-16 12:17 ` Pingfan Liu
2025-10-16 14:26 ` Pierre Gondois
2025-10-16 12:20 ` Pingfan Liu
2025-09-30 9:03 ` Peter Zijlstra [this message]
2025-10-01 13:15 ` Pingfan Liu
2025-09-29 14:37 ` Juri Lelli
2025-09-30 1:43 ` Pingfan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250930090334.GI4067720@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=piliu@redhat.com \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®