From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3ABAB30594D; Tue, 30 Sep 2025 14:56:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759244177; cv=none; b=JjpWDzowbYyNaP2sa9Q86ezsGV79U98JQClKhEUrN49tWlfPF5jbHzmeI3Fgdx9eMIByGATJW6TJB6q7JJv1vOok3ta69By8XPJWFVH/N/llXXk1ob/8dpeMydV27+1tNWaYYItz72Vag3rkaYCSuQju2LSSLiEoZqeW+UnV0SA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759244177; c=relaxed/simple; bh=CLOz+mLB1FROI9P8SsJR3wP+Ye2pbPUTh/PJ3w6F0TQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Bc1oJR8PtYfPwdggSmMvSWOq00GITvpKx2P4MJMSpgHPJkbGv+PPuEacdGK4VcNP43t0/GWaDFpxp/yBAyzDG2byml+jUsxbvNDMhkkwYaWnbsNB9SZdI1cL6wAYnsJKxfbo5SO9h9sBHaOsmlDjVyo05QxpAz9pqbQJjsw9hLM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 578311424; Tue, 30 Sep 2025 07:56:06 -0700 (PDT) Received: from localhost (e132581.arm.com [10.1.196.87]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0AF183F59E; Tue, 30 Sep 2025 07:56:13 -0700 (PDT) Date: Tue, 30 Sep 2025 15:56:12 +0100 From: Leo Yan To: James Clark Cc: Suzuki K Poulose , Mike Leach , Alexander Shishkin , Jonathan Corbet , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v2 4/6] coresight: Refactor etm4_config_timestamp_event() Message-ID: <20250930145612.GJ7985@e132581.arm.com> References: <20250814-james-cs-syncfreq-v2-0-c76fcb87696d@linaro.org> <20250814-james-cs-syncfreq-v2-4-c76fcb87696d@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250814-james-cs-syncfreq-v2-4-c76fcb87696d@linaro.org> On Thu, Aug 14, 2025 at 11:49:55AM +0100, James Clark wrote: > Remove some of the magic numbers and try to clarify some of the > documentation so it's clearer how this sets up the timestamp interval. > > Return errors directly instead of jumping to out and returning ret, > nothing needs to be cleaned up at the end and it only obscures the flow > and return value. > > Signed-off-by: James Clark Reviewed-by: Leo Yan