From: Steven Rostedt <rostedt@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Andrew Morton <akpm@linux-foundation.org>,
Qianfeng Rong <rongqianfeng@vivo.com>
Subject: [for-next][PATCH 03/11] tracing: Use vmalloc_array() to improve code
Date: Tue, 30 Sep 2025 13:01:38 -0400 [thread overview]
Message-ID: <20250930170301.699930470@kernel.org> (raw)
In-Reply-To: <20250930170135.285740909@kernel.org>
From: Qianfeng Rong <rongqianfeng@vivo.com>
Remove array_size() calls and replace vmalloc() with vmalloc_array() in
tracing_map_sort_entries(). vmalloc_array() is optimized better, uses
fewer instructions, and handles overflow more concisely[1].
[1]: https://lore.kernel.org/lkml/abc66ec5-85a4-47e1-9759-2f60ab111971@vivo.com/
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Link: https://lore.kernel.org/20250817084725.59477-1-rongqianfeng@vivo.com
Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
kernel/trace/tracing_map.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/tracing_map.c b/kernel/trace/tracing_map.c
index 1921ade45be3..7f8da4dab69d 100644
--- a/kernel/trace/tracing_map.c
+++ b/kernel/trace/tracing_map.c
@@ -1076,7 +1076,7 @@ int tracing_map_sort_entries(struct tracing_map *map,
struct tracing_map_sort_entry *sort_entry, **entries;
int i, n_entries, ret;
- entries = vmalloc(array_size(sizeof(sort_entry), map->max_elts));
+ entries = vmalloc_array(map->max_elts, sizeof(sort_entry));
if (!entries)
return -ENOMEM;
--
2.50.1
next prev parent reply other threads:[~2025-09-30 17:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-30 17:01 [for-next][PATCH 00/11] tracing: Updates for v6.18 Steven Rostedt
2025-09-30 17:01 ` [for-next][PATCH 01/11] tracing: Replace syscall RCU pointer assignment with READ/WRITE_ONCE() Steven Rostedt
2025-09-30 17:01 ` [for-next][PATCH 02/11] tracing: Have syscall trace events show "0x" for values greater than 10 Steven Rostedt
2025-09-30 17:01 ` Steven Rostedt [this message]
2025-09-30 17:01 ` [for-next][PATCH 04/11] tracing/osnoise: Use for_each_online_cpu() instead of for_each_cpu() Steven Rostedt
2025-09-30 17:01 ` [for-next][PATCH 05/11] tracing: Move buffer in trace_seq to end of struct Steven Rostedt
2025-09-30 17:01 ` [for-next][PATCH 06/11] tracing: Remove redundant 0 value initialization Steven Rostedt
2025-09-30 17:01 ` [for-next][PATCH 07/11] tracing: replace use of system_wq with system_percpu_wq Steven Rostedt
2025-09-30 17:01 ` [for-next][PATCH 08/11] tracing/osnoise: Replace kmalloc() + copy_from_user() with memdup_user() Steven Rostedt
2025-09-30 17:01 ` [for-next][PATCH 09/11] ftrace: Fix softlockup in ftrace_module_enable Steven Rostedt
2025-09-30 17:01 ` [for-next][PATCH 10/11] tracing: Ensure optimized hashing works Steven Rostedt
2025-09-30 17:01 ` [for-next][PATCH 11/11] tracing: Fix lock imbalance in s_start() memory allocation failure path Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250930170301.699930470@kernel.org \
--to=rostedt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rongqianfeng@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®