mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: Danilo Krummrich <dakr@kernel.org>
Cc: "Alexandre Courbot" <acourbot@nvidia.com>,
	"Joel Fernandes" <joelagnelf@nvidia.com>,
	"Timur Tabi" <ttabi@nvidia.com>,
	"Alistair Popple" <apopple@nvidia.com>,
	"Zhi Wang" <zhiw@nvidia.com>, "Surath Mitra" <smitra@nvidia.com>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	nouveau@lists.freedesktop.org, linux-pci@vger.kernel.org,
	rust-for-linux@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	"John Hubbard" <jhubbard@nvidia.com>
Subject: [PATCH 1/2] rust: pci: add is_virtfn(), to check for VFs
Date: Tue, 30 Sep 2025 15:07:58 -0700	[thread overview]
Message-ID: <20250930220759.288528-2-jhubbard@nvidia.com> (raw)
In-Reply-To: <20250930220759.288528-1-jhubbard@nvidia.com>

Add a method to check if a PCI device is a Virtual Function (VF). This
allows Rust drivers to determine whether a device is a VF created
through SR-IOV. This is required in order to implement VFIO, because
drivers such as NovaCore must only bind to Physical Functions (PFs) or
regular PCI devices. The VFs must be left unclaimed, so that a VFIO
kernel module can claim them.

is_virtfn() returns true if the device's is_virtfn flag is set, matching
the behavior of the C code.

Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
 rust/kernel/pci.rs | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/rust/kernel/pci.rs b/rust/kernel/pci.rs
index 7fcc5f6022c1..476b80f05905 100644
--- a/rust/kernel/pci.rs
+++ b/rust/kernel/pci.rs
@@ -496,6 +496,12 @@ pub fn resource_start(&self, bar: u32) -> Result<bindings::resource_size_t> {
         Ok(unsafe { bindings::pci_resource_start(self.as_raw(), bar.try_into()?) })
     }
 
+    /// Returns true if this device is a Virtual Function (VF).
+    pub fn is_virtfn(&self) -> bool {
+        // SAFETY: `self.as_raw` is a valid pointer to a `struct pci_dev`.
+        unsafe { (*self.as_raw()).is_virtfn() != 0 }
+    }
+
     /// Returns the size of the given PCI bar resource.
     pub fn resource_len(&self, bar: u32) -> Result<bindings::resource_size_t> {
         if !Bar::index_is_valid(bar) {
-- 
2.51.0


  reply	other threads:[~2025-09-30 22:08 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-30 22:07 [PATCH 0/2] rust: pci: expose is_virtfn() and reject VFs in nova-core John Hubbard
2025-09-30 22:07 ` John Hubbard [this message]
2025-10-01  0:30   ` [PATCH 1/2] rust: pci: add is_virtfn(), to check for VFs Alistair Popple
2025-09-30 22:07 ` [PATCH 2/2] gpu: nova-core: reject binding to SR-IOV Virtual Functions John Hubbard
2025-10-01  0:33   ` Alistair Popple
2025-10-01  1:26     ` John Hubbard
2025-10-01  0:26 ` [PATCH 0/2] rust: pci: expose is_virtfn() and reject VFs in nova-core Alexandre Courbot
2025-10-01  1:26   ` John Hubbard
2025-10-01  1:39     ` Alexandre Courbot
2025-10-01  1:45       ` John Hubbard
2025-10-01  8:09         ` Zhi Wang
2025-10-01 14:48           ` Jason Gunthorpe
2025-10-01 21:13             ` Zhi Wang
2025-10-02  1:43               ` Alexandre Courbot
2025-10-02  1:50                 ` John Hubbard
2025-10-02 11:58               ` Jason Gunthorpe
2025-10-02 12:59                 ` Zhi Wang
2025-10-02 13:42                   ` Jason Gunthorpe
2025-10-02 14:29                     ` Zhi Wang
2025-10-02 14:31                       ` Jason Gunthorpe
2025-10-07  6:51                         ` Zhi Wang
2025-10-07 10:14                           ` Danilo Krummrich
2025-10-07 11:00                             ` Zhi Wang
2025-10-07 11:26                           ` Jason Gunthorpe
2025-10-01 14:46     ` Jason Gunthorpe
2025-10-01 18:16       ` Alex Williamson
2025-10-01 18:30         ` Jason Gunthorpe
2025-10-01 22:35           ` John Hubbard
2025-10-02  7:41   ` Zhi Wang
2025-10-01  0:29 ` Alistair Popple
2025-10-01  1:22   ` John Hubbard
2025-10-01 10:32     ` Danilo Krummrich
2025-10-01 13:52       ` Zhi Wang
2025-10-01 22:38         ` John Hubbard
2025-10-01 22:52           ` Danilo Krummrich
2025-10-01 23:00             ` John Hubbard
2025-10-01 23:47               ` Joel Fernandes
2025-10-01 23:51                 ` John Hubbard
2025-10-01 23:55                   ` Danilo Krummrich
2025-10-02  0:48                     ` Joel Fernandes
2025-10-02  0:54                       ` John Hubbard
2025-10-02 12:05                         ` Jason Gunthorpe
2025-10-02 12:01             ` Jason Gunthorpe
2025-10-02 12:08               ` Danilo Krummrich
2025-10-02 12:32                 ` Jason Gunthorpe
2025-10-02 12:41                   ` Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250930220759.288528-2-jhubbard@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=a.hindborg@kernel.org \
    --cc=acourbot@nvidia.com \
    --cc=airlied@gmail.com \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=apopple@nvidia.com \
    --cc=bhelgaas@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=joelagnelf@nvidia.com \
    --cc=kwilczynski@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=simona@ffwll.ch \
    --cc=smitra@nvidia.com \
    --cc=tmgross@umich.edu \
    --cc=ttabi@nvidia.com \
    --cc=zhiw@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome