From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 874E72ECD01 for ; Fri, 3 Oct 2025 12:04:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759493044; cv=none; b=tgVQC0fDiJO8T/B2NWLuEEtshJFopi+N8qNcziGzyfxe/VsvU0nTV1IcSt9nyIQW6FK8+Dx5Lwsl2Qm9FS7By05KUJ29NIGKFexVaFKd6KIzcG2rdz+FX1FUn/qdjZcuT9vx8y3ZzlhEcUnPpzh2iHA7WaqBB9D83xubm1Od1hA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759493044; c=relaxed/simple; bh=yCCP5s9lTzTlxvPaMrvl2U2nWczarzv5lVR64JUY0XQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aZ5Rj3yb2HcJW+uWQXBS97HvGGqwLdIxZDNna5ENyUFD1R2CeJiUqErXgYHBJoQosSDkP0ZR0JkgasqJrKRxAeuSY9rR3mEOsW8FVh3BM+8H/M6bKdUb+Kb4C8QGV/FgdEU1Wi1dNmSbbEj/wMADUzHHUDbyhycXLUe92q0UYbM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=i2AX0r50; arc=none smtp.client-ip=209.85.222.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="i2AX0r50" Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-85c66a8a462so306050585a.0 for ; Fri, 03 Oct 2025 05:04:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1759493041; x=1760097841; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=vyK6EDMdZhWcTtV/wan5DW3m1OGhyAdsB4+u9LiW5EY=; b=i2AX0r50q/9oVJ8tX94qI3pxl3kAvtWezIgySUen8HnwtgwH2n8nNzHoF70arI3bjK QOFS7UAE4JjG3DId8KUUv+VY0n1bcVufOr1TD/bIsykp59nDi3avWz6fVJyTMM8YCr1v PbVSrlu5VCZNp4sNea3ngiykrROoc2HUhNVNWTS8AiHG+HcPsoUuswI0JBOL2IhaZnxd 5ZAmCaBQecYpJyHS7LSFD6IZMdX/aiyebqFacWlV8FsyswOP2ICCrPxZgsfBJFIA2mKE QY5Yy8jKo0NZUjzsFfmJs3yNIrMDticvDxS6Q2xz6s+EDYwQ2esBw+cohQCip7xUg82a fb9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759493041; x=1760097841; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vyK6EDMdZhWcTtV/wan5DW3m1OGhyAdsB4+u9LiW5EY=; b=eCP+myrfJkk5RKU29397CpdcdjFGbPzxkIdVqa0CvQxzFQXzd4RTlUTLnKThq5UlLG TtO7aQqtp25/JNe2/BgNrlY8imaduRlAMACHmvQ1/6najHuhxjX3WLKR7XDTdMoeAf5l Lc+fzQJqqICc8X446Idn3gfyIDhIH35+HoNLSPVqevZkhmqvXZM/bsnutUos6B7027Gj ZVi9K80XnYAvmojyS3Onmjfxx3XApzinrbFLtNQX1QasLtBRAXlxySX7SDmoEf0Z/1vS BV4GQYXHwpITzNhC4ZS4jgwvdxBSUQyPCXp21vXtC3n89V9iW4FWewnlDwQ4nKyWuVKU T6uA== X-Forwarded-Encrypted: i=1; AJvYcCWXdZYwgFz4gaxlk16bV+AUMPtNAEd0UPxWdut/McM5/qThHLLYXepKPMSp74ZmwmWpjOI4Tq6G4UekD0E=@vger.kernel.org X-Gm-Message-State: AOJu0Yyilo7sh4E7ELPdIpdl7b2TtXIx776Mn8WRwZHUUOXKEctuguI/ VhE+K9/d/LdmrJhgDv4BHXRBMXNc733zmAVGF7zK/p3vXz28vKrQznnykwqahCavh0o= X-Gm-Gg: ASbGnct1xiDSQcCyjJtKN1dJT+CgrNGGuEyCsvy2xd5EflA5biYbD0FgGpiCkbJ921G vC8hhozqPFi99XXJaj0zlFlFN2/kOuXAs33/iVB4G5KReenvtPWcggEqjibLPmG0or1MF8lzhD1 ANBBADywNMDlyDFi8f50RBBfU2MkkJC4twCHbQmqWg4XTbtkFuqFTA9N4kK/vMH6NgQUyRjWaOi iE4YEWLPmo55HBQCeQ4+Anx+yiOxMfruvN/Er1LC6FpkZQoXgl981meGSXe9R+CnD3RigJ0k6k3 YggxJU45Dj+27rErlzefdLvDi/quHSIkxEqjKdjoVdXyljJifkRQkvw7tV6aUPSyD9tvIMnn4AG 4rNxXsu3m3FKRX6Bz1b2uirbnOCOH5HDwRILVloqJk3Ii6V7qxaM6Ymb0nHDmG3LUXkSp2g51AF jtGomhBT/z4sk4MaVp X-Google-Smtp-Source: AGHT+IG9u6J/XxiDHAEh0uQ+ECKUfFxeEFaK0PE7MiU6DsChuKmxi8Y6PiMSOlaUnZoft+5pp0GGAA== X-Received: by 2002:a05:620a:4101:b0:870:6891:9c1c with SMTP id af79cd13be357-87a37ea1664mr359649085a.35.1759493041309; Fri, 03 Oct 2025 05:04:01 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-47-55-120-4.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.120.4]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4e55cadcecdsm39906701cf.23.2025.10.03.05.03.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Oct 2025 05:03:59 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1v4eVy-0000000E4mn-3rSP; Fri, 03 Oct 2025 09:03:58 -0300 Date: Fri, 3 Oct 2025 09:03:58 -0300 From: Jason Gunthorpe To: David Matlack Cc: Chris Li , Bjorn Helgaas , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Len Brown , Pasha Tatashin , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, Pasha Tatashin , Jason Miu , Vipin Sharma , Saeed Mahameed , Adithya Jayachandran , Parav Pandit , William Tu , Mike Rapoport , Leon Romanovsky Subject: Re: [PATCH v2 03/10] PCI/LUO: Forward prepare()/freeze()/cancel() callbacks to driver Message-ID: <20251003120358.GL3195829@ziepe.ca> References: <20250916-luo-pci-v2-0-c494053c3c08@kernel.org> <20250916-luo-pci-v2-3-c494053c3c08@kernel.org> <20250929174831.GJ2695987@ziepe.ca> <20250930163837.GQ2695987@ziepe.ca> <20251002232153.GK3195829@ziepe.ca> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Oct 02, 2025 at 04:42:17PM -0700, David Matlack wrote: > On Thu, Oct 2, 2025 at 4:21 PM Jason Gunthorpe wrote: > > On Thu, Oct 02, 2025 at 02:31:08PM -0700, David Matlack wrote: > > > And we don't care about PF drivers until we get to > > > supporting SR-IOV. So the driver callbacks all seem unnecessary at > > > this point. > > > > I guess we will see, but I'm hoping we can get quite far using > > vfio-pci as the SRIOV PF driver and don't need to try to get a big PF > > in-kernel driver entangled in this. > > So far we have had to support vfio-pci, pci-pf-stub, and idpf as PF > drivers, and nvme looks like it's coming soon :( How much effort did you put into moving them to vfio though? Hack Hack in the kernel is easy, but upstreaming may be very hard :\ Shutting down enough of the PF kernel driver to safely kexec is almost the same as unbinding it completely. Jason