From: Peter Zijlstra <peterz@infradead.org>
To: Tejun Heo <tj@kernel.org>
Cc: "Steven Rostedt" <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
"Ingo Molnar" <mingo@kernel.org>,
"Juri Lelli" <juri.lelli@redhat.com>,
"Vincent Guittot" <vincent.guittot@linaro.org>,
"Waiman Long" <longman@redhat.com>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Koutný" <mkoutny@suse.com>,
"Andrea Righi" <righi.andrea@gmail.com>,
"Julia Lawall" <Julia.Lawall@inria.fr>,
"Luis Claudio R. Goncalves" <lgoncalv@redhat.com>,
"Joseph Salisbury" <joseph.salisbury@oracle.com>
Subject: Re: [PATCH] sched: cgroup: Move task_can_attach() to cpuset.c
Date: Mon, 6 Oct 2025 20:31:59 +0200 [thread overview]
Message-ID: <20251006183159.GW3245006@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <aOBCQYxZp05lI6jA@slm.duckdns.org>
On Fri, Oct 03, 2025 at 11:38:09AM -1000, Tejun Heo wrote:
> On Fri, Oct 03, 2025 at 12:14:21PM -0400, Steven Rostedt wrote:
> > From: Steven Rostedt <rostedt@goodmis.org>
> >
> > At our monthly stable meeting, we were talking about documenting non
> > static functions and randomly picked a function to look at. That was
> > task_can_attach(). It was then noticed that it's only used by
> > cgroup/cpuset.c and nothing else. It's a simple function that doesn't
> > reference anything unique to sched/core.c, hence there's no reason that
> > function should be there.
> >
> > Move it to cgroup/cpuset.c as that's the only place it is used. Also make
> > it a static inline as it is so small.
> >
> > Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
>
> Peter, if it looks good to you, I can route it through cgroup tree.
Yeah, I suppose so. But there were suggested changes to the Changelog
and actual patch so perhaps wait for v2?
next prev parent reply other threads:[~2025-10-06 18:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-03 16:14 Steven Rostedt
2025-10-03 16:36 ` Andrea Righi
2025-10-03 16:43 ` Steven Rostedt
2025-10-03 16:53 ` Andrea Righi
2025-10-03 16:39 ` Waiman Long
2025-10-03 17:11 ` Luis Claudio R. Goncalves
2025-10-03 19:56 ` [External] : " Joseph Salisbury
2025-10-03 21:38 ` Tejun Heo
2025-10-06 18:31 ` Peter Zijlstra [this message]
2025-10-06 18:59 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251006183159.GW3245006@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Julia.Lawall@inria.fr \
--cc=hannes@cmpxchg.org \
--cc=joseph.salisbury@oracle.com \
--cc=juri.lelli@redhat.com \
--cc=lgoncalv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@kernel.org \
--cc=mkoutny@suse.com \
--cc=righi.andrea@gmail.com \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®