mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Menglong Dong <menglong8.dong@gmail.com>,
	Thorsten Blum <thorsten.blum@linux.dev>,
	Steven Rostedt <rostedt@goodmis.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] probes: Update for v6.18
Date: Mon, 6 Oct 2025 21:01:39 +0900	[thread overview]
Message-ID: <20251006210139.122cad3973a85f93601082fa@kernel.org> (raw)
In-Reply-To: <CAHk-=whpwrrkPCmPa1dnejVr8AcJVpfyh0CfD-3sNhUO47A1dQ@mail.gmail.com>

On Sun, 5 Oct 2025 20:09:02 -0700
Linus Torvalds <torvalds@linux-foundation.org> wrote:

> On Sun, 5 Oct 2025 at 17:27, Masami Hiramatsu <mhiramat@kernel.org> wrote:
> >
> > Hmm, I applogise this error. I locally ran build tests and it passed.
> > But I might missed something.
> 
> So this is why linux-next exists - to get testing with different
> configurations, different compiler versions, different architectures
> etc.

Yes, I have noticed the limitations of creating a local test environment,
and I would like to utilize linux-next.

> 
> Local build tests are good, and obviously necessary for some very basic testing.
> 
> And local build test can be perfectly sufficient - if it's some small
> obvious fix, it's often simply not worth it waiting for a few days for
> linux-next to get it merged and tested.
> 
> And no, linux-next isn't perfect, and won't find everything anyway.
> 
> And even the most trivial small change that quite reasonably didn't go
> through linux-next because it was so simple can also end up breaking
> things.
> 
> So none of this is some kind of "absolute black-and-white rule", and
> none of this _guarantees_ that everything always works.
> 
> Even when everybody does the best they can, something will
> occasionally be missed. I definitely accept that we're not perfect.
> 
> But big new features coming in during the merge window had better be
> extensively checked _some_ way.

Yes, that was my fault.

> 
> If I find problems in my fairly limited sanity-check build tests, I get unhappy.
> 
> It's one thing if it's some little mistake that I feel reasonably
> missed testing for some understandable reason.
> 
> But if I get the feeling that the problem was that there just wasn't
> enough care to begin with, that's when I go "nope, this will need to
> wait for another release and be done properly".
> 
> And that's what happened this time around. That wasn't some trivial
> little change, and it clearly didn't get a lot of coverage testing.

I'm very sorry about causing this.

> 
> It should have gone through linux-next, and the problem would have
> been found there instead of when I tried to merge it.

Next time I'm sure the features are at least tested on linux-next.
I'm trying to update my PR checker to check it too.

> 
>                Linus


-- 
Masami Hiramatsu (Google) <mhiramat@kernel.org>

      reply	other threads:[~2025-10-06 12:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-02 23:44 Masami Hiramatsu
2025-10-05 16:20 ` Linus Torvalds
2025-10-06  0:27   ` Masami Hiramatsu
2025-10-06  0:50     ` Masami Hiramatsu
2025-10-06  3:09     ` Linus Torvalds
2025-10-06 12:01       ` Masami Hiramatsu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251006210139.122cad3973a85f93601082fa@kernel.org \
    --to=mhiramat@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=menglong8.dong@gmail.com \
    --cc=rostedt@goodmis.org \
    --cc=thorsten.blum@linux.dev \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®