From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB4FDA93D for ; Tue, 7 Oct 2025 05:55:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759816522; cv=none; b=g9sg49yvokp2elKmxx/kyK1rX78rD+qehsveGM0nM5It7hGWnMlJxPmW6iYNdQk2LFer/wFOSiue7cdLoGLoFD67QCYQRQ8Kg51mLipZGlPdnK4omF0lgXz5RvAb83GBrRll8dLpYyQiFDKH/aFNb0lcQswPfsgjDXS61wwkrXE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759816522; c=relaxed/simple; bh=168NfD/ecb5wgu5xNFlCaKmte6hBtMqFpQKOiKMR9bg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=l7RBP/5ow5dPPUKvpvm276Eh+lbWIUy5SvGt2QMGHUJNNJ5lVIJN1RIgdXz0BfzIAh8gnyP9ddhU5wbnrIyhMZMW9MaechAQSn8wm9kfTfoEKyQdHW+LPUmpjtNcvsE7YVau3i1WWHWFNw79OK/T4BLuaZ3h5aaw19zSDjdo0lI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nElzAMXN; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nElzAMXN" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-32eb45ab7a0so6378997a91.0 for ; Mon, 06 Oct 2025 22:55:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759816520; x=1760421320; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=LZghIXdaSi6t4gvdCfT5o16EuMxkJyf71bvQeFQdK0A=; b=nElzAMXNwLAIuqsktVYxSH7O0Rd5U5lEOggjTm7nc4IF9ofS+G/FPiLYjn4MLocpIX qe+h/ZpcI5r524rkMVo1mzsuqxYc/yQ6rG34o1M+5XNBlaNiMIJy2S4SohUw99UUYllK C9RDfH5wtf3zVUfHV9sYRO2HhEFnRD2hKb/tuLKms46qaCM3XMB0ec4CLYmw79S2llYo 9AEzaoKspOPmC73ScvVQiARYaQDkMLwCPKkvfznPS0wLUXhLTQ6YUXORc7mPmjGMdr2t bT7OfVl1OG6hXhVCV15VwkP6szjDym4xFn/DyKpwbJmTJL0U1sZNccMeMyHlyEvT83FR nsLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759816520; x=1760421320; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LZghIXdaSi6t4gvdCfT5o16EuMxkJyf71bvQeFQdK0A=; b=GakP8GuvLKny/S7cOXjeJhH9wyyFj8axMDCZFtxNXT/iL718SG63jHMGNF0b5DdVv+ P3Fh8LHK4RVh8VGnTItLX2LcVDy9HR7zZofpfINAuP+zQGnlyF84IfYXm57KXQibx1vt Vx0sfGgkDLap8Y9mwipSP2roWTcWGm7IQye4u9qKJ6CPxm0SEBodUmVm0Xjj6nXL0A5l wKFIrwrSSx2JiZGbDznohdDNR4R5oy0w3V9xFTMUchA7abFs1U0eX2I7+Gd5LdBJwXt+ KQsEOF6chAZgsQpiZSwd+opZ9mQlyouKWjqgptAA4Dpbo4ltFhFPax2pr3vUxNXMhoOi 7v1g== X-Forwarded-Encrypted: i=1; AJvYcCWrvGRaxYu3/c4mXJ8HJsCflt/4hQNzXxIcM/4iXOz0E4y+/a/HPR+Bjy1s1N+4jhvn0wVBxMjBLE3vppw=@vger.kernel.org X-Gm-Message-State: AOJu0YyIF2tgMg9spSLh+NLEZuOisQW9hdpBX2tnD0Hs1yjPW167v2z+ fTKhv3n1lv9fzQ8AqVPqAzlZ+MeKjkDlQC6J/NTWNDLbnEjWBP17FzRL X-Gm-Gg: ASbGncttXaXO9666GAh205jzQJE/68l6qAvtOlOPEiTKKnhAEMxfpjkOOz62/WqNrMK R4Q6arw5MLlHk/mHMf79N0prPIPC0vSZi2wd476NBihzj7IL1AmYJiTAy/Fm9bsiXcCcUhrCgnh 6icVO9TUukQxD07iDR2yZXHQgObBcbJZiZ1oKOOtd/Tj5ApDUTtBP7l8YJexb7rcw06Fhh+B1PH pUQMlD3TqJOx6L98VGDoa17LIlZcWniU/hKwJQs0A+6UC8pD6+xf3nHOgOyypT/dV2xaghgKvMv z2zeOdPi5dGQUgQ78nkcoGE6p/PL9WUDpoRWF65KIEoPh8VnBg4KuLcbI4nmhM0ZXX+B0hUTFxt uE9LPnaXFDXouGQyJzmqF5xSCa9QqtiHQkdenJlceU5JO+FnYOxEnCllO X-Google-Smtp-Source: AGHT+IH3yHUpHO8MPfqkfmLVrGO6eAOQw4CzhIMeoYO6hXLvDJrn7+BIDzWj0TidI6q1e0vocpVVwA== X-Received: by 2002:a17:90b:17cc:b0:32e:5cba:ae11 with SMTP id 98e67ed59e1d1-339c27859aamr18418727a91.28.1759816519760; Mon, 06 Oct 2025 22:55:19 -0700 (PDT) Received: from akshayaj-lenovo.. ([223.233.78.22]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-339c4a1a9e8sm12983829a91.11.2025.10.06.22.55.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Oct 2025 22:55:19 -0700 (PDT) From: Akshay Jindal To: dan@dlrobertson.com, jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org Cc: Akshay Jindal , shuah@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 0/6] iio: accel: bma400: Refactor GENINTR config and register macros Date: Tue, 7 Oct 2025 11:25:00 +0530 Message-ID: <20251007055511.108984-1-akshayaj.lkd@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series refactors the BMA400 driver with a focus on generic interrupt configuration and related register usage. The main changes reduce usage of hard-coded values by introducing macros and formula-based register addressing, and add a centralized lookup indexed on iio event direction. Alongside these updates, the series also reorganizes and renames register and field macros for consistency with the datasheet, and extends comments for additional clarity. All patches are pure refactoring. No functional changes are intended. Akshay Jindal (6): iio: accel: bma400: Reorganize and rename register and field macros iio: accel: bma400: Use macros for generic event configuration values iio: accel: bma400: Use index-based register addressing and lookup iio: accel: bma400: Replace bit shifts with FIELD_PREP and FIELD_GET iio: accel: bma400: Rename activity_event_en() to generic_event_en() iio: accel: bma400: Add detail to comments in GEN INTR configuration Changes since v3: - Insert a new patch into the patch series for replacing explicit bit shifts with FIELD_GET and FIELD_PREP macros - Assigned explicit values to reg field enums introduced. Changes since v2: - Split single patch into five smaller patches as suggested - Addressed review comments related to trailing comma [Patch 2/5] - Extended renaming of macros to TAP_CONFIG registers [Patch 1/5] - Addressed review comment received regarding write then replace in activity_event_en() [Patch 3/5] Testing Summary: - Tested on raspberrypi 4b and 7-semi bma400 sensor breakout board. - Since no functional impact is there, so before functionality is expected to be equal to after change functionality. - Tested mapping of GEN1 and GEN2 both on INT1 pin as before. - Tested both activity and inactivity detection by setting attributes events/in_accel_mag_falling_en as well as events/in_accel_mag_rising_en. - Did read and writes on various attributes such that write_event_config(), write_event_value() and read_event_value() callbacks are triggered. drivers/iio/accel/bma400.h | 148 +++++++++----- drivers/iio/accel/bma400_core.c | 349 ++++++++++++++++++-------------- 2 files changed, 285 insertions(+), 212 deletions(-) -- 2.43.0