From: Peter Zijlstra <peterz@infradead.org>
To: "Jürgen Groß" <jgross@suse.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Josh Poimboeuf <jpoimboe@kernel.org>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v3 15/21] x86/xen: Drop xen_irq_ops
Date: Tue, 7 Oct 2025 12:21:06 +0200 [thread overview]
Message-ID: <20251007102106.GE3245006@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <c8b3c9ea-8c6c-4ec2-b01f-df3f8f487a8c@suse.com>
On Tue, Oct 07, 2025 at 09:47:48AM +0200, Jürgen Groß wrote:
> On 06.10.25 20:55, Peter Zijlstra wrote:
> > On Mon, Oct 06, 2025 at 09:46:00AM +0200, Juergen Gross wrote:
> > > Instead of having a pre-filled array xen_irq_ops for Xen PV paravirt
> > > functions, drop the array and assign each element individually.
> >
> > Same comment for the next few patches; this changelog is a little light
> > on *why*. I mean, I don't mind the change, but supposedly we should
> > justify things at least a little, right? :-)
>
> Would you be fine with the following addition:
>
> This is in preparation of reducing the paravirt include hell by
> splitting paravirt.h into multiple more fine grained header files,
> which will in turn require to split up the pv_ops vector as well.
> Dropping the pre-filled array makes life easier for objtool to
> detect missing initializers in multiple pv_ops_ arrays.
Yes, that'll do. The latter being the main reason in this case, right?
next prev parent reply other threads:[~2025-10-07 10:21 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-06 7:45 [PATCH v3 00/21] paravirt: cleanup and reorg Juergen Gross
2025-10-06 7:45 ` [PATCH v3 01/21] x86/paravirt: Remove not needed includes of paravirt.h Juergen Gross
2025-11-24 13:38 ` Borislav Petkov
2025-11-24 14:26 ` Borislav Petkov
2025-10-06 7:45 ` [PATCH v3 02/21] x86/paravirt: Remove some unneeded struct declarations Juergen Gross
2025-10-23 12:14 ` Borislav Petkov
2025-10-06 7:45 ` [PATCH v3 03/21] x86/paravirt: Remove PARAVIRT_DEBUG config option Juergen Gross
2025-10-06 7:45 ` [PATCH v3 04/21] x86/paravirt: Move thunk macros to paravirt_types.h Juergen Gross
2025-10-06 7:45 ` [PATCH v3 05/21] paravirt: Remove asm/paravirt_api_clock.h Juergen Gross
2025-10-15 16:02 ` Shrikanth Hegde
2025-10-06 7:45 ` [PATCH v3 06/21] sched: Move clock related paravirt code to kernel/sched Juergen Gross
2026-01-07 22:48 ` Alexey Makhalov
2025-10-06 7:45 ` [PATCH v3 07/21] arm/paravirt: Use common code for paravirt_steal_clock() Juergen Gross
2025-10-06 7:45 ` [PATCH v3 08/21] arm64/paravirt: " Juergen Gross
2025-10-06 7:45 ` [PATCH v3 09/21] loongarch/paravirt: " Juergen Gross
2025-11-24 9:52 ` Bibo Mao
2025-10-06 7:45 ` [PATCH v3 10/21] riscv/paravirt: " Juergen Gross
2025-10-06 7:45 ` [PATCH v3 11/21] x86/paravirt: " Juergen Gross
2025-10-06 7:45 ` [PATCH v3 12/21] x86/paravirt: Move paravirt_sched_clock() related code into tsc.c Juergen Gross
2025-10-06 7:45 ` [PATCH v3 13/21] x86/paravirt: Introduce new paravirt-base.h header Juergen Gross
2025-10-06 7:45 ` [PATCH v3 14/21] x86/paravirt: Move pv_native_*() prototypes to paravirt.c Juergen Gross
2025-10-06 7:46 ` [PATCH v3 15/21] x86/xen: Drop xen_irq_ops Juergen Gross
2025-10-06 18:55 ` Peter Zijlstra
2025-10-07 7:47 ` Jürgen Groß
2025-10-07 10:21 ` Peter Zijlstra [this message]
2025-10-07 10:29 ` Jürgen Groß
2025-10-06 7:46 ` [PATCH v3 16/21] x86/xen: Drop xen_cpu_ops Juergen Gross
2025-10-06 7:46 ` [PATCH v3 17/21] x86/xen: Drop xen_mmu_ops Juergen Gross
2025-10-06 7:46 ` [PATCH v3 18/21] objtool: Allow multiple pv_ops arrays Juergen Gross
2025-10-06 7:46 ` [PATCH v3 19/21] x86/paravirt: Allow pv-calls outside paravirt.h Juergen Gross
2025-10-06 7:46 ` [PATCH v3 20/21] x86/paravirt: Specify pv_ops array in paravirt macros Juergen Gross
2025-10-06 7:46 ` [PATCH v3 21/21] x86/pvlocks: Move paravirt spinlock functions into own header Juergen Gross
2025-10-15 8:53 ` kernel test robot
2025-11-24 9:42 ` [PATCH v3 00/21] paravirt: cleanup and reorg Juergen Gross
2026-02-20 4:10 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251007102106.GE3245006@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome