From: Sergey Matyukevich <geomatsi@gmail.com>
To: linux-riscv@lists.infradead.org, linux-kselftest@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, "Paul Walmsley" <pjw@kernel.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Alexandre Ghiti" <alex@ghiti.fr>,
"Oleg Nesterov" <oleg@redhat.com>,
"Shuah Khan" <shuah@kernel.org>,
"Jisheng Zhang" <jszhang@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Thomas Huth" <thuth@redhat.com>,
"Charlie Jenkins" <charlie@rivosinc.com>,
"Andy Chiu" <andybnac@gmail.com>,
"Han Gao" <rabenda.cn@gmail.com>,
"Samuel Holland" <samuel.holland@sifive.com>,
"Nam Cao" <namcao@linutronix.de>,
"Joel Granados" <joel.granados@kernel.org>,
"Clément Léger" <cleger@rivosinc.com>,
"Conor Dooley" <conor.dooley@microchip.com>,
"Sergey Matyukevich" <geomatsi@gmail.com>,
"Ilya Mamay" <mmamayka01@gmail.com>
Subject: [PATCH v2 2/6] riscv: ptrace: return ENODATA for inactive vector extension
Date: Tue, 7 Oct 2025 14:58:18 +0300 [thread overview]
Message-ID: <20251007115840.2320557-3-geomatsi@gmail.com> (raw)
In-Reply-To: <20251007115840.2320557-1-geomatsi@gmail.com>
From: Ilya Mamay <mmamayka01@gmail.com>
Currently, ptrace returns EINVAL when the vector extension is supported
but not yet activated for the traced process. This error code is
inappropriate since all the ptrace arguments are valid.
Debug tools like gdbserver expect ENODATA when the requested register
set is not active, e.g. see [1]. This expectation seems to be more
appropriate, so modify the vector ptrace implementation to return:
- EINVAL when V extension is not supported
- ENODATA when V extension is supported but not active
[1] https://github.com/bminor/binutils-gdb/blob/637f25e88675fa47e47f9cc5e2cf37384836b8a2/gdbserver/linux-low.cc#L5020
Signed-off-by: Ilya Mamay <mmamayka01@gmail.com>
---
arch/riscv/kernel/ptrace.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/arch/riscv/kernel/ptrace.c b/arch/riscv/kernel/ptrace.c
index 8e86305831ea..906cf1197edc 100644
--- a/arch/riscv/kernel/ptrace.c
+++ b/arch/riscv/kernel/ptrace.c
@@ -95,9 +95,12 @@ static int riscv_vr_get(struct task_struct *target,
struct __riscv_v_ext_state *vstate = &target->thread.vstate;
struct __riscv_v_regset_state ptrace_vstate;
- if (!riscv_v_vstate_query(task_pt_regs(target)))
+ if (!has_vector())
return -EINVAL;
+ if (!riscv_v_vstate_query(task_pt_regs(target)))
+ return -ENODATA;
+
/*
* Ensure the vector registers have been saved to the memory before
* copying them to membuf.
@@ -130,9 +133,12 @@ static int riscv_vr_set(struct task_struct *target,
struct __riscv_v_ext_state *vstate = &target->thread.vstate;
struct __riscv_v_regset_state ptrace_vstate;
- if (!riscv_v_vstate_query(task_pt_regs(target)))
+ if (!has_vector())
return -EINVAL;
+ if (!riscv_v_vstate_query(task_pt_regs(target)))
+ return -ENODATA;
+
/* Copy rest of the vstate except datap */
ret = user_regset_copyin(&pos, &count, &kbuf, &ubuf, &ptrace_vstate, 0,
sizeof(struct __riscv_v_regset_state));
--
2.51.0
next prev parent reply other threads:[~2025-10-07 11:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-07 11:58 [PATCH v2 0/6] riscv: vector: misc ptrace fixes for debug use-cases Sergey Matyukevich
2025-10-07 11:58 ` [PATCH v2 1/6] selftests: riscv: test ptrace vector interface Sergey Matyukevich
2025-10-07 11:58 ` Sergey Matyukevich [this message]
2025-10-07 11:58 ` [PATCH v2 3/6] selftests: riscv: set invalid vtype using ptrace Sergey Matyukevich
2025-10-07 11:58 ` [PATCH v2 4/6] riscv: vector: allow to force vector context save Sergey Matyukevich
2025-10-15 20:18 ` Andy Chiu
2025-10-15 21:32 ` Andy Chiu
2025-10-19 21:29 ` Sergey Matyukevich
2025-10-21 21:53 ` Andy Chiu
2025-10-07 11:58 ` [PATCH v2 5/6] selftests: riscv: verify initial vector state with ptrace Sergey Matyukevich
2025-10-07 11:58 ` [PATCH v2 6/6] riscv: vector: initialize vlenb on the first context switch Sergey Matyukevich
2025-10-15 19:54 ` Andy Chiu
2025-10-19 21:43 ` Sergey Matyukevich
2025-10-21 22:07 ` Andy Chiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251007115840.2320557-3-geomatsi@gmail.com \
--to=geomatsi@gmail.com \
--cc=alex@ghiti.fr \
--cc=andybnac@gmail.com \
--cc=aou@eecs.berkeley.edu \
--cc=charlie@rivosinc.com \
--cc=cleger@rivosinc.com \
--cc=conor.dooley@microchip.com \
--cc=joel.granados@kernel.org \
--cc=jszhang@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mmamayka01@gmail.com \
--cc=namcao@linutronix.de \
--cc=oleg@redhat.com \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=rabenda.cn@gmail.com \
--cc=samuel.holland@sifive.com \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®