From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6700121CC71 for ; Tue, 7 Oct 2025 18:06:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759860408; cv=none; b=TeHwMZdSPUCO+ZdH518uPrL40t0oSYdk+QEBs6PL8CwSB5lZaTsnJSc/QxBnp4hi7YVB7acB9/uq96E2vd7tV5qHHV80sc93cS9W2BvxfHWqNuP7JYKuHLQ8038YC1huFKGVfC+H6ewxyGFooPduNv3lcr9iUmdp/XNoaGwlQIU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759860408; c=relaxed/simple; bh=q6J61bs7L3ujukcqpOfn3PO8VFKDKO+odJmf7OZwqE8=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=UBHQwo2xlqWM1JUQZweSVI3eA4hAulYHUzexzcxdTIMmnhf71G/ea+C/j7GAsGXyIsvPzZIWog8jT5myF/oLaKw9zeo/O7b8ExBRNSFtLba+Y11XyhQGsaX5KgWZIuO1bElaz82VY871BUBbFbDuxvsUesKJww2n73bY9D3s1n0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--wyihan.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=4WjB5Zx3; arc=none smtp.client-ip=209.85.210.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--wyihan.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="4WjB5Zx3" Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-7821487d16bso11706997b3a.1 for ; Tue, 07 Oct 2025 11:06:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1759860404; x=1760465204; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Jy9uoa9n7CiOeOtHRkWJVJ718GS54wk/TvFhgvjRAGk=; b=4WjB5Zx3PWSn2EIrhSL5yvD4QblGhEl3eUBlngvYpz8eOaY/SU1SNEIN1hw5bUrlmQ rNqjnHz5YhQm0mZpXIZmTp3Av3Zb5Rfygjt4aQqCsgLz/QYNLuCVkwRyxD6CDcIuL+Yc 2iEN0BauroDWgcUe0ScyEFVwaTyDgvoqa3XTsDsmG3/2WYkxAhpb3vpG77sru8uQBwb1 c+avHlkhaON8oQ3JhJROrKeUzeWnYsC/qCze5wSguIjQofTze2TYZXzvOVsBqve1VBx8 KE/+8UGQ9f1k3zEvYaoNbTQa1JWMbkoGtnU8BzxkmNv8THAMsQ1pFNoud1PX3wvDIgQS q06w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759860404; x=1760465204; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Jy9uoa9n7CiOeOtHRkWJVJ718GS54wk/TvFhgvjRAGk=; b=cX96Eehj6CKOUQ5zHCM9ulfBd2A6DATnu7HreiqScIJzhDFAer6noPG6uUf7DR0opB 2377F3EbABQEfL8qJ4OWJ4CpgpLDpXaDhBfqjkClf9H7nhoilTnZduZrRkd2KS49v+d7 CelTW/j872KGnjg43dyyF7AI1/lNiiZbWyH3DE93g0S5vBTkQ0c9qiDwWneN7HJPFYoF ofrVkCMEh78b2L5TOYU0jVt5EHDqJJp2A+M2sd986sDlDkeseaNJj204rrydohJevm5G rHnMXL/CenR1zSo2otzSQBpKfqdoGM2u3cMvtcbzmgpeSvJLMReKSRwSnOaKMhhEmRSJ f73Q== X-Forwarded-Encrypted: i=1; AJvYcCX0Mxk4EApgxLppIfFlmVA6oTogJOCIgaX0rEtdA5ddVT9QVFdswh+GsfBY4eE3WbScuv2DRE2+R5TwTNo=@vger.kernel.org X-Gm-Message-State: AOJu0YwgqlHAsC3JWlupZtRzR+bN7yCed1lyF0XuJh5Jtlg24qy8n6YR y+WiqRhEj1MCMpRTs2518S9VA0YPNpGuo6hl+X8syrhWlZy8eKK7WDvWxBeVa4T8o91vbnlteq8 bxaZSFg== X-Google-Smtp-Source: AGHT+IFM0FyD52n4COlTUfeE1w0IfmK3uQQePrMvE9YP1sa7uKjBgBKdHuInhyl0TsFz1oW0BpvBogVlPbg= X-Received: from pfms2.prod.google.com ([2002:aa7:8282:0:b0:781:1d87:4584]) (user=wyihan job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:891:b0:77e:cac4:446e with SMTP id d2e1a72fcca58-79387e0539cmr513966b3a.31.1759860404519; Tue, 07 Oct 2025 11:06:44 -0700 (PDT) Date: Tue, 7 Oct 2025 18:06:06 +0000 In-Reply-To: <20251003232606.4070510-14-seanjc@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251003232606.4070510-14-seanjc@google.com> X-Mailer: git-send-email 2.51.0.710.ga91ca5db03-goog Message-ID: <20251007180606.940219-1-wyihan@google.com> Subject: Re: [PATCH v2 13/13] KVM: selftests: Verify that reads to inaccessible guest_memfd VMAs SIGBUS From: Lisa Wang To: seanjc@google.com Cc: ackerleytng@google.com, borntraeger@linux.ibm.com, david@redhat.com, frankja@linux.ibm.com, imbrenda@linux.ibm.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, pbonzini@redhat.com, tabba@google.com, Lisa Wang Content-Type: text/plain; charset="UTF-8" Sean Christopherson writes: > Expand the guest_memfd negative testcases for overflow and MAP_PRIVATE to > verify that reads to inaccessible memory also get a SIGBUS. > > Opportunistically fix the write path to use the "val" instead of hardcoding > the literal value a second time, and to use TEST_FAIL(...) instead of > TEST_ASSERT(false, ...). > Reviewed-by: Lisa Wang Tested-by: Lisa Wang > Signed-off-by: Sean Christopherson > --- > tools/testing/selftests/kvm/guest_memfd_test.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testing/selftests/kvm/guest_memfd_test.c > index f5372fdf096d..e7d9aeb418d3 100644 > --- a/tools/testing/selftests/kvm/guest_memfd_test.c > +++ b/tools/testing/selftests/kvm/guest_memfd_test.c > @@ -84,6 +84,7 @@ static void test_fault_sigbus(int fd, size_t accessible_size, size_t map_size) > mem = kvm_mmap(map_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd); > > TEST_EXPECT_SIGBUS(memset(mem, val, map_size)); > + TEST_EXPECT_SIGBUS((void)READ_ONCE(mem[accessible_size])); > > for (i = 0; i < accessible_size; i++) > TEST_ASSERT_EQ(READ_ONCE(mem[i]), val); > -- > 2.51.0.618.g983fd99d29-goog