From: Andrew Morton <akpm@linux-foundation.org>
To: Deepanshu Kartikey <kartikey406@gmail.com>
Cc: mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com,
ocfs2-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
syzbot+6fdd8fa3380730a4b22c@syzkaller.appspotmail.com
Subject: Re: [PATCH v2] ocfs2: clear extent cache after moving/defragmenting extents
Date: Thu, 9 Oct 2025 18:37:22 -0700 [thread overview]
Message-ID: <20251009183722.c81e37002e707135da04c94c@linux-foundation.org> (raw)
In-Reply-To: <20251009154903.522339-1-kartikey406@gmail.com>
On Thu, 9 Oct 2025 21:19:03 +0530 Deepanshu Kartikey <kartikey406@gmail.com> wrote:
> The extent map cache can become stale when extents are moved or
> defragmented, causing subsequent operations to see outdated extent
> flags. This triggers a BUG_ON in ocfs2_refcount_cal_cow_clusters().
We try to avoid BUG_ONs ;)
>
> ...
>
> The problem occurs when:
>
> ...
>
> --- a/fs/ocfs2/move_extents.c
> +++ b/fs/ocfs2/move_extents.c
> @@ -867,6 +867,11 @@ static int __ocfs2_move_extents_range(struct buffer_head *di_bh,
> mlog_errno(ret);
> goto out;
> }
> + /*
> + * Invalidate extent cache after moving/defragging to prevent
> + * stale cached data with outdated extent flags.
> + */
> + ocfs2_extent_map_trunc(inode, cpos);
>
> context->clusters_moved += alloc_size;
> next:
I assume we should backport this into earlier kernels, so I'll add a
cc:stable to the changelog.
It's very nice (but not essential) to add a Fixes: as well, so -stable
maintainers know how far back in time to backport the fix.
next prev parent reply other threads:[~2025-10-10 1:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-09 15:49 Deepanshu Kartikey
2025-10-09 16:18 ` Mark Fasheh
2025-10-10 1:21 ` Joseph Qi
2025-10-11 7:31 ` Heming Zhao
2025-10-10 1:37 ` Andrew Morton [this message]
2025-10-10 2:00 Deepanshu Kartikey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251009183722.c81e37002e707135da04c94c@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jlbec@evilplan.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=kartikey406@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@fasheh.com \
--cc=ocfs2-devel@lists.linux.dev \
--cc=syzbot+6fdd8fa3380730a4b22c@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®