From: Jeongjun Park <aha310510@gmail.com>
To: stable@vger.kernel.org
Cc: gregkh@linuxfoundation.org, tglx@linutronix.de,
Julia.Lawall@inria.fr, akpm@linux-foundation.org,
anna-maria@linutronix.de, arnd@arndb.de,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
linux@roeck-us.net, luiz.dentz@gmail.com, marcel@holtmann.org,
maz@kernel.org, peterz@infradead.org, rostedt@goodmis.org,
sboyd@kernel.org, viresh.kumar@linaro.org,
Jacob Keller <jacob.e.keller@intel.com>,
Jeongjun Park <aha310510@gmail.com>
Subject: [PATCH 6.1.y 11/12] timers: Update the documentation to reflect on the new timer_shutdown() API
Date: Sat, 11 Oct 2025 00:02:51 +0900 [thread overview]
Message-ID: <20251010150252.1115788-12-aha310510@gmail.com> (raw)
In-Reply-To: <20251010150252.1115788-1-aha310510@gmail.com>
From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
[ Upstream commit a31323bef2b66455920d054b160c17d4240f8fd4 ]
In order to make sure that a timer is not re-armed after it is stopped
before freeing, a new shutdown state is added to the timer code. The API
timer_shutdown_sync() and timer_shutdown() must be called before the
object that holds the timer can be freed.
Update the documentation to reflect this new workflow.
[ tglx: Updated to the new semantics and updated the zh_CN version ]
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Anna-Maria Behnsen <anna-maria@linutronix.de>
Link: https://lore.kernel.org/r/20221110064147.712934793@goodmis.org
Link: https://lore.kernel.org/r/20221123201625.375284489@linutronix.de
Signed-off-by: Jeongjun Park <aha310510@gmail.com>
---
Documentation/RCU/Design/Requirements/Requirements.rst | 2 +-
Documentation/core-api/local_ops.rst | 2 +-
Documentation/kernel-hacking/locking.rst | 5 +++++
Documentation/translations/zh_CN/core-api/local_ops.rst | 2 +-
4 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/Documentation/RCU/Design/Requirements/Requirements.rst b/Documentation/RCU/Design/Requirements/Requirements.rst
index 546f23abeca3..49387d823619 100644
--- a/Documentation/RCU/Design/Requirements/Requirements.rst
+++ b/Documentation/RCU/Design/Requirements/Requirements.rst
@@ -1858,7 +1858,7 @@ unloaded. After a given module has been unloaded, any attempt to call
one of its functions results in a segmentation fault. The module-unload
functions must therefore cancel any delayed calls to loadable-module
functions, for example, any outstanding mod_timer() must be dealt
-with via timer_delete_sync() or similar.
+with via timer_shutdown_sync() or similar.
Unfortunately, there is no way to cancel an RCU callback; once you
invoke call_rcu(), the callback function is eventually going to be
diff --git a/Documentation/core-api/local_ops.rst b/Documentation/core-api/local_ops.rst
index a84f8b0c7ab2..0b42ceaaf3c4 100644
--- a/Documentation/core-api/local_ops.rst
+++ b/Documentation/core-api/local_ops.rst
@@ -191,7 +191,7 @@ Here is a sample module which implements a basic per cpu counter using
static void __exit test_exit(void)
{
- timer_delete_sync(&test_timer);
+ timer_shutdown_sync(&test_timer);
}
module_init(test_init);
diff --git a/Documentation/kernel-hacking/locking.rst b/Documentation/kernel-hacking/locking.rst
index c447d55fa080..3bbb11ba647a 100644
--- a/Documentation/kernel-hacking/locking.rst
+++ b/Documentation/kernel-hacking/locking.rst
@@ -1007,6 +1007,11 @@ calling add_timer() at the end of their timer function).
Because this is a fairly common case which is prone to races, you should
use timer_delete_sync() (``include/linux/timer.h``) to
+Before freeing a timer, timer_shutdown() or timer_shutdown_sync() should be
+called which will keep it from being rearmed. Any subsequent attempt to
+rearm the timer will be silently ignored by the core code.
+
+
Locking Speed
=============
diff --git a/Documentation/translations/zh_CN/core-api/local_ops.rst b/Documentation/translations/zh_CN/core-api/local_ops.rst
index 22493b9b829c..eb5423f60f17 100644
--- a/Documentation/translations/zh_CN/core-api/local_ops.rst
+++ b/Documentation/translations/zh_CN/core-api/local_ops.rst
@@ -185,7 +185,7 @@ UP之间没有不同的行为,在你的架构的 ``local.h`` 中包括 ``asm-g
static void __exit test_exit(void)
{
- timer_delete_sync(&test_timer);
+ timer_shutdown_sync(&test_timer);
}
module_init(test_init);
--
next prev parent reply other threads:[~2025-10-10 15:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-10 15:02 [PATCH 6.1.y 00/12] timers: Provide timer_shutdown[_sync]() Jeongjun Park
2025-10-10 15:02 ` [PATCH 6.1.y 01/12] Documentation: Remove bogus claim about del_timer_sync() Jeongjun Park
2025-10-10 15:02 ` [PATCH 6.1.y 02/12] ARM: spear: Do not use timer namespace for timer_shutdown() function Jeongjun Park
2025-10-10 15:02 ` [PATCH 6.1.y 03/12] clocksource/drivers/arm_arch_timer: " Jeongjun Park
2025-10-10 15:02 ` [PATCH 6.1.y 04/12] clocksource/drivers/sp804: " Jeongjun Park
2025-10-10 15:02 ` [PATCH 6.1.y 05/12] timers: Replace BUG_ON()s Jeongjun Park
2025-10-10 15:02 ` [PATCH 6.1.y 06/12] Documentation: Replace del_timer/del_timer_sync() Jeongjun Park
2025-10-10 15:02 ` [PATCH 6.1.y 07/12] timers: Silently ignore timers with a NULL function Jeongjun Park
2025-10-10 15:02 ` [PATCH 6.1.y 08/12] timers: Split [try_to_]del_timer[_sync]() to prepare for shutdown mode Jeongjun Park
2025-10-10 15:02 ` [PATCH 6.1.y 09/12] timers: Add shutdown mechanism to the internal functions Jeongjun Park
2025-10-10 15:02 ` [PATCH 6.1.y 10/12] timers: Provide timer_shutdown[_sync]() Jeongjun Park
2025-10-10 15:02 ` Jeongjun Park [this message]
2025-10-10 15:02 ` [PATCH 6.1.y 12/12] Bluetooth: hci_qca: Fix the teardown problem for real Jeongjun Park
2025-10-20 11:17 ` [PATCH 6.1.y 00/12] timers: Provide timer_shutdown[_sync]() Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251010150252.1115788-12-aha310510@gmail.com \
--to=aha310510@gmail.com \
--cc=Julia.Lawall@inria.fr \
--cc=akpm@linux-foundation.org \
--cc=anna-maria@linutronix.de \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jacob.e.keller@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=maz@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sboyd@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®