mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ojaswin Mujoo <ojaswin@linux.ibm.com>
To: Zorro Lang <zlang@redhat.com>, fstests@vger.kernel.org
Cc: srivathsa.d.dara@oracle.com, linux-kernel@vger.kernel.org,
	Disha Goel <disgoel@linux.ibm.com>
Subject: [PATCH] ext4/060: Skip for dax devices on non-4k page sizes
Date: Sat, 11 Oct 2025 19:17:08 +0530	[thread overview]
Message-ID: <20251011134708.2426769-1-ojaswin@linux.ibm.com> (raw)

This test tries to trigger an ext4 corruption by resizing past the
meta_bg size (8GB on 4k blocksize) in ext4. Since the test is sensistive
to the size and FS layout it hardcodes the 4kb blocksize ignoring user's
$MKFS_OPTIONS. While this is okay for most cases it fails for dax based
filesystems where system pagesize is non-4k.

One way to work past this is to make the test blocksize agnostic, but
since we still need the disk to be as big as the meta_bg size, this
means for blocksize=64kb filesystems we need a scratch disk of ~4TB
which is not feasible.

Hence, just skip the test if fsdax is used in a non-4k page size system.

Reported-by: Disha Goel <disgoel@linux.ibm.com>
Signed-off-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
---
 tests/ext4/060 | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/ext4/060 b/tests/ext4/060
index b8cc542f..565f8601 100755
--- a/tests/ext4/060
+++ b/tests/ext4/060
@@ -17,6 +17,10 @@ _begin_fstest auto resize quick
 _exclude_fs ext2
 _exclude_fs ext3
 
+if __scratch_uses_fsdax && [[ $(_get_page_size) -ne 4096 ]]; then
+    _notrun "Test does not support dax on non-4k pagesize systems"
+fi
+
 _fixed_by_kernel_commit a6b3bfe176e8 \
 	"ext4: fix corruption during on-line resize"
 
-- 
2.49.0


             reply	other threads:[~2025-10-11 13:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-11 13:47 Ojaswin Mujoo [this message]
2025-10-12 19:57 ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251011134708.2426769-1-ojaswin@linux.ibm.com \
    --to=ojaswin@linux.ibm.com \
    --cc=disgoel@linux.ibm.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=srivathsa.d.dara@oracle.com \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®