From: Chukun Pan <amadeus@jmu.edu.cn>
To: jjm2473@gmail.com
Cc: amadeus@jmu.edu.cn, conor+dt@kernel.org,
devicetree@vger.kernel.org, heiko@sntech.de, krzk+dt@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v5 3/3] arm64: dts: rockchip: add LinkEase EasePi R1
Date: Mon, 13 Oct 2025 21:00:10 +0800 [thread overview]
Message-ID: <20251013130010.143271-1-amadeus@jmu.edu.cn> (raw)
In-Reply-To: <CAP_9mL5=GmtJF3nSbfX6gRzPc=fAMrTOfMuOLyWFwq5D4OYUFw@mail.gmail.com>
Hi,
> +&pinctrl {
> + gmac0 {
> + eth_phy0_reset_pin: eth-phy0-reset-pin {
> + rockchip,pins = <2 RK_PD3 RK_FUNC_GPIO &pcfg_pull_up>;
> + };
> + };
Leave a blank line.
> + gmac1 {
> + eth_phy1_reset_pin: eth-phy1-reset-pin {
> + rockchip,pins = <2 RK_PD1 RK_FUNC_GPIO &pcfg_pull_up>;
> + };
> + };
> + gpio-leds {
> + status_led_pin: status-led-pin {
> + rockchip,pins =
No line break required here.
> + <2 RK_PD7 RK_FUNC_GPIO &pcfg_pull_none>;
> + };
> + };
> VBUS on usb2phy0_otg is floating, this USB port only works on
> device (peripheral) mode.
> phy-supply is optional, so this should be fine, right?
Yes, if there is no log like this:
supply phy not found, using dummy regulator
next prev parent reply other threads:[~2025-10-13 13:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-09 8:44 [PATCH v5 0/3] arm64: dts: rockchip: introduce " Liangbin Lian
2025-10-09 8:44 ` [PATCH v5 1/3] dt-bindings: vendor-prefixes: Document LinkEase Liangbin Lian
2025-10-09 8:44 ` [PATCH v5 2/3] dt-bindings: arm: rockchip: Add LinkEase EasePi R1 Liangbin Lian
2025-10-09 8:44 ` [PATCH v5 3/3] arm64: dts: rockchip: add " Liangbin Lian
2025-10-09 13:14 ` Andrew Lunn
2025-10-09 13:59 ` Russell King (Oracle)
2025-10-10 3:10 ` Liangbin Lian
2025-10-10 3:20 ` Liangbin Lian
2025-10-13 12:49 ` Russell King (Oracle)
2025-10-13 14:07 ` Liangbin Lian
2025-10-13 7:00 ` Chukun Pan
2025-10-13 8:51 ` Liangbin Lian
2025-10-13 13:00 ` Chukun Pan [this message]
2025-10-13 14:03 ` Liangbin Lian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251013130010.143271-1-amadeus@jmu.edu.cn \
--to=amadeus@jmu.edu.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jjm2473@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®