From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 855E33101C1 for ; Tue, 14 Oct 2025 08:42:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760431351; cv=none; b=HEoth0Iu8Dg45femyF8JX9vuh4EtTqiHT+BuJKhweeCP5uyybnkxRnUOYvQQoy/s+35FiVWpI2TncXUWT/ac00TBfVUPgfwSNcaMVIgRHMNNAczhJJ/IWByBm0nfy3PjL+E9XycSGaXd5l3NWL8Wcm1LINe/0HRYIdw62L4PLRE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760431351; c=relaxed/simple; bh=HVI9WkSGPWOkAXQUy/ASJnp79EZmelndScNQlQVMQvA=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=IJb5l0yPMbqo4ZzI9jXZDCj5ab43MxNtd9BwALpvv/uaQ9yRp041sz23vg/S8yGDaINmc9+6CUBTD3xvGNUOsH8bTk4w0hvN/SYv4iY4KSyWfa8e0ep9p3Sz097UzY/5uXkOKP+f1PXGR6BflE16kMc6qywbaKrTAN0PmCjOJZU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=lTjf84vZ; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lTjf84vZ" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-46e4ad36541so52776405e9.0 for ; Tue, 14 Oct 2025 01:42:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760431347; x=1761036147; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Bux6a4GJjBSEbuQlF9lC1lsY4+VsrC6xtyeGzyjuopE=; b=lTjf84vZm57WbTVo515RyXjApPCmIjwguWyQxtpodM+qICO+mDCmXKsraUV1ypddwR ryFXZ/q1UGSDJ6KvBemVlIXCqV9kQGK+KkQx+2o7qqoYBBYKOx7dHooN/B+trXUaqKN0 3R0Ddd0L7dGQxXwh41NgAhQuNVNv2xMqFwFWPIwwc8W4nt18UgeRuU1t+8JxdiNXKcjJ 8fsUwfbCVRRVSdz+J7GpqBDK2bpuSczm0dy5DkmKti0BOfu8Pw+27Ba1EpRAwHLMqhrG K+vMbAy5ltBBv1GZN7PgLdft++TFryuh+UbdZe5Yb0jxPeEWqHmdoiPUHnQgkJR/4N4N anyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760431347; x=1761036147; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Bux6a4GJjBSEbuQlF9lC1lsY4+VsrC6xtyeGzyjuopE=; b=JNyLpPPqjasNH3iG992c9mPD04B8sGiPuo4+HR005YNvcwgbfbGluywtK1pdD2LIdq QwcmjyjPk7DzZ5sIinX1Mp30yv4c/DKGsVm/fPSgeP6KSKFK9tYQ8hIBdNLtS0U2I0iG N4HAUkoqWuN3nUBmFOsilOOFry5EBim0vTxt85hkRwnyV310pnH2pvltJCTqxHOyajsV 7kLLFjBAQa1ARt1Gq33mCZy/Mzmz58Q1Y62xwCCAO1zqPNEOqZByCrvvBdO8eMorDM6M 3IOboLcfLIcnMmNMnjNTg2CyghpbsKWDgTW00YsuCtZBrdIC7yqfdnv6VPEG8LKEQhSO yVdg== X-Forwarded-Encrypted: i=1; AJvYcCV7B7VeOInIDv5w4fTcA11Y5uGxbRMQ//GEBV6DI+PUrpZkntn8iNf0Kn/v8GblAa3UuxD/RPVxZGVL13Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+LjWWh6fZ/0Qqyx9TYEOPulsN9Qc87UNLM2lonOwC2/87fKC/ ZPln4dOI5yhpkWf0AET4cgBN5RS8EeSUnnUtmYUMtWd/Ce4ZWDb4ycMzqKcd/9cuiFc= X-Gm-Gg: ASbGncurmUum2jUPV80T2JoB2Tsd50DqwoLIOFfKtTDrWSaNVDkDbnWCJ28ebEG1W1n slRwPoStdIM4Z4Hj7Dha2NARGqPBhRhC54SHbquhqiMkt2RpL1nD4tphd9nkiYiYbvRhgG9276P ti4LGTop/iE3cBwvURJowx7I6WjniQP+nojJVbnjj0aeg3CqQ/0yOLVwlIqOUuV06nvmInd3k5H tTSrv3PcR33d4kbVobK0bMkPj+baGAVoL4lI3q9BCI7eXS6P6bkwSqoiq1txKVrs0F/AT0Z+1mX TVQPbt+5uq2prG1yLs1Cf/07F0zp4YrZC4vWtTDbvL/hLg5mN+iwSKzPha7+5p0+XxCYpaRxFKV DqYKhs04GsHhA/P017CT4XIdzjre+0REoJZCSwbQJZbj9f0Q3jEOS5Ix8G3+mYXJi8uTQa+qs X-Google-Smtp-Source: AGHT+IEPeQ80dYAy/EoJvHRwS61zYc5L1iet9i9NnbknYK2xCI/PKnPoz8i4rHOQpXQTbmI6ft/ptQ== X-Received: by 2002:a05:600c:c083:b0:46f:b32e:5292 with SMTP id 5b1f17b1804b1-46fb32e5338mr94133085e9.8.1760431346590; Tue, 14 Oct 2025 01:42:26 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-46fb482b99fsm234828405e9.3.2025.10.14.01.42.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Oct 2025 01:42:26 -0700 (PDT) Date: Tue, 14 Oct 2025 11:42:22 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, hehuan1@eswincomputing.com, ulf.hansson@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, jszhang@kernel.org, adrian.hunter@intel.com, p.zabel@pengutronix.de, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, ningyu@eswincomputing.com, linmin@eswincomputing.com, pinkesh.vaghela@einfochips.com, xuxiang@eswincomputing.com, luyulin@eswincomputing.com, dongxuyang@eswincomputing.com, zhangsenchuan@eswincomputing.com, weishangjuan@eswincomputing.com, lizhi2@eswincomputing.com, caohang@eswincomputing.com, hehuan1@eswincomputing.com Subject: Re: [PATCH v4 2/2] mmc: sdhci-of-dwcmshc: Add support for Eswin EIC7700 Message-ID: <202510131636.lJ5QxMpK-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251011111216.570-1-hehuan1@eswincomputing.com> Hi, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/hehuan1-eswincomputing-com/dt-bindings-mmc-sdhci-of-dwcmshc-Add-Eswin-EIC7700/20251011-191312 base: linus/master patch link: https://lore.kernel.org/r/20251011111216.570-1-hehuan1%40eswincomputing.com patch subject: [PATCH v4 2/2] mmc: sdhci-of-dwcmshc: Add support for Eswin EIC7700 config: s390-randconfig-r073-20251013 (https://download.01.org/0day-ci/archive/20251013/202510131636.lJ5QxMpK-lkp@intel.com/config) compiler: s390-linux-gcc (GCC) 12.5.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202510131636.lJ5QxMpK-lkp@intel.com/ New smatch warnings: drivers/mmc/host/sdhci-of-dwcmshc.c:1547 eic7700_init() warn: missing error code? 'ret' vim +/ret +1547 drivers/mmc/host/sdhci-of-dwcmshc.c 3c5c200f02eee8 Huan He 2025-10-11 1516 static int eic7700_init(struct device *dev, struct sdhci_host *host, struct dwcmshc_priv *dwc_priv) 3c5c200f02eee8 Huan He 2025-10-11 1517 { 3c5c200f02eee8 Huan He 2025-10-11 1518 u32 emmc_caps = MMC_CAP2_NO_SD | MMC_CAP2_NO_SDIO; 3c5c200f02eee8 Huan He 2025-10-11 1519 unsigned int val, hsp_int_status, hsp_pwr_ctrl; 3c5c200f02eee8 Huan He 2025-10-11 1520 struct of_phandle_args args; 3c5c200f02eee8 Huan He 2025-10-11 1521 struct eic7700_priv *priv; 3c5c200f02eee8 Huan He 2025-10-11 1522 struct regmap *hsp_regmap; 3c5c200f02eee8 Huan He 2025-10-11 1523 int ret; 3c5c200f02eee8 Huan He 2025-10-11 1524 3c5c200f02eee8 Huan He 2025-10-11 1525 priv = devm_kzalloc(dev, sizeof(struct eic7700_priv), GFP_KERNEL); 3c5c200f02eee8 Huan He 2025-10-11 1526 if (!priv) 3c5c200f02eee8 Huan He 2025-10-11 1527 return -ENOMEM; 3c5c200f02eee8 Huan He 2025-10-11 1528 3c5c200f02eee8 Huan He 2025-10-11 1529 dwc_priv->priv = priv; 3c5c200f02eee8 Huan He 2025-10-11 1530 3c5c200f02eee8 Huan He 2025-10-11 1531 ret = sdhci_eic7700_reset_init(dev, dwc_priv->priv); 3c5c200f02eee8 Huan He 2025-10-11 1532 if (ret) { 3c5c200f02eee8 Huan He 2025-10-11 1533 dev_err(dev, "failed to reset\n"); 3c5c200f02eee8 Huan He 2025-10-11 1534 return ret; 3c5c200f02eee8 Huan He 2025-10-11 1535 } 3c5c200f02eee8 Huan He 2025-10-11 1536 3c5c200f02eee8 Huan He 2025-10-11 1537 ret = of_parse_phandle_with_fixed_args(dev->of_node, "eswin,hsp-sp-csr", 2, 0, &args); 3c5c200f02eee8 Huan He 2025-10-11 1538 if (ret) { 3c5c200f02eee8 Huan He 2025-10-11 1539 dev_err(dev, "Fail to parse 'eswin,hsp-sp-csr' phandle (%d)\n", ret); 3c5c200f02eee8 Huan He 2025-10-11 1540 return ret; 3c5c200f02eee8 Huan He 2025-10-11 1541 } 3c5c200f02eee8 Huan He 2025-10-11 1542 3c5c200f02eee8 Huan He 2025-10-11 1543 hsp_regmap = syscon_node_to_regmap(args.np); 3c5c200f02eee8 Huan He 2025-10-11 1544 if (IS_ERR(hsp_regmap)) { 3c5c200f02eee8 Huan He 2025-10-11 1545 dev_err(dev, "Failed to get regmap for 'eswin,hsp-sp-csr'\n"); 3c5c200f02eee8 Huan He 2025-10-11 1546 of_node_put(args.np); 3c5c200f02eee8 Huan He 2025-10-11 @1547 return ret; return PTR_ERR(hsp_regmap); 3c5c200f02eee8 Huan He 2025-10-11 1548 } 3c5c200f02eee8 Huan He 2025-10-11 1549 hsp_int_status = args.args[0]; 3c5c200f02eee8 Huan He 2025-10-11 1550 hsp_pwr_ctrl = args.args[1]; 3c5c200f02eee8 Huan He 2025-10-11 1551 of_node_put(args.np); 3c5c200f02eee8 Huan He 2025-10-11 1552 /* 3c5c200f02eee8 Huan He 2025-10-11 1553 * Assert clock stability: write EIC7700_INT_CLK_STABLE to hsp_int_status. 3c5c200f02eee8 Huan He 2025-10-11 1554 * This signals to the eMMC controller that platform clocks (card, ACLK, 3c5c200f02eee8 Huan He 2025-10-11 1555 * BCLK, TMCLK) are enabled and stable. 3c5c200f02eee8 Huan He 2025-10-11 1556 */ -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki