From: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
To: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>,
"Alexei Starovoitov" <ast@kernel.org>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"Arkadiusz Kubalewski" <arkadiusz.kubalewski@intel.com>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Daniel Zahka" <daniel.zahka@gmail.com>,
"Donald Hunter" <donald.hunter@gmail.com>,
"Jacob Keller" <jacob.e.keller@intel.com>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"Jiri Pirko" <jiri@resnulli.us>,
"Joe Damato" <jdamato@fastly.com>,
"John Fastabend" <john.fastabend@gmail.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Simon Horman" <horms@kernel.org>,
"Stanislav Fomichev" <sdf@fomichev.me>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
"Vadim Fedorenko" <vadim.fedorenko@linux.dev>,
"Willem de Bruijn" <willemb@google.com>,
bpf@vger.kernel.org, netdev@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net-next 2/6] tools: ynl-gen: refactor render-max enum generation
Date: Mon, 13 Oct 2025 16:49:59 +0000 [thread overview]
Message-ID: <20251013165005.83659-3-ast@fiberby.net> (raw)
In-Reply-To: <20251013165005.83659-1-ast@fiberby.net>
This patch refactors the generation of the three render-max
private enum members: (__$pfx-MAX and $pfx-MAX) or $pfx-MASK.
The names, default or not, are now resolved in the EnumSet class.
This makes enum.enum_max_name re-usable for NLA_POLICY_MASK() in
the next patch in this series, so we don't have to re-define it.
This doesn't change the generated output.
Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
---
tools/net/ynl/pyynl/ynl_gen_c.py | 20 +++++++++-----------
1 file changed, 9 insertions(+), 11 deletions(-)
diff --git a/tools/net/ynl/pyynl/ynl_gen_c.py b/tools/net/ynl/pyynl/ynl_gen_c.py
index e6df0e2b63a8c..2666cc54d09c0 100755
--- a/tools/net/ynl/pyynl/ynl_gen_c.py
+++ b/tools/net/ynl/pyynl/ynl_gen_c.py
@@ -1060,7 +1060,9 @@ class EnumSet(SpecEnumSet):
self.value_pfx = yaml.get('name-prefix', f"{family.ident_name}-{yaml['name']}-")
self.header = yaml.get('header', None)
- self.enum_cnt_name = yaml.get('enum-cnt-name', None)
+ self.enum_cnt_name = yaml.get('enum-cnt-name', f'--{self.value_pfx}max')
+ suffix = yaml['type'] == 'flags' and 'mask' or 'max'
+ self.enum_max_name = f'{self.value_pfx}{suffix}'
super().__init__(family, yaml)
@@ -3205,7 +3207,6 @@ def render_uapi(family, cw):
cw.p(' */')
uapi_enum_start(family, cw, const, 'name')
- name_pfx = const.get('name-prefix', f"{family.ident_name}-{const['name']}-")
for entry in enum.entries.values():
suffix = ','
if entry.value_change:
@@ -3215,17 +3216,14 @@ def render_uapi(family, cw):
if const.get('render-max', False):
cw.nl()
cw.p('/* private: */')
+ max_name = c_upper(enum.enum_max_name)
if const['type'] == 'flags':
- max_name = c_upper(name_pfx + 'mask')
- max_val = f' = {enum.get_mask()},'
- cw.p(max_name + max_val)
+ max_val = f'{enum.get_mask()},'
else:
- cnt_name = enum.enum_cnt_name
- max_name = c_upper(name_pfx + 'max')
- if not cnt_name:
- cnt_name = '__' + name_pfx + 'max'
- cw.p(c_upper(cnt_name) + ',')
- cw.p(max_name + ' = (' + c_upper(cnt_name) + ' - 1)')
+ cnt_name = c_upper(enum.enum_cnt_name)
+ cw.p(f'{cnt_name},')
+ max_val = f'({cnt_name} - 1)'
+ cw.p(f'{max_name} = {max_val}')
cw.block_end(line=';')
cw.nl()
elif const['type'] == 'const':
--
2.51.0
next prev parent reply other threads:[~2025-10-13 16:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 16:49 [PATCH net-next 0/6] tools: ynl-gen: generate flags better Asbjørn Sloth Tønnesen
2025-10-13 16:49 ` [PATCH net-next 1/6] tools: ynl-gen: bitshift the flag values in the generated code Asbjørn Sloth Tønnesen
2025-10-13 23:07 ` Jacob Keller
2025-10-14 16:27 ` Asbjørn Sloth Tønnesen
2025-10-14 0:53 ` Jakub Kicinski
2025-10-14 16:49 ` Asbjørn Sloth Tønnesen
2025-10-14 19:24 ` Jakub Kicinski
2025-10-13 16:49 ` Asbjørn Sloth Tønnesen [this message]
2025-10-14 0:58 ` [PATCH net-next 2/6] tools: ynl-gen: refactor render-max enum generation Jakub Kicinski
2025-10-14 17:04 ` Asbjørn Sloth Tønnesen
2025-10-14 19:26 ` Jakub Kicinski
2025-10-13 16:50 ` [PATCH net-next 3/6] tools: ynl-gen: use uapi mask definition in NLA_POLICY_MASK Asbjørn Sloth Tønnesen
2025-10-14 0:59 ` Jakub Kicinski
2025-10-14 17:29 ` Asbjørn Sloth Tønnesen
2025-10-14 19:32 ` Jakub Kicinski
2025-10-13 16:50 ` [PATCH net-next 4/6] tools: ynl-gen: add generic p_wrap() helper Asbjørn Sloth Tønnesen
2025-10-13 16:50 ` [PATCH net-next 5/6] tools: ynl-gen: construct bitflag masks in generated headers Asbjørn Sloth Tønnesen
2025-10-13 16:50 ` [PATCH net-next 6/6] tools: ynl-gen: allow custom naming of render-max definitions Asbjørn Sloth Tønnesen
2025-10-13 23:10 ` [PATCH net-next 0/6] tools: ynl-gen: generate flags better Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251013165005.83659-3-ast@fiberby.net \
--to=ast@fiberby.net \
--cc=andrew+netdev@lunn.ch \
--cc=arkadiusz.kubalewski@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=daniel.zahka@gmail.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=jdamato@fastly.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=toke@redhat.com \
--cc=vadim.fedorenko@linux.dev \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®