Re: [PATCH 2/8] firmware: imx: scu-irq: Free mailbox client on failure

[Peng Fan <peng.fan@oss.nxp.com>]

On Tue, Oct 14, 2025 at 11:54:36AM -0400, Frank Li wrote:
>On Tue, Oct 14, 2025 at 12:54:39PM +0800, Peng Fan wrote:
>> With mailbox channel freed, it is pointless to keep mailbox client.
>> So free the mailbox client in err path.
>>
>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>> ---
>>  drivers/firmware/imx/imx-scu-irq.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/firmware/imx/imx-scu-irq.c b/drivers/firmware/imx/imx-scu-irq.c
>> index f2b902e95b738fae90af9cbe54da4f488219906f..1fbe4c3de5c1592bfcf2334a83776c25d5ca7a3f 100644
>> --- a/drivers/firmware/imx/imx-scu-irq.c
>> +++ b/drivers/firmware/imx/imx-scu-irq.c
>> @@ -255,6 +255,7 @@ int imx_scu_enable_general_irq_channel(struct device *dev)
>>
>>  free_ch:
>>  	mbox_free_channel(ch);
>> +	devm_kfree(dev, cl);
>
>
>you use devm_kmalloc(), when return failure, framework will auto free cl.
>
>Avoid mixing manual free and management free code.
>
>So I think this patch is not neccesary.

Actually in imx-scu.c, there is only a warning message if this API call returns
error. So need to free here.

Thanks
Peng

>
>Frank
>>
>>  	return ret;
>>  }
>>
>> --
>> 2.37.1
>>