mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Benson Leung <bleung@chromium.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Danilo Krummrich <dakr@kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>, Shuah Khan <shuah@kernel.org>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	chrome-platform@lists.linux.dev, linux-kselftest@vger.kernel.org,
	tzungbi@kernel.org,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Simona Vetter <simona.vetter@ffwll.ch>,
	Dan Williams <dan.j.williams@intel.com>,
	Jason Gunthorpe <jgg@nvidia.com>
Subject: [PATCH v5 6/7] char: misc: Leverage revocable fops replacement
Date: Thu, 16 Oct 2025 05:42:03 +0000	[thread overview]
Message-ID: <20251016054204.1523139-7-tzungbi@kernel.org> (raw)
In-Reply-To: <20251016054204.1523139-1-tzungbi@kernel.org>

Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
---
PoC patch.

v5:
- No primary changes but modify the API usage accordingly to support
  multiple revocable providers.

v4: https://lore.kernel.org/chrome-platform/20250923075302.591026-7-tzungbi@kernel.org
- New in the series.

 drivers/char/misc.c        | 8 ++++++++
 include/linux/miscdevice.h | 4 ++++
 2 files changed, 12 insertions(+)

diff --git a/drivers/char/misc.c b/drivers/char/misc.c
index 726516fb0a3b..5b412e18b8a6 100644
--- a/drivers/char/misc.c
+++ b/drivers/char/misc.c
@@ -50,6 +50,7 @@
 #include <linux/tty.h>
 #include <linux/kmod.h>
 #include <linux/gfp.h>
+#include <linux/fs_revocable.h>
 
 /*
  * Head entry for the doubly linked miscdevice list
@@ -159,6 +160,13 @@ static int misc_open(struct inode *inode, struct file *file)
 
 	err = 0;
 	replace_fops(file, new_fops);
+
+	if (c->frops && c->rps)  {
+		err = fs_revocable_replace(file, c->frops, c->rps, c->num_rps);
+		if (err)
+			goto fail;
+	}
+
 	if (file->f_op->open)
 		err = file->f_op->open(inode, file);
 fail:
diff --git a/include/linux/miscdevice.h b/include/linux/miscdevice.h
index 7d0aa718499c..b7024a0cebb9 100644
--- a/include/linux/miscdevice.h
+++ b/include/linux/miscdevice.h
@@ -5,6 +5,7 @@
 #include <linux/list.h>
 #include <linux/types.h>
 #include <linux/device.h>
+#include <linux/revocable.h>
 
 /*
  *	These allocations are managed by device@lanana.org. If you need
@@ -92,6 +93,9 @@ struct miscdevice {
 	const struct attribute_group **groups;
 	const char *nodename;
 	umode_t mode;
+	struct revocable_provider **rps;
+	size_t num_rps;
+	const struct fs_revocable_operations *frops;
 };
 
 extern int misc_register(struct miscdevice *misc);
-- 
2.51.0.788.g6d19910ace-goog


  parent reply	other threads:[~2025-10-16  5:43 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-16  5:41 [PATCH v5 0/7] platform/chrome: Fix a possible UAF via revocable Tzung-Bi Shih
2025-10-16  5:41 ` [PATCH v5 1/7] revocable: Revocable resource management Tzung-Bi Shih
2025-10-16  5:41 ` [PATCH v5 2/7] revocable: Add Kunit test cases Tzung-Bi Shih
2025-10-16  5:42 ` [PATCH v5 3/7] selftests: revocable: Add kselftest cases Tzung-Bi Shih
2025-10-16  5:42 ` [PATCH v5 4/7] platform/chrome: Protect cros_ec_device lifecycle with revocable Tzung-Bi Shih
2025-10-16  5:42 ` [PATCH v5 5/7] revocable: Add fops replacement Tzung-Bi Shih
2025-10-16 12:31   ` Jason Gunthorpe
2025-10-17  2:36     ` Tzung-Bi Shih
2025-10-17 13:49       ` Jason Gunthorpe
2025-10-17 16:07         ` Tzung-Bi Shih
2025-10-17 16:21           ` Jason Gunthorpe
2025-10-19 15:08             ` Tzung-Bi Shih
2025-10-20 11:57               ` Jason Gunthorpe
2025-10-21  4:49                 ` Tzung-Bi Shih
2025-10-21 12:15                   ` Jason Gunthorpe
2025-10-23 14:22                     ` Tzung-Bi Shih
2025-10-23 14:51                       ` Jason Gunthorpe
2025-10-23 15:04                         ` Greg Kroah-Hartman
2025-10-23 15:57                           ` Jason Gunthorpe
2025-10-23 16:20                             ` Danilo Krummrich
2025-10-23 16:48                               ` Jason Gunthorpe
2025-10-23 18:30                                 ` Danilo Krummrich
2025-12-11  3:23                           ` Laurent Pinchart
2025-12-11  3:47                             ` Wolfram Sang
2025-12-11  8:05                               ` Laurent Pinchart
2025-12-11  8:36                                 ` Wolfram Sang
2025-12-11 13:43                                   ` Laurent Pinchart
2025-12-11 14:46                                     ` Tzung-Bi Shih
2025-12-12  8:32                                       ` Tzung-Bi Shih
2025-11-07  4:11                     ` Tzung-Bi Shih
2025-11-07 14:12                       ` Jason Gunthorpe
2025-10-17 16:29           ` Danilo Krummrich
2025-10-17 16:37             ` Jason Gunthorpe
2025-10-17 18:19               ` Danilo Krummrich
2025-10-17 18:44                 ` Jason Gunthorpe
2025-10-17 21:41                   ` Danilo Krummrich
2025-10-17 22:56                     ` Jason Gunthorpe
2025-10-23 15:32                       ` Danilo Krummrich
2025-10-16 18:38   ` Randy Dunlap
2025-10-17  2:41     ` Tzung-Bi Shih
2025-10-16  5:42 ` Tzung-Bi Shih [this message]
2025-10-16  5:42 ` [PATCH v5 7/7] platform/chrome: cros_ec_chardev: Secure cros_ec_device via revocable Tzung-Bi Shih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251016054204.1523139-7-tzungbi@kernel.org \
    --to=tzungbi@kernel.org \
    --cc=bleung@chromium.org \
    --cc=brgl@bgdev.pl \
    --cc=chrome-platform@lists.linux.dev \
    --cc=corbet@lwn.net \
    --cc=dakr@kernel.org \
    --cc=dan.j.williams@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jgg@nvidia.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=shuah@kernel.org \
    --cc=simona.vetter@ffwll.ch \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome