mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>, Tony Luck <tony.luck@intel.com>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-edac@vger.kernel.org, Avadhut Naik <avadhut.naik@amd.com>,
	John Allen <john.allen@amd.com>,
	Mario Limonciello <mario.limonciello@amd.com>
Subject: Re: [PATCH 2/3] RAS/AMD/ATL: Require PRM support for future systems
Date: Thu, 16 Oct 2025 13:54:09 -0400	[thread overview]
Message-ID: <20251016175409.GA806407@yaz-khff2.amd.com> (raw)
In-Reply-To: <20251016161037.GEaPEY_V0fbmPvspMa@fat_crate.local>

On Thu, Oct 16, 2025 at 06:10:37PM +0200, Borislav Petkov wrote:
> On Mon, Oct 06, 2025 at 03:10:26PM +0000, Yazen Ghannam wrote:
> > Currently, the AMD Address Translation Library will fail to load for
> > new, unrecognized systems (based on Data Fabric revision). The intention
> > is to prevent the code from executing on new systems and returning
> > incorrect results.
> > 
> > Recent AMD systems may provide UEFI PRM handlers for address
> > translation. This is code provided by the platform through BIOS tables.
> > These are the preferred method for translation, and the Linux native
> > code can be used as a fallback.
> > 
> > Future AMD systems are expected to provide PRM handlers by default. And
> > Linux native code will not be used.
> > 
> > Adjust the ATL init code so that new, unrecognized systems will default
> > to using PRM handlers only.
> > 
> > Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
> > ---
> >  drivers/ras/amd/atl/internal.h | 10 +++++++++-
> >  drivers/ras/amd/atl/prm.c      | 10 ++++++++++
> >  drivers/ras/amd/atl/system.c   | 12 ++++++------
> >  drivers/ras/amd/atl/umc.c      |  2 +-
> >  4 files changed, 26 insertions(+), 8 deletions(-)
> 
> Try to simplify this this way:
> 
> Drop prm_check() and set prm_only *after* acpi_prm_handler_available() returns
> true. Then use ->prm_only everywhere instead.
> 
> -- 

Okay, I'll work on that and send another revision.

Thanks,
Yazen

  reply	other threads:[~2025-10-16 17:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-06 15:10 [PATCH 0/3] AMD ATL PRM Updates Yazen Ghannam
2025-10-06 15:10 ` [PATCH 1/3] ACPI: PRM: Add acpi_prm_handler_available() Yazen Ghannam
2025-10-16 16:01   ` Borislav Petkov
2025-10-16 16:09     ` Rafael J. Wysocki
2025-10-16 16:17       ` Borislav Petkov
2025-10-16 16:29         ` Rafael J. Wysocki
2025-10-06 15:10 ` [PATCH 2/3] RAS/AMD/ATL: Require PRM support for future systems Yazen Ghannam
2025-10-16 16:10   ` Borislav Petkov
2025-10-16 17:54     ` Yazen Ghannam [this message]
2025-10-06 15:10 ` [PATCH 3/3] RAS/AMD/ATL: Return error codes from helper functions Yazen Ghannam
2025-10-17 12:43   ` Borislav Petkov
2025-10-06 15:25 ` [PATCH 0/3] AMD ATL PRM Updates Mario Limonciello (AMD) (kernel.org)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251016175409.GA806407@yaz-khff2.amd.com \
    --to=yazen.ghannam@amd.com \
    --cc=avadhut.naik@amd.com \
    --cc=bp@alien8.de \
    --cc=john.allen@amd.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=rafael@kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®