From: Adam Young <admiyo@os.amperecomputing.com>
To: Sudeep Holla <sudeep.holla@arm.com>,
Jassi Brar <jassisinghbrar@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Jeremy Kerr <jk@codeconstruct.com.au>,
Matt Johnston <matt@codeconstruct.com.au>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Huisong Li <lihuisong@huawei.com>
Subject: [PATCH v30 1/3] mailbox: pcc: Type3 Buffer handles ACK IRQ
Date: Thu, 16 Oct 2025 17:02:19 -0400 [thread overview]
Message-ID: <20251016210225.612639-2-admiyo@os.amperecomputing.com> (raw)
In-Reply-To: <20251016210225.612639-1-admiyo@os.amperecomputing.com>
The PCC protocol type 3 requests include a field that indicates that the
recipient should trigger an interrupt once the message has been read
from the buffer. The sender uses this interrupt to know that a
transmission is complete, and it is safe to send additional messages.
Signed-off-by: Adam Young <admiyo@os.amperecomputing.com>
mailbox/pcc extended memory helper functions
---
drivers/mailbox/pcc.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c
index f6714c233f5a..978a7b674946 100644
--- a/drivers/mailbox/pcc.c
+++ b/drivers/mailbox/pcc.c
@@ -306,6 +306,18 @@ static void pcc_chan_acknowledge(struct pcc_chan_info *pchan)
pcc_chan_reg_read_modify_write(&pchan->db);
}
+static bool pcc_last_tx_done(struct mbox_chan *chan)
+{
+ struct pcc_chan_info *pchan = chan->con_priv;
+ u64 val;
+
+ pcc_chan_reg_read(&pchan->cmd_complete, &val);
+ if (!val)
+ return false;
+ else
+ return true;
+}
+
/**
* pcc_mbox_irq - PCC mailbox interrupt handler
* @irq: interrupt number
@@ -340,6 +352,14 @@ static irqreturn_t pcc_mbox_irq(int irq, void *p)
* required to avoid any possible race in updatation of this flag.
*/
pchan->chan_in_use = false;
+
+ /**
+ * The remote side sent an ack.
+ */
+ if (pchan->type == ACPI_PCCT_TYPE_EXT_PCC_MASTER_SUBSPACE &&
+ chan->active_req)
+ mbox_chan_txdone(chan, 0);
+
mbox_chan_received_data(chan, NULL);
pcc_chan_acknowledge(pchan);
@@ -490,6 +510,7 @@ static const struct mbox_chan_ops pcc_chan_ops = {
.send_data = pcc_send_data,
.startup = pcc_startup,
.shutdown = pcc_shutdown,
+ .last_tx_done = pcc_last_tx_done,
};
/**
--
2.43.0
next prev parent reply other threads:[~2025-10-16 21:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 21:02 [PATCH v30 0/3] MCTP Over PCC Transport Adam Young
2025-10-16 21:02 ` Adam Young [this message]
2025-10-17 16:08 ` [PATCH v30 1/3] mailbox: pcc: Type3 Buffer handles ACK IRQ Adam Young
2025-10-17 17:42 ` Sudeep Holla
2025-10-17 18:04 ` Adam Young
2025-10-16 21:02 ` [PATCH v30 2/3] mailbox: pcc: functions for reading and writing PCC extended data Adam Young
2025-10-17 10:12 ` [External] : " ALOK TIWARI
2025-10-20 12:52 ` Sudeep Holla
2025-10-20 17:22 ` Adam Young
2025-10-21 14:02 ` Sudeep Holla
2025-10-21 17:20 ` Adam Young
2025-10-24 13:50 ` Sudeep Holla
2025-12-18 19:31 ` Adam Young
2025-10-16 21:02 ` [PATCH v30 3/3] mctp pcc: Implement MCTP over PCC Transport Adam Young
2025-10-17 3:01 ` Jeremy Kerr
2025-10-21 0:54 ` Adam Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251016210225.612639-2-admiyo@os.amperecomputing.com \
--to=admiyo@os.amperecomputing.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jassisinghbrar@gmail.com \
--cc=jk@codeconstruct.com.au \
--cc=kuba@kernel.org \
--cc=lihuisong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®