From: Rohan G Thomas via B4 Relay <devnull+rohan.g.thomas.altera.com@kernel.org>
To: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <Jose.Abreu@synopsys.com>,
Rohan G Thomas <rohan.g.thomas@intel.com>,
Boon Khai Ng <boon.khai.ng@altera.com>
Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Rohan G Thomas <rohan.g.thomas@altera.com>,
Matthew Gerlach <matthew.gerlach@altera.com>
Subject: [PATCH net v3 0/3] net: stmmac: Fixes for stmmac Tx VLAN insert and EST
Date: Fri, 17 Oct 2025 14:11:18 +0800 [thread overview]
Message-ID: <20251017-qbv-fixes-v3-0-d3a42e32646a@altera.com> (raw)
This patchset includes following fixes for stmmac Tx VLAN insert and
EST implementations:
1. Disable STAG insertion offloading, as DWMAC IPs doesn't support
offload of STAG for double VLAN packets and CTAG for single VLAN
packets when using the same register configuration. The current
configuration in the driver is undocumented and is adding an
additional 802.1Q tag with VLAN ID 0 for double VLAN packets.
2. Consider Tx VLAN offload tag length for maxSDU estimation.
3. Fix GCL bounds check
Signed-off-by: Rohan G Thomas <rohan.g.thomas@altera.com>
---
Changes in v3:
- Commit for disabling 802.1AD tag insertion offload is introduced in
to this patchset
- Add just VLAN_HLEN to sdu_len when 802.1Q tag offload is requested
- Link to v2: https://lore.kernel.org/r/20250915-qbv-fixes-v2-0-ec90673bb7d4@altera.com
Changes in v2:
- Use GENMASK instead of BIT for clarity and consistency
- Link to v1: https://lore.kernel.org/r/20250911-qbv-fixes-v1-0-e81e9597cf1f@altera.com
---
Rohan G Thomas (3):
net: stmmac: vlan: Disable 802.1AD tag insertion offload
net: stmmac: Consider Tx VLAN offload tag length for maxSDU
net: stmmac: est: Fix GCL bounds checks
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 37 ++++++++++-------------
drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c | 4 +--
drivers/net/ethernet/stmicro/stmmac/stmmac_vlan.c | 2 +-
3 files changed, 19 insertions(+), 24 deletions(-)
---
base-commit: cb85ca4c0a349e246cd35161088aa3689ae5c580
change-id: 20250911-qbv-fixes-4ae64de86ee7
Best regards,
--
Rohan G Thomas <rohan.g.thomas@altera.com>
next reply other threads:[~2025-10-17 6:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 6:11 Rohan G Thomas via B4 Relay [this message]
2025-10-17 6:11 ` [PATCH net v3 1/3] net: stmmac: vlan: Disable 802.1AD tag insertion offload Rohan G Thomas via B4 Relay
2025-10-17 12:42 ` Russell King (Oracle)
2025-10-18 1:56 ` G Thomas, Rohan
2025-10-23 3:31 ` G Thomas, Rohan
2025-10-23 10:54 ` Russell King (Oracle)
2025-10-24 3:03 ` G Thomas, Rohan
2025-10-17 6:11 ` [PATCH net v3 2/3] net: stmmac: Consider Tx VLAN offload tag length for maxSDU Rohan G Thomas via B4 Relay
2025-10-17 7:36 ` G Thomas, Rohan
2025-10-17 12:21 ` Vadim Fedorenko
2025-10-18 1:50 ` G Thomas, Rohan
2025-10-23 10:59 ` Russell King (Oracle)
2025-10-23 16:03 ` G Thomas, Rohan
2025-10-17 12:44 ` Russell King (Oracle)
2025-10-18 2:06 ` G Thomas, Rohan
2025-10-23 10:58 ` Russell King (Oracle)
2025-10-17 17:16 ` kernel test robot
2025-10-27 9:03 ` G Thomas, Rohan
2025-10-17 6:11 ` [PATCH net v3 3/3] net: stmmac: est: Fix GCL bounds checks Rohan G Thomas via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251017-qbv-fixes-v3-0-d3a42e32646a@altera.com \
--to=devnull+rohan.g.thomas.altera.com@kernel.org \
--cc=Jose.Abreu@synopsys.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=boon.khai.ng@altera.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=matthew.gerlach@altera.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rohan.g.thomas@altera.com \
--cc=rohan.g.thomas@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®