mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: neqbal <nooraineqbal@gmail.com>
To: syzbot+2617fc732430968b45d2@syzkaller.appspotmail.com
Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com,
	neqbal <nooraineqbal@gmail.com>
Subject: [PATCH] bpf: sync pending IRQ work before freeing ring buffer
Date: Sat, 18 Oct 2025 02:25:46 +0530	[thread overview]
Message-ID: <20251017205546.262475-1-nooraineqbal@gmail.com> (raw)
In-Reply-To: <68e7d0d8.050a0220.91a22.0008.GAE@google.com>

#syz test

Fix a possible vmalloc out-of-bounds access caused by pending IRQ work

Reported-by: syzbot+2617fc732430968b45d2@syzkaller.appspotmail.com
Signed-off-by: neqbal <nooraineqbal@gmail.com>
---
 kernel/bpf/ringbuf.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/kernel/bpf/ringbuf.c b/kernel/bpf/ringbuf.c
index 719d73299397..a6597417412f 100644
--- a/kernel/bpf/ringbuf.c
+++ b/kernel/bpf/ringbuf.c
@@ -216,6 +216,12 @@ static struct bpf_map *ringbuf_map_alloc(union bpf_attr *attr)
 
 static void bpf_ringbuf_free(struct bpf_ringbuf *rb)
 {
+	/* Ensure all pending IRQ work completes before freeing.
+	 * In PREEMPT_RT, IRQ work runs in thread context and can
+	 * race with ring buffer destruction.
+	 */
+	irq_work_sync(&rb->work);
+
 	/* copy pages pointer and nr_pages to local variable, as we are going
 	 * to unmap rb itself with vunmap() below
 	 */
-- 
2.51.0


  reply	other threads:[~2025-10-17 20:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-31  0:33 [syzbot] [kernel?] KASAN: vmalloc-out-of-bounds Read in run_irq_workd syzbot
2025-10-09 15:12 ` syzbot
2025-10-17 20:55   ` neqbal [this message]
2025-10-17 21:22     ` syzbot
2025-10-18 18:11 [PATCH] bpf: sync pending IRQ work before freeing ring buffer neqbal
2025-10-19  1:13 ` Alexei Starovoitov
2025-10-19 22:30   ` Noorain Eqbal
2025-10-20 16:17     ` Andrii Nakryiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251017205546.262475-1-nooraineqbal@gmail.com \
    --to=nooraineqbal@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzbot+2617fc732430968b45d2@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®