mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gregory Price <gourry@gourry.net>
To: x86@kernel.org
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
	mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
	hpa@zytor.com, peterz@infradead.org, mario.limonciello@amd.com,
	riel@surriel.com, yazen.ghannam@amd.com, me@mixaill.net,
	kai.huang@intel.com, sandipan.das@amd.com, darwi@linutronix.de,
	stable@vger.kernel.org
Subject: [PATCH v2] x86/amd: Disable RDSEED on AMD Zen5 because of an error.
Date: Fri, 17 Oct 2025 22:40:10 -0400	[thread overview]
Message-ID: <20251018024010.4112396-1-gourry@gourry.net> (raw)

Under unknown conditions, Zen5 chips running rdseed can produce
(val=0,CF=1) over 10% of the time (when rdseed is successful).
CF=1 indicates success, while val=0 is typically only produced
when rdseed fails (CF=0).

This suggests there is a bug which causes rdseed to silently fail.

This was reproduced reliably by launching 2-threads per available
core, 1-thread per for hamming on RDSEED, and 1-thread per core
collectively eating and hammering on ~90% of memory.

This was observed on more than 1 Zen5 model, so it should be disabled
for all of Zen5 until/unless a comprehensive blacklist can be built.

Cc: stable@vger.kernel.org
Signed-off-by: Gregory Price <gourry@gourry.net>
---
 arch/x86/kernel/cpu/amd.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
index 5398db4dedb4..1af30518d3e7 100644
--- a/arch/x86/kernel/cpu/amd.c
+++ b/arch/x86/kernel/cpu/amd.c
@@ -1037,6 +1037,10 @@ static void init_amd_zen4(struct cpuinfo_x86 *c)
 
 static void init_amd_zen5(struct cpuinfo_x86 *c)
 {
+	/* Disable RDSEED on AMD Turin because of an error. */
+	clear_cpu_cap(c, X86_FEATURE_RDSEED);
+	msr_clear_bit(MSR_AMD64_CPUID_FN_7, 18);
+	pr_emerg("RDSEED is not reliable on this platform; disabling.\n");
 }
 
 static void init_amd(struct cpuinfo_x86 *c)
-- 
2.51.0


             reply	other threads:[~2025-10-18  2:40 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-18  2:40 Gregory Price [this message]
2025-10-18 10:03 ` Borislav Petkov
2025-10-19 14:46   ` Jason A. Donenfeld
2025-10-19 15:00     ` Borislav Petkov
2025-10-19 15:03       ` Jason A. Donenfeld
2025-11-03 10:22         ` Christopher Snowhill
2025-11-03 12:03           ` Borislav Petkov
2025-11-03 23:55             ` Christopher Snowhill
2025-11-04 13:21               ` Borislav Petkov
2025-11-04 14:28                 ` Jason A. Donenfeld
2025-11-04 15:00                   ` Jason A. Donenfeld
2025-11-04 18:08                   ` Thiago Macieira
2025-11-04 21:56                     ` Jason A. Donenfeld
2025-11-04 23:50                       ` Thiago Macieira
2025-11-05  1:58                         ` Jason A. Donenfeld
2025-11-05 16:41                           ` Thiago Macieira
2025-11-07 19:13                             ` Jason A. Donenfeld
2025-11-07 19:55                               ` Thiago Macieira
2025-11-07 23:07                                 ` Jason A. Donenfeld
2025-11-07 23:11                                   ` Thiago Macieira
2025-11-08  0:04                                     ` Jason A. Donenfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251018024010.4112396-1-gourry@gourry.net \
    --to=gourry@gourry.net \
    --cc=bp@alien8.de \
    --cc=darwi@linutronix.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=kai.huang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=me@mixaill.net \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=riel@surriel.com \
    --cc=sandipan.das@amd.com \
    --cc=stable@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=yazen.ghannam@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®