From: Changwoo Min <changwoo@igalia.com>
To: lukasz.luba@arm.com, rafael@kernel.org, len.brown@intel.com,
pavel@kernel.org
Cc: christian.loehle@arm.com, tj@kernel.org, kernel-dev@igalia.com,
linux-pm@vger.kernel.org, sched-ext@lists.linux.dev,
linux-kernel@vger.kernel.org, Changwoo Min <changwoo@igalia.com>,
kernel test robot <lkp@intel.com>
Subject: [PATCH 2/2] PM: EM: Include the iterator/accessor code for the performance domain conditionally
Date: Mon, 20 Oct 2025 17:44:29 +0900 [thread overview]
Message-ID: <20251020084429.230322-2-changwoo@igalia.com> (raw)
In-Reply-To: <20251020084429.230322-1-changwoo@igalia.com>
When CONFIG_ENERGY_MODEL is set but CONFIG_NET is not set, the following
errors are raised:
>> kernel/power/energy_model.c:1003:5: error: redefinition of
'for_each_em_perf_domain'
>> kernel/power/energy_model.c:1022:24: error: redefinition of
'em_perf_domain_get_by_id'
That is because these two functions are defined in em_netlink.h (empty
function body) and energy_model.c (actual implementation).
To avoid the compilation errors, conditionally include the actual function
implementations in energy_model.c when both CONFIG_ENERGY_MODEL and
CONFIG_NET are set.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202510151232.UNZ2J7TZ-lkp@intel.com/
Signed-off-by: Changwoo Min <changwoo@igalia.com>
---
kernel/power/energy_model.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/power/energy_model.c b/kernel/power/energy_model.c
index 92c12b5983ed..e669d5057fca 100644
--- a/kernel/power/energy_model.c
+++ b/kernel/power/energy_model.c
@@ -1006,6 +1006,7 @@ void em_rebuild_sched_domains(void)
schedule_work(&rebuild_sd_work);
}
+#if defined(CONFIG_ENERGY_MODEL) && defined(CONFIG_NET)
int for_each_em_perf_domain(int (*cb)(struct em_perf_domain*, void *),
void *data)
{
@@ -1039,3 +1040,4 @@ struct em_perf_domain *em_perf_domain_get_by_id(int id)
return NULL;
}
+#endif
--
2.51.1.dirty
next prev parent reply other threads:[~2025-10-20 8:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 8:44 [PATCH 1/2] PM: EM: Remove an unused variable in em_notify_pd_deleted() Changwoo Min
2025-10-20 8:44 ` Changwoo Min [this message]
2025-10-20 12:17 ` Rafael J. Wysocki
2025-10-20 21:27 ` Changwoo Min
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251020084429.230322-2-changwoo@igalia.com \
--to=changwoo@igalia.com \
--cc=christian.loehle@arm.com \
--cc=kernel-dev@igalia.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lukasz.luba@arm.com \
--cc=pavel@kernel.org \
--cc=rafael@kernel.org \
--cc=sched-ext@lists.linux.dev \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®