From: Andrew Morton <akpm@linux-foundation.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: linux-kernel@vger.kernel.org, "Andrew Chant" <achant@google.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Brian Gerst" <brgerst@gmail.com>,
"Christian Brauner" <brauner@kernel.org>,
"Francesco Valla" <francesco@valla.it>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Guo Weikang" <guoweikang.kernel@gmail.com>,
"Huacai Chen" <chenhuacai@kernel.org>,
"Jan Hendrik Farr" <kernel@jfarr.cc>,
"Jeff Xu" <jeffxu@chromium.org>, "Kees Cook" <kees@kernel.org>,
"Masahiro Yamada" <masahiroy@kernel.org>,
"Michal Koutný" <mkoutny@suse.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Mike Rapoport (Microsoft)" <rppt@kernel.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Shakeel Butt" <shakeel.butt@linux.dev>,
"Tejun Heo" <tj@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Thomas Weißschuh" <thomas.weissschuh@linutronix.de>,
"Uladzislau Rezki (Sony)" <urezki@gmail.com>
Subject: Re: [PATCH] init/main.c: Wrap long kernel cmdline when printing to logs
Date: Mon, 20 Oct 2025 11:51:32 -0700 [thread overview]
Message-ID: <20251020115132.10897a599c8fbda4829b3f89@linux-foundation.org> (raw)
In-Reply-To: <20251019100605.1.I095f1e2c6c27f9f4de0b4841f725f356c643a13f@changeid>
On Sun, 19 Oct 2025 10:06:14 -0700 Douglas Anderson <dianders@chromium.org> wrote:
> The kernel cmdline length is allowed to be longer than what printk can
> handle. When this happens the cmdline that's printed to the kernel
> ring buffer at bootup is cutoff and some kernel cmdline options are
> "hidden" from the logs. This undercuts the usefulness of the log
> message.
>
> Add wrapping to the printout.
Do we really need the wrapping? That will confuse anything which
parses the output expecting a single line.
And the code would presumably be much simpler if we simply chunked up
the printing and spat out one really long line.
next prev parent reply other threads:[~2025-10-20 18:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-19 17:06 Douglas Anderson
2025-10-19 22:22 ` Randy Dunlap
2025-10-20 15:33 ` Doug Anderson
2025-10-20 15:40 ` Geert Uytterhoeven
2025-10-20 15:57 ` Doug Anderson
2025-10-21 7:05 ` Geert Uytterhoeven
2025-10-21 13:16 ` Heiko Carstens
2025-10-21 16:07 ` Doug Anderson
2025-10-20 17:18 ` Randy Dunlap
2025-10-20 18:51 ` Andrew Morton [this message]
2025-10-20 20:00 ` Doug Anderson
2025-10-21 20:55 ` Andrew Morton
2025-10-21 22:57 ` Doug Anderson
2025-10-21 23:06 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251020115132.10897a599c8fbda4829b3f89@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=achant@google.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=brauner@kernel.org \
--cc=brgerst@gmail.com \
--cc=chenhuacai@kernel.org \
--cc=dianders@chromium.org \
--cc=francesco@valla.it \
--cc=geert+renesas@glider.be \
--cc=guoweikang.kernel@gmail.com \
--cc=jeffxu@chromium.org \
--cc=kees@kernel.org \
--cc=kernel@jfarr.cc \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mkoutny@suse.com \
--cc=nathan@kernel.org \
--cc=ojeda@kernel.org \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=rppt@kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=tglx@linutronix.de \
--cc=thomas.weissschuh@linutronix.de \
--cc=tj@kernel.org \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®