mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Ard Biesheuvel <ardb@kernel.org>, Borislav Petkov <bp@alien8.de>,
	Josh Poimboeuf <jpoimboe@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] objtool: fix failure when being compiled on x32 system
Date: Mon, 20 Oct 2025 14:38:35 +0200	[thread overview]
Message-ID: <20251020123835.GE4067720@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <1ac32fff-2e67-5155-f570-69aad5bf5412@redhat.com>

On Mon, Oct 20, 2025 at 02:23:58PM +0200, Mikulas Patocka wrote:
> Fix compilation failure when compiling the kernel with the x32 toolchain.
> 
> In file included from check.c:16:
> check.c: In function ‘check_abs_references’:
> /usr/src/git/linux-2.6/tools/objtool/include/objtool/warn.h:47:17: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 7 has type ‘u64’ {aka ‘long
> long unsigned int’} [-Werror=format=]
>    47 |                 "%s%s%s: objtool" extra ": " format "\n",               \
>       |                 ^~~~~~~~~~~~~~~~~
> /usr/src/git/linux-2.6/tools/objtool/include/objtool/warn.h:54:9: note: in expansion of macro ‘___WARN’
>    54 |         ___WARN(severity, "", format, ##__VA_ARGS__)
>       |         ^~~~~~~
> /usr/src/git/linux-2.6/tools/objtool/include/objtool/warn.h:74:27: note: in expansion of macro ‘__WARN’
>    74 | #define WARN(format, ...) __WARN(WARN_STR, format, ##__VA_ARGS__)
>       |                           ^~~~~~
> check.c:4713:33: note: in expansion of macro ‘WARN’
>  4713 |                                 WARN("section %s has absolute relocation at offset 0x%lx",
>       |                                 ^~~~
> 
> Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
> Fixes: 0d6e4563fc03 ("objtool: Add action to check for absence of absolute relocations")

You could've kept Ard's Ack. I'll go add it manually.

Thanks!

  reply	other threads:[~2025-10-21 17:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-20 12:23 Mikulas Patocka
2025-10-20 12:38 ` Peter Zijlstra [this message]
2025-10-22 13:28 ` [tip: objtool/urgent] objtool: Fix " tip-bot2 for Mikulas Patocka
     [not found] <f80021c8-f8e1-9ed2-4791-705c4d7b7b8a@redhat.com>
2025-10-14  7:33 ` [PATCH] objtool: fix " Ard Biesheuvel
2025-10-15 15:56   ` Josh Poimboeuf
2025-10-20 12:24     ` Mikulas Patocka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251020123835.GE4067720@noisy.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=ardb@kernel.org \
    --cc=bp@alien8.de \
    --cc=jpoimboe@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpatocka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®