From: Jinhui Guo <guojinhui.liam@bytedance.com>
To: mika.westerberg@linux.intel.com,
andriy.shevchenko@linux.intel.com, jsd@semihalf.com,
andi.shyti@kernel.org
Cc: guojinhui.liam@bytedance.com, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/1] i2c: designware: Fix SMBUS Master interrupts storms
Date: Tue, 21 Oct 2025 15:24:30 +0800 [thread overview]
Message-ID: <20251021072431.3427-1-guojinhui.liam@bytedance.com> (raw)
Hi all,
We hit interrupt storms on the SMBus master extend-clock timeout IRQ
and SMBUS Slave Clock Extend Timeout IRQ because broken firmware left
IC_SMBUS=1 while the driver IRQ handler never services SMBus events.
Since we cannot disable IC_SMBUS directly, mask its interrupts to
prevent floods and make the driver more robust.
Thanks,
Jinhui
---
v1: https://lore.kernel.org/all/20251011073057.2959-1-guojinhui.liam@bytedance.com/
Changelog in v1 -> v2 (suggested by Mika and Andy Shevchenko)
- Drop the stand-alone i2c_dw_disable_smbus_intr() wrapper and mask
the SMBus interrupt directly in i2c_dw_init_master() after the
adapter is disabled. [Tested]
- Align the DW_IC_SMBUS_INTR_MASK macro definition to three TABs so
that it matches the surrounding macro indentation style.
Jinhui Guo (1):
i2c: designware: Disable SMBus interrupts to prevent storms from
mis-configured firmware
drivers/i2c/busses/i2c-designware-core.h | 1 +
drivers/i2c/busses/i2c-designware-master.c | 7 +++++++
2 files changed, 8 insertions(+)
--
2.20.1
next reply other threads:[~2025-10-21 7:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 7:24 Jinhui Guo [this message]
2025-10-21 7:24 ` [PATCH v2 1/1] i2c: designware: Disable SMBus interrupts to prevent storms from mis-configured firmware Jinhui Guo
2025-10-21 7:36 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251021072431.3427-1-guojinhui.liam@bytedance.com \
--to=guojinhui.liam@bytedance.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®