mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lorenzo Pieralisi <lpieralisi@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-pci@vger.kernel.org, "Frank Li" <Frank.Li@nxp.com>,
	"Rob Herring" <robh@kernel.org>,
	"Sascha Bischoff" <sascha.bischoff@arm.com>,
	"Scott Branden" <sbranden@broadcom.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Ray Jui" <rjui@broadcom.com>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
	"Marc Zyngier" <maz@kernel.org>
Subject: [PATCH v4 2/5] of/irq: Fix OF node refcount in of_msi_get_domain()
Date: Tue, 21 Oct 2025 14:41:00 +0200	[thread overview]
Message-ID: <20251021124103.198419-3-lpieralisi@kernel.org> (raw)
In-Reply-To: <20251021124103.198419-1-lpieralisi@kernel.org>

In of_msi_get_domain() if the iterator loop stops early because an
irq_domain match is detected, an of_node_put() on the iterator node is
needed to keep the OF node refcount in sync.

Add it.

Signed-off-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Cc: Rob Herring <robh@kernel.org>
---
 drivers/of/irq.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index 321d40ec229b..ee7d5f0842e8 100644
--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c
@@ -774,8 +774,10 @@ struct irq_domain *of_msi_get_domain(struct device *dev,
 
 	of_for_each_phandle(&it, err, np, "msi-parent", "#msi-cells", 0) {
 		d = irq_find_matching_host(it.node, token);
-		if (d)
+		if (d) {
+			of_node_put(it.node);
 			return d;
+		}
 	}
 
 	return NULL;
-- 
2.50.1


  parent reply	other threads:[~2025-10-21 12:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-21 12:40 [PATCH v4 0/5] of/irq: Misc msi-parent handling fixes/clean-ups Lorenzo Pieralisi
2025-10-21 12:40 ` [PATCH v4 1/5] of/irq: Add msi-parent check to of_msi_xlate() Lorenzo Pieralisi
2025-10-21 12:41 ` Lorenzo Pieralisi [this message]
2025-10-21 12:41 ` [PATCH v4 3/5] of/irq: Export of_msi_xlate() for module usage Lorenzo Pieralisi
2025-10-22 14:05   ` Rob Herring
2025-10-21 12:41 ` [PATCH v4 4/5] PCI: iproc: Implement MSI controller node detection with of_msi_xlate() Lorenzo Pieralisi
2025-10-21 15:45   ` Bjorn Helgaas
2025-11-22 16:11   ` [tip: irq/msi] " tip-bot2 for Lorenzo Pieralisi
2025-10-21 12:41 ` [PATCH v4 5/5] irqchip/gic-its: Rework platform MSI deviceID detection Lorenzo Pieralisi
2025-10-21 15:15   ` Marc Zyngier
2025-11-22 16:11   ` [tip: irq/msi] " tip-bot2 for Lorenzo Pieralisi
2025-10-22 14:05 ` [PATCH v4 0/5] of/irq: Misc msi-parent handling fixes/clean-ups Rob Herring
2025-10-24  9:44   ` Thomas Gleixner
2025-10-24 12:43     ` Rob Herring
2025-10-24 15:55       ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251021124103.198419-3-lpieralisi@kernel.org \
    --to=lpieralisi@kernel.org \
    --cc=Frank.Li@nxp.com \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kwilczynski@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=maz@kernel.org \
    --cc=rjui@broadcom.com \
    --cc=robh@kernel.org \
    --cc=sascha.bischoff@arm.com \
    --cc=sbranden@broadcom.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®