From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BA5A3126BA for ; Wed, 22 Oct 2025 12:08:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761134900; cv=none; b=rBe7jNeNzuo/MGgGiud7X0i/0YD7OYJGItcGS7pUV+Dw+BoJAwQwA+HFDMgMe/23wumZbmNcEjzTTLWRtMyFJi6WBeabU2o164JBNHS/Vso+VOfyV+P7WeYyUuPsxsIB8a7ZVGzsWrrpwxwlwmBdV26f7KKBZYAk4jUBLKT3lNw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761134900; c=relaxed/simple; bh=tZhHNi5tiOiq5ZyFScnnqPfCNqj/bQHHe9aIYrpZW4I=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=PVh8DahNDJVB8AeZbDMwJHdsPzxK71+LrdTjtNnQNoA58K8UdDtyxT8HchsWBKh+4YwzDYwPBiNIjMWGQaq0KUgJxYsLAeitSyFJNURhpvhXYi/61XhKJ7do1P3T/SCXWAWu90I5zCvJJHOI1AJJZ9maChZOqns5FqdyUP3c8E0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=mAb/BAuD; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mAb/BAuD" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-3f0ae439b56so4777216f8f.3 for ; Wed, 22 Oct 2025 05:08:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1761134895; x=1761739695; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DvbnSMIYk5HD128ctAAfLOD94aj1lQC5qodcVPOSef8=; b=mAb/BAuDoSfCWnlXuhzOZxDIIkeYs1WisznnsMqjrFqo98GMGDq/bZOuWeKp1aQcry +Jph9qfwTrxt2IK4e2YaizdedWsKnmnifSTkoGjx6hcYuBAAY6VX2aWvOPgGeb5V0w5B 4+JG9QD0Uu7qFWT4z+rxiz8j/1GbyP5c9vT1t1rKF8W+aMHAAVP3KybcO3YsUV272ZNt 2r3xdqKtV8BYIsIMPBcDHssOEvAi+T5YAH2LTMAomGrKvg/1Szbo72ZQw52kxqxviGEu AFn6qjKTqw9ecfjgxFsUbG5m0BL32XQyQLtDf64P/syrq8I97t7Lto6oPC4s3PH7HEM/ QgVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761134895; x=1761739695; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DvbnSMIYk5HD128ctAAfLOD94aj1lQC5qodcVPOSef8=; b=mvr3CjINwJxVL5UdVbIyugXT+NJPsKJgVFFcSwcbUjp5IMY6aVN4Y33nHiSEk5SrpH xg4ysau9joYknOg80gyNgZIJtBMXAZGnnz7S9ythPnzJfS0SBKeBRjL3BeOQtnt/zRwc 0gG32qoFPhODhpbCWgTqIyOaiPL7hIlih868qEXTM773O6DMMRv/4g0LZFY0iP8hLeJY 3X8O6J7eJdjO0Rm4fM44CQzpWwoc0IZNT2YF7bZVXpKnxGD7nGoGmFh/WAbQyossCMn9 8rJHho1aK86KijOpAzOWeSdTbl7hoiHohYW/nH+2U9O4hyItGDj3W2rQigeW7tKQZ1jD Dw8Q== X-Forwarded-Encrypted: i=1; AJvYcCVTiuryxrUvAQbWYL3W9vqRYOecEyeoGafIHB4d3j8eP9FokZJ8dyWJvddZ/toe2mH9tTKPYAzSJmhPA3A=@vger.kernel.org X-Gm-Message-State: AOJu0YxIs1xhaF9E81k+Cnepg9Ta7OKj7ItjQOdXrlazU+97BsMb3082 4ImSCQkAe4Vt7s9ZxDlzXlmxZw+iO2EGcEl5QGEMR0k+UmrFBhOZJnL3Pcj92967EHE= X-Gm-Gg: ASbGncuWrWRZN9ALJdcS8oSz94vj2sWGUnD0KTrepKmG7GUksagG5aXL+rbzKizD3ww +eiRSx4xlx1w2NrGRNuZyi7Lo4Jmkm0CF6psXJgtcENFRs/DcZPE+ZlKXzZLyMX55047oy9F27c F4w3Y/tY/DESiqOFXtgUFvM+FqBwWiD2PEyuiroOh9i5tpJLXpoImC6E0ZmBZFHOy3bVSPQeLMh 2nnOSakjinTCBIS3jwpHmGVZ57tIywiXjp2iRYBJFew110sGKb9YDAfVWCBYRuWgr6PjOr5+fOS QlEWsKdESgC+Z5xA8EXr/eD5Bl/57OR6xU+LC9/677Md6g+n/9JRp6gGkcMe/QVaFOwVe6HoyAZ aboOLFLGbf3EKIASSf1vcdxRXvaQ3o0tWtIv5k48zpXFgRmHs71C5Izpkem8/dOMmFS6Pn9KDjh HNMZ4P47zsEwuGdYOk X-Google-Smtp-Source: AGHT+IFtLElvxR81Tckw5mAAABXqwaPNv/lBu1tgkcuWlvZJfGpip3RMbzFOLoUXkftAvfjFkop/kg== X-Received: by 2002:a5d:5f82:0:b0:3fa:5925:4b07 with SMTP id ffacd0b85a97d-42704d74f9fmr12489147f8f.18.1761134895206; Wed, 22 Oct 2025 05:08:15 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-47496cf3b51sm35168225e9.9.2025.10.22.05.08.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Oct 2025 05:08:14 -0700 (PDT) Date: Wed, 22 Oct 2025 15:08:10 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Artem Shimko , Eugeniy Paltsev , Vinod Koul , Philipp Zabel Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Artem Shimko , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/2] dmaengine: dw-axi-dmac: add reset control support Message-ID: <202510221508.PY6fB9CB-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251017102950.206443-3-a.shimko.dev@gmail.com> Hi Artem, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Artem-Shimko/dmaengine-dw-axi-dmac-simplify-PM-functions-and-use-modern-macros/20251017-183103 base: https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git next patch link: https://lore.kernel.org/r/20251017102950.206443-3-a.shimko.dev%40gmail.com patch subject: [PATCH v4 2/2] dmaengine: dw-axi-dmac: add reset control support config: loongarch-randconfig-r072-20251019 (https://download.01.org/0day-ci/archive/20251022/202510221508.PY6fB9CB-lkp@intel.com/config) compiler: loongarch64-linux-gcc (GCC) 15.1.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202510221508.PY6fB9CB-lkp@intel.com/ New smatch warnings: drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:1355 axi_dma_resume() warn: 'chip->core_clk' from clk_prepare_enable() not released on lines: 1350. Old smatch warnings: drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:1237 dma_chan_pause() warn: inconsistent indenting drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:1284 axi_chan_resume() warn: inconsistent indenting drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:1355 axi_dma_resume() warn: 'chip->cfgr_clk' from clk_prepare_enable() not released on lines: 1346,1350. vim +1355 drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c 45fdf99125b2bf7 Artem Shimko 2025-10-17 1335 static int axi_dma_resume(struct device *dev) I guess kbuild bot thinks these are new warnings because the function was renamed. In the past we've just ignored clk_prepare_enable() warnings. Perhaps that's the correct thing to do in a resume function. The indenting in dma_chan_pause() and axi_chan_resume() could be cleaned up. 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1336 { 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1337 int ret; 45fdf99125b2bf7 Artem Shimko 2025-10-17 1338 struct axi_dma_chip *chip = dev_get_drvdata(dev); 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1339 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1340 ret = clk_prepare_enable(chip->cfgr_clk); 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1341 if (ret < 0) 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1342 return ret; 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1343 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1344 ret = clk_prepare_enable(chip->core_clk); 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1345 if (ret < 0) 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1346 return ret; 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1347 9c360f02c387f93 Artem Shimko 2025-10-17 1348 ret = reset_control_deassert(chip->resets); 9c360f02c387f93 Artem Shimko 2025-10-17 1349 if (ret) 9c360f02c387f93 Artem Shimko 2025-10-17 1350 return ret; 9c360f02c387f93 Artem Shimko 2025-10-17 1351 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1352 axi_dma_enable(chip); 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1353 axi_dma_irq_enable(chip); 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1354 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 @1355 return 0; 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1356 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki