mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: linux-kernel@vger.kernel.org,
	linux-s390 <linux-s390@vger.kernel.org>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	"Andrew Chant" <achant@google.com>,
	"Geert Uytterhoeven" <geert@linux-m68k.org>,
	"Heiko Carstens" <hca@linux.ibm.com>,
	"Paul E . McKenney" <paulmck@kernel.org>,
	"Sven Schnelle" <svens@linux.ibm.com>,
	"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
	"Brian Gerst" <brgerst@gmail.com>,
	"Christian Brauner" <brauner@kernel.org>,
	"Francesco Valla" <francesco@valla.it>,
	"Guo Weikang" <guoweikang.kernel@gmail.com>,
	"Huacai Chen" <chenhuacai@kernel.org>,
	"Ingo Molnar" <mingo@kernel.org>,
	"Jan Hendrik Farr" <kernel@jfarr.cc>,
	"Jeff Xu" <jeffxu@chromium.org>, "Kees Cook" <kees@kernel.org>,
	"Masahiro Yamada" <masahiroy@kernel.org>,
	"Michal Koutný" <mkoutny@suse.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Mike Rapoport (Microsoft)" <rppt@kernel.org>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Shakeel Butt" <shakeel.butt@linux.dev>,
	"Tejun Heo" <tj@kernel.org>,
	"Thomas Gleixner" <tglx@linutronix.de>
Subject: Re: [PATCH v3] init/main.c: Wrap long kernel cmdline when printing to logs
Date: Thu, 23 Oct 2025 12:37:09 -0700	[thread overview]
Message-ID: <20251023123709.e6517087325a3a53221029d9@linux-foundation.org> (raw)
In-Reply-To: <20251023113257.v3.1.I095f1e2c6c27f9f4de0b4841f725f356c643a13f@changeid>

On Thu, 23 Oct 2025 11:33:05 -0700 Douglas Anderson <dianders@chromium.org> wrote:

>
> Add wrapping to the printout of the kernel command line.
>

Spose so.

>
>
>  init/Kconfig | 18 ++++++++++
>  init/main.c  | 96 +++++++++++++++++++++++++++++++++++++++++++++++++++-
>  2 files changed, 113 insertions(+), 1 deletion(-)

It seems like a lot of fuss for a small problem.  But this:

--- a/init/main.c~init-mainc-wrap-long-kernel-cmdline-when-printing-to-logs-fix
+++ a/init/main.c
@@ -944,7 +944,7 @@ static void __init early_numa_node_init(
  *   Kernel command line: jumps over the \
  *   Kernel command line: lazy dog."
  */
-static void print_kernel_cmdline(const char *cmdline)
+static void __init print_kernel_cmdline(const char *cmdline)
 {
 	size_t len;
 
_

will make it a whole lot more palatable, no?

  reply	other threads:[~2025-10-23 19:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-23 18:33 Douglas Anderson
2025-10-23 19:37 ` Andrew Morton [this message]
2025-10-23 20:46   ` Doug Anderson
2025-10-23 21:12     ` Andrew Morton
2025-10-23 21:49 ` Paul E. McKenney
2025-10-24  7:50 ` Geert Uytterhoeven
2025-10-24 16:03   ` Doug Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251023123709.e6517087325a3a53221029d9@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=achant@google.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=brauner@kernel.org \
    --cc=brgerst@gmail.com \
    --cc=chenhuacai@kernel.org \
    --cc=dianders@chromium.org \
    --cc=francesco@valla.it \
    --cc=geert@linux-m68k.org \
    --cc=guoweikang.kernel@gmail.com \
    --cc=hca@linux.ibm.com \
    --cc=jeffxu@chromium.org \
    --cc=kees@kernel.org \
    --cc=kernel@jfarr.cc \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=mingo@kernel.org \
    --cc=mkoutny@suse.com \
    --cc=nathan@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rdunlap@infradead.org \
    --cc=rppt@kernel.org \
    --cc=shakeel.butt@linux.dev \
    --cc=svens@linux.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®