From: Detlev Casanova <detlev.casanova@collabora.com>
To: linux-kernel@vger.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Detlev Casanova <detlev.casanova@collabora.com>,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Heiko Stuebner <heiko@sntech.de>,
Ricardo Ribalda <ribalda@chromium.org>,
Hans Verkuil <hverkuil@kernel.org>,
Hans de Goede <hansg@kernel.org>, Yunke Cao <yunkec@google.com>,
Jonathan Corbet <corbet@lwn.net>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
James Cowgill <james.cowgill@blaize.com>,
linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, kernel@collabora.com,
Nicolas Dufresne <nicolas.dufresne@collabora.com>,
Diederik de Haas <didi.debian@cknow.org>
Subject: [PATCH v5 08/15] media: rkvdec: Add variant specific coded formats list
Date: Thu, 23 Oct 2025 17:42:39 -0400 [thread overview]
Message-ID: <20251023214247.459931-9-detlev.casanova@collabora.com> (raw)
In-Reply-To: <20251023214247.459931-1-detlev.casanova@collabora.com>
Prepare for adding new variants of the decoder and support specific
formats and format ops per variant.
Tested-by: Diederik de Haas <didi.debian@cknow.org> # Rock 5B
Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
---
.../media/platform/rockchip/rkvdec/rkvdec.c | 35 ++++++++++++-------
.../media/platform/rockchip/rkvdec/rkvdec.h | 2 ++
2 files changed, 24 insertions(+), 13 deletions(-)
diff --git a/drivers/media/platform/rockchip/rkvdec/rkvdec.c b/drivers/media/platform/rockchip/rkvdec/rkvdec.c
index 776149f871b0..968982f6e62c 100644
--- a/drivers/media/platform/rockchip/rkvdec/rkvdec.c
+++ b/drivers/media/platform/rockchip/rkvdec/rkvdec.c
@@ -373,15 +373,16 @@ static bool rkvdec_is_capable(struct rkvdec_ctx *ctx, unsigned int capability)
static const struct rkvdec_coded_fmt_desc *
rkvdec_enum_coded_fmt_desc(struct rkvdec_ctx *ctx, int index)
{
+ const struct rkvdec_variant *variant = ctx->dev->variant;
int fmt_idx = -1;
unsigned int i;
- for (i = 0; i < ARRAY_SIZE(rkvdec_coded_fmts); i++) {
- if (!rkvdec_is_capable(ctx, rkvdec_coded_fmts[i].capability))
+ for (i = 0; i < variant->num_coded_fmts; i++) {
+ if (!rkvdec_is_capable(ctx, variant->coded_fmts[i].capability))
continue;
fmt_idx++;
if (index == fmt_idx)
- return &rkvdec_coded_fmts[i];
+ return &variant->coded_fmts[i];
}
return NULL;
@@ -390,12 +391,13 @@ rkvdec_enum_coded_fmt_desc(struct rkvdec_ctx *ctx, int index)
static const struct rkvdec_coded_fmt_desc *
rkvdec_find_coded_fmt_desc(struct rkvdec_ctx *ctx, u32 fourcc)
{
+ const struct rkvdec_variant *variant = ctx->dev->variant;
unsigned int i;
- for (i = 0; i < ARRAY_SIZE(rkvdec_coded_fmts); i++) {
- if (rkvdec_is_capable(ctx, rkvdec_coded_fmts[i].capability) &&
- rkvdec_coded_fmts[i].fourcc == fourcc)
- return &rkvdec_coded_fmts[i];
+ for (i = 0; i < variant->num_coded_fmts; i++) {
+ if (rkvdec_is_capable(ctx, variant->coded_fmts[i].capability) &&
+ variant->coded_fmts[i].fourcc == fourcc)
+ return &variant->coded_fmts[i];
}
return NULL;
@@ -1014,18 +1016,19 @@ static int rkvdec_add_ctrls(struct rkvdec_ctx *ctx,
static int rkvdec_init_ctrls(struct rkvdec_ctx *ctx)
{
+ const struct rkvdec_variant *variant = ctx->dev->variant;
unsigned int i, nctrls = 0;
int ret;
- for (i = 0; i < ARRAY_SIZE(rkvdec_coded_fmts); i++)
- if (rkvdec_is_capable(ctx, rkvdec_coded_fmts[i].capability))
- nctrls += rkvdec_coded_fmts[i].ctrls->num_ctrls;
+ for (i = 0; i < variant->num_coded_fmts; i++)
+ if (rkvdec_is_capable(ctx, variant->coded_fmts[i].capability))
+ nctrls += variant->coded_fmts[i].ctrls->num_ctrls;
v4l2_ctrl_handler_init(&ctx->ctrl_hdl, nctrls);
- for (i = 0; i < ARRAY_SIZE(rkvdec_coded_fmts); i++) {
- if (rkvdec_is_capable(ctx, rkvdec_coded_fmts[i].capability)) {
- ret = rkvdec_add_ctrls(ctx, rkvdec_coded_fmts[i].ctrls);
+ for (i = 0; i < variant->num_coded_fmts; i++) {
+ if (rkvdec_is_capable(ctx, variant->coded_fmts[i].capability)) {
+ ret = rkvdec_add_ctrls(ctx, variant->coded_fmts[i].ctrls);
if (ret)
goto err_free_handler;
}
@@ -1242,11 +1245,15 @@ static void rkvdec_watchdog_func(struct work_struct *work)
static const struct rkvdec_variant rk3288_rkvdec_variant = {
.num_regs = 68,
+ .coded_fmts = rkvdec_coded_fmts,
+ .num_coded_fmts = ARRAY_SIZE(rkvdec_coded_fmts),
.capabilities = RKVDEC_CAPABILITY_HEVC,
};
static const struct rkvdec_variant rk3328_rkvdec_variant = {
.num_regs = 109,
+ .coded_fmts = rkvdec_coded_fmts,
+ .num_coded_fmts = ARRAY_SIZE(rkvdec_coded_fmts),
.capabilities = RKVDEC_CAPABILITY_HEVC |
RKVDEC_CAPABILITY_H264 |
RKVDEC_CAPABILITY_VP9,
@@ -1255,6 +1262,8 @@ static const struct rkvdec_variant rk3328_rkvdec_variant = {
static const struct rkvdec_variant rk3399_rkvdec_variant = {
.num_regs = 78,
+ .coded_fmts = rkvdec_coded_fmts,
+ .num_coded_fmts = ARRAY_SIZE(rkvdec_coded_fmts),
.capabilities = RKVDEC_CAPABILITY_HEVC |
RKVDEC_CAPABILITY_H264 |
RKVDEC_CAPABILITY_VP9,
diff --git a/drivers/media/platform/rockchip/rkvdec/rkvdec.h b/drivers/media/platform/rockchip/rkvdec/rkvdec.h
index f35f6e80ea2e..aac6cba4c623 100644
--- a/drivers/media/platform/rockchip/rkvdec/rkvdec.h
+++ b/drivers/media/platform/rockchip/rkvdec/rkvdec.h
@@ -71,6 +71,8 @@ vb2_to_rkvdec_decoded_buf(struct vb2_buffer *buf)
struct rkvdec_variant {
unsigned int num_regs;
+ const struct rkvdec_coded_fmt_desc *coded_fmts;
+ size_t num_coded_fmts;
unsigned int capabilities;
unsigned int quirks;
};
--
2.51.1.dirty
next prev parent reply other threads:[~2025-10-23 21:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 21:42 [PATCH v5 00/15] media: rkvdec: Add support for VDPU381 and VDPU383 Detlev Casanova
2025-10-23 21:42 ` [PATCH v5 01/15] media: uapi: HEVC: Add v4l2_ctrl_hevc_ext_sps_[ls]t_rps controls Detlev Casanova
2025-10-24 7:55 ` Hans Verkuil
2025-12-16 20:48 ` Detlev Casanova
2025-12-16 22:02 ` Nicolas Dufresne
2025-12-16 22:18 ` Detlev Casanova
2025-12-17 13:34 ` Nicolas Dufresne
2025-10-23 21:42 ` [PATCH v5 02/15] media: v4l2-ctrls: Add hevc_ext_sps_[ls]t_rps controls Detlev Casanova
2025-10-23 21:42 ` [PATCH v5 03/15] media: rkvdec: Switch to using structs instead of writel Detlev Casanova
2025-10-23 21:42 ` [PATCH v5 04/15] media: rkvdec: Move cabac tables to their own source file Detlev Casanova
2025-10-23 21:42 ` [PATCH v5 05/15] media: rkvdec: Use structs to represent the HW RPS Detlev Casanova
2025-10-23 21:42 ` [PATCH v5 06/15] media: rkvdec: Move h264 functions to common file Detlev Casanova
2025-10-23 21:42 ` [PATCH v5 07/15] media: rkvdec: Move hevc " Detlev Casanova
2025-10-23 21:42 ` Detlev Casanova [this message]
2025-10-23 21:42 ` [PATCH v5 09/15] media: rkvdec: Add RCB and SRAM support Detlev Casanova
2025-10-23 21:42 ` [PATCH v5 10/15] media: rkvdec: Support per-variant interrupt handler Detlev Casanova
2025-10-23 21:42 ` [PATCH v5 11/15] media: rkvdec: Enable all clocks without naming them Detlev Casanova
2025-10-23 21:42 ` [PATCH v5 12/15] media: rkvdec: Add H264 support for the VDPU381 variant Detlev Casanova
2025-10-23 22:53 ` Jonas Karlman
2025-10-23 21:42 ` [PATCH v5 13/15] media: rkvdec: Add H264 support for the VDPU383 variant Detlev Casanova
2025-10-23 21:42 ` [PATCH v5 14/15] media: rkvdec: Add HEVC support for the VDPU381 variant Detlev Casanova
2025-10-23 21:42 ` [PATCH v5 15/15] media: rkvdec: Add HEVC support for the VDPU383 variant Detlev Casanova
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251023214247.459931-9-detlev.casanova@collabora.com \
--to=detlev.casanova@collabora.com \
--cc=corbet@lwn.net \
--cc=didi.debian@cknow.org \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=hansg@kernel.org \
--cc=heiko@sntech.de \
--cc=hverkuil@kernel.org \
--cc=james.cowgill@blaize.com \
--cc=kernel@collabora.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=nicolas.dufresne@collabora.com \
--cc=ribalda@chromium.org \
--cc=sakari.ailus@linux.intel.com \
--cc=yunkec@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®