From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp153-162.sina.com.cn (smtp153-162.sina.com.cn [61.135.153.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50CAB2EFD80 for ; Fri, 24 Oct 2025 23:25:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=61.135.153.162 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761348363; cv=none; b=mFsjXTrMjztrl6AUlTGerAtQBiZDobKUHJJyrgl0zZni/Qa5FgZNXTn4f2INKnevdj2SOwKT3yHM+rudC6iF4SNbr0bFGC1qTbOh4/ZY+MmsUvp2r4S9n96TdKrRhkWlXqYaWvEPy8GjiCVZoPpiiRWS58VDV11ww4pTE1K6JIY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761348363; c=relaxed/simple; bh=JnBSWPnywjh1398V6XIeFjYzAtApDUflqSGMIRMPDf8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Dftt/TNnWawPqQXQS1O64wyp/54Km/3BzxjBotdCL+k8RzXX7s8jgN88q75/a8yiWEuGQEH7iU8FPKolzo/R1BibDD+1Cieohj6Zb7PgTUkJdJ2/pb+dC4Pa2oXf7F3/bTOsO1gBKOf7u1JLdyIkvqNIVMLvBjVTIESRx81GxvI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sina.com; spf=pass smtp.mailfrom=sina.com; dkim=pass (1024-bit key) header.d=sina.com header.i=@sina.com header.b=BJcIa5/G; arc=none smtp.client-ip=61.135.153.162 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sina.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sina.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=sina.com header.i=@sina.com header.b="BJcIa5/G" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sina.com; s=201208; t=1761348356; bh=JZjQ2LqcYw+dVeyBIzBUQ7Hz5flKU9QyhobNZyh5Zuk=; h=From:Subject:Date:Message-ID; b=BJcIa5/GunAQFCTwMDMIR+uAk0ATk2v4ZcSR0l7khAMyRUfYTZbqa8pNx1Y2DSp7j w/cHK67upAWRHGVbbC1ibFEaTeAyRlzLarCI/znioBEWNcC9RJOxVPeSbmjgki3S3+ cOJqIzckt+460OzmtVtGGuYFejpl69oTMtAArWZM= X-SMAIL-HELO: localhost.localdomain Received: from unknown (HELO localhost.localdomain)([114.249.58.236]) by sina.com (10.54.253.31) with ESMTP id 68FC0AD400004BCC; Fri, 25 Oct 2025 07:25:11 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com Authentication-Results: sina.com; spf=none smtp.mailfrom=hdanton@sina.com; dkim=none header.i=none; dmarc=none action=none header.from=hdanton@sina.com X-SMAIL-MID: 4868976816219 X-SMAIL-UIID: E775CA12EA2B4AA78CFD77F72F430EE1-20251025-072511-1 From: Hillf Danton To: syzbot Cc: Sean Christopherson , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com, tabba@google.com, xiaoyao.li@intel.com Subject: Re: [syzbot] [kvm?] KASAN: slab-use-after-free Write in kvm_gmem_release Date: Sat, 25 Oct 2025 07:24:57 +0800 Message-ID: <20251024232459.8716-1-hdanton@sina.com> In-Reply-To: <68fb1966.050a0220.346f24.0093.GAE@google.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Thu, Oct 23, 2025, syzbot wrote: > syzbot has bisected this issue to: > > commit d1e54dd08f163a9021433020d16a8f8f70ddc41c > Author: Fuad Tabba > Date: Tue Jul 29 22:54:40 2025 +0000 > > KVM: x86: Enable KVM_GUEST_MEMFD for all 64-bit builds > > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=12a663cd980000 > start commit: 43e9ad0c55a3 Merge tag 'scsi-fixes' of git://git.kernel.or.. > git tree: upstream > final oops: https://syzkaller.appspot.com/x/report.txt?x=11a663cd980000 > console output: https://syzkaller.appspot.com/x/log.txt?x=16a663cd980000 > kernel config: https://syzkaller.appspot.com/x/.config?x=67b63a24f3c26fca > dashboard link: https://syzkaller.appspot.com/bug?extid=2479e53d0db9b32ae2aa > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=173ecd2f980000 > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=14bc2be2580000 Test Sean's fix. #syz test --- x/virt/kvm/guest_memfd.c +++ y/virt/kvm/guest_memfd.c @@ -708,23 +708,11 @@ err: return r; } -void kvm_gmem_unbind(struct kvm_memory_slot *slot) +static void __kvm_gmem_unbind(struct kvm_memory_slot *slot, struct gmem_file *f) { unsigned long start = slot->gmem.pgoff; unsigned long end = start + slot->npages; - struct gmem_file *f; - - /* - * Nothing to do if the underlying file was already closed (or is being - * closed right now), kvm_gmem_release() invalidates all bindings. - */ - CLASS(gmem_get_file, file)(slot); - if (!file) - return; - - f = file->private_data; - filemap_invalidate_lock(file->f_mapping); xa_store_range(&f->bindings, start, end - 1, NULL, GFP_KERNEL); /* @@ -732,7 +720,36 @@ void kvm_gmem_unbind(struct kvm_memory_s * cannot see this memslot. */ WRITE_ONCE(slot->gmem.file, NULL); - filemap_invalidate_unlock(file->f_mapping); +} + +void kvm_gmem_unbind(struct kvm_memory_slot *slot) +{ + /* + * Nothing to do if the underlying file was _already_ closed, as + * kvm_gmem_release() invalidates and nullifies all bindings. + */ + if (!slot->gmem.file) + return; + + CLASS(gmem_get_file, file)(slot); + + /* + * However, if the file is _being_ closed, then the bindings need to be + * removed as kvm_gmem_release() might not run until after the memslot + * is freed. Note, modifying the bindings is safe even though the file + * is dying as kvm_gmem_release() nullifies slot->gmem.file under + * slots_lock, and only puts its reference to KVM after destroying all + * bindings. I.e. reaching this point means kvm_gmem_release() can't + * concurrently destroy the bindings or free the gmem_file. + */ + if (!file) { + __kvm_gmem_unbind(slot, slot->gmem.file->private_data); + return; + } + + filemap_invalidate_lock(file->f_mapping); + __kvm_gmem_unbind(slot, file->private_data); + filemap_invalidate_unlock(file->f_mapping); } /* Returns a locked folio on success. */ --