From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from r3-17.sinamail.sina.com.cn (r3-17.sinamail.sina.com.cn [202.108.3.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B28C730F541 for ; Fri, 24 Oct 2025 23:49:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.108.3.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761349776; cv=none; b=rYmAnMvsu7SuLVc1s6eaAJ1+CUqXBz5Lo+W1u4Qj3K2wNn5KjSSJ2gmGRFWn3fJArY5H4N28lY8V8qXsIRtUVrIk4Sbf10IBZeo9ldhlEP/wIQmkAHoZsk8eEf3yen++EDBamuTQ82i0hx1GqWgrxPzLFNpSW/OOxy01Nk40/2M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761349776; c=relaxed/simple; bh=+HwySPOLzZkjbWIuZ/CLZqnVGlvCqx64TKi3BoQhzkA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Qz8BFmI4DvAse+FP9KwNmK1Ad85aL/AOghl6rsJ5C9vztPXzULR21T9aGjdnRue/C57LLW1kWmn+yuMyEpRgpiJxRwC3Lizd/YuycwmKQRiV4Zw7bsdaSjvmjP/tITkTrUydGu0lO9DP2N2fU2vTtLFpIfafODlD1rFTYzo3LHg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sina.com; spf=pass smtp.mailfrom=sina.com; dkim=pass (1024-bit key) header.d=sina.com header.i=@sina.com header.b=yXHkB3zR; arc=none smtp.client-ip=202.108.3.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sina.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sina.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=sina.com header.i=@sina.com header.b="yXHkB3zR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sina.com; s=201208; t=1761349772; bh=bG18YqAyheR8FAmAtsnw1Hx7+tojOHAi/Jxsv0Yhpwo=; h=From:Subject:Date:Message-ID; b=yXHkB3zRpQnGyBVZJCMpXP2xFNo/MXM1XI0PdTHPQbzGF4IYN2O51Ab3fJesGE8i5 awuwROw45pG3QdKlr5Rzs8ZNHEjn124NL5+yWvKkG35HgIjJ7SnSA+2AIJKwUv0fFI 04qrr8v3CPPAq4CWOlkWIWwzFEFqppUN7jO1sxZQ= X-SMAIL-HELO: localhost.localdomain Received: from unknown (HELO localhost.localdomain)([114.249.58.236]) by sina.com (10.54.253.34) with ESMTP id 68FC0F4100004C72; Fri, 25 Oct 2025 07:44:04 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com Authentication-Results: sina.com; spf=none smtp.mailfrom=hdanton@sina.com; dkim=none header.i=none; dmarc=none action=none header.from=hdanton@sina.com X-SMAIL-MID: 3966296291935 X-SMAIL-UIID: FDCEACB35A5243D5AD8A5D0593E870BB-20251025-074404-1 From: Hillf Danton To: syzbot Cc: Sean Christopherson , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com, tabba@google.com, xiaoyao.li@intel.com Subject: Re: [syzbot] [kvm?] KASAN: slab-use-after-free Write in kvm_gmem_release Date: Sat, 25 Oct 2025 07:43:51 +0800 Message-ID: <20251024234353.8746-1-hdanton@sina.com> In-Reply-To: <68fb1966.050a0220.346f24.0093.GAE@google.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Thu, Oct 23, 2025, syzbot wrote: > syzbot has bisected this issue to: > > commit d1e54dd08f163a9021433020d16a8f8f70ddc41c > Author: Fuad Tabba > Date: Tue Jul 29 22:54:40 2025 +0000 > > KVM: x86: Enable KVM_GUEST_MEMFD for all 64-bit builds > > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=12a663cd980000 > start commit: 43e9ad0c55a3 Merge tag 'scsi-fixes' of git://git.kernel.or.. > git tree: upstream > final oops: https://syzkaller.appspot.com/x/report.txt?x=11a663cd980000 > console output: https://syzkaller.appspot.com/x/log.txt?x=16a663cd980000 > kernel config: https://syzkaller.appspot.com/x/.config?x=67b63a24f3c26fca > dashboard link: https://syzkaller.appspot.com/bug?extid=2479e53d0db9b32ae2aa > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=173ecd2f980000 > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=14bc2be2580000 Test Sean's fix. #syz test linux-next master --- x/virt/kvm/guest_memfd.c +++ y/virt/kvm/guest_memfd.c @@ -708,23 +708,11 @@ err: return r; } -void kvm_gmem_unbind(struct kvm_memory_slot *slot) +static void __kvm_gmem_unbind(struct kvm_memory_slot *slot, struct gmem_file *f) { unsigned long start = slot->gmem.pgoff; unsigned long end = start + slot->npages; - struct gmem_file *f; - - /* - * Nothing to do if the underlying file was already closed (or is being - * closed right now), kvm_gmem_release() invalidates all bindings. - */ - CLASS(gmem_get_file, file)(slot); - if (!file) - return; - - f = file->private_data; - filemap_invalidate_lock(file->f_mapping); xa_store_range(&f->bindings, start, end - 1, NULL, GFP_KERNEL); /* @@ -732,7 +720,36 @@ void kvm_gmem_unbind(struct kvm_memory_s * cannot see this memslot. */ WRITE_ONCE(slot->gmem.file, NULL); - filemap_invalidate_unlock(file->f_mapping); +} + +void kvm_gmem_unbind(struct kvm_memory_slot *slot) +{ + /* + * Nothing to do if the underlying file was _already_ closed, as + * kvm_gmem_release() invalidates and nullifies all bindings. + */ + if (!slot->gmem.file) + return; + + CLASS(gmem_get_file, file)(slot); + + /* + * However, if the file is _being_ closed, then the bindings need to be + * removed as kvm_gmem_release() might not run until after the memslot + * is freed. Note, modifying the bindings is safe even though the file + * is dying as kvm_gmem_release() nullifies slot->gmem.file under + * slots_lock, and only puts its reference to KVM after destroying all + * bindings. I.e. reaching this point means kvm_gmem_release() can't + * concurrently destroy the bindings or free the gmem_file. + */ + if (!file) { + __kvm_gmem_unbind(slot, slot->gmem.file->private_data); + return; + } + + filemap_invalidate_lock(file->f_mapping); + __kvm_gmem_unbind(slot, file->private_data); + filemap_invalidate_unlock(file->f_mapping); } /* Returns a locked folio on success. */ --