From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1E9A302158 for ; Sat, 25 Oct 2025 17:13:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761412408; cv=none; b=IkBf+V49Z4U9MsSMLHuAcY/yhrteT/iNFOTOXcdqz2xYkfigbktJsDKHuUL4lUN84gBjEjOaxOb1/BkfSDdSPbz2x/kUTcfar9nWyXD5+CIm61mRFD/0dibDi2NYvcouKJmYxSwvhjsg89R06PEuvych/ayjU1IzrkCh8BDZR4k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761412408; c=relaxed/simple; bh=e7A26unbaP9hAYoj1SkxhsFZbhJCuCK4u8p+jfhPlZE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pn2VjETGB4A34/EAZRqR4UzGWs+PrgF5UwE1dlTdkRB7Wbkbt87DK2NQDiMa+kkWIGq+6G7j7eZjd+xNMyRNpfRFHU3xQrnqGFLV9u40XLEYFOWM9+ssDcr9DknoC/3qRhzh8rMhBBu2e9b6EkeZREPgd/kN5ERom5zgsl9zZdo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TD6FIVWP; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TD6FIVWP" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-780fc3b181aso2020898b3a.2 for ; Sat, 25 Oct 2025 10:13:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761412406; x=1762017206; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JHgAdAQC2Eo5vV0FXAPtfwzgCMbFl4JzyNeiEAhdKbs=; b=TD6FIVWPV2KvSRpF0/GWYxTSY3ppRVKG1tkxHD65aIatmDWuPgUMkR0yyJ7KvmAW9h 3zxdiqt0sVCa8pISmRJzKKL/EAiE9AFj2g6WSaamZWsTiz1Y4TqXiCPQKFOr3JMHWDtE YxqnQmOZo43wTtKgsJVOtK6KBx/f/+J7mBBvUwZfCeJ4PN2FcOOqTAFBcYKaiq5HR/7x xXwBB37r8czfiMzPFVWgzs2BAahiSf6kWJInRPzOyw2U/pqyz7NjDdNhMtAn1ZC83YwG SbELZfhnonnX+em/ThlnXbE9mSjWTZfZGVKTiJJSRwwvHXJNzZ8junuWTNvW6ct1CtPl brrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761412406; x=1762017206; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JHgAdAQC2Eo5vV0FXAPtfwzgCMbFl4JzyNeiEAhdKbs=; b=t+sZs3xNz0PgjOnJOqhGQ4kFbo1NEJ7oAN1TLD6+JN5QdEeiglEo3ukog+4jCmyel5 NOxtRCXs/ixsEj+9/WAJ4gn5z6HjUzTuKZgPOgC/Evydxnw283uE+p4LrhSpyLvloUPd jZVZOr+4WnAkTbDcJC/X4+Z5ZYkCpTD2ilw/pvsCPqn90BnkpBAGBb/b1Rekb4pSx7Ru LOFUUpe0v7i4N5Sgd7oxUu4AmU8YapziJIysiwhTg4S1vKo4AWJ8FouqvE3U0QxPFMOp r4FpT9Zm7yOXWk4N/IxZTh/xL3Muub2tLb5wCh6kcFcwevpjQls0wIVLToOsf83+KvCR HXkQ== X-Forwarded-Encrypted: i=1; AJvYcCUFjBJNOoGJkJpyOKzbZYDgSM/gUNpaIpRQZw4raV7cukEYW2YxQZaL8pq7/viI2LdMVsMK1rQ06eCw7b0=@vger.kernel.org X-Gm-Message-State: AOJu0Yx88Ngnn5GozLPi8f80LgPR0a4BXjvWM+qkOgljcB1phsy/7vDL N8cM/UzcPP9oGEymsQLbkDfJ4JuH/MogD18Lcl0oVnYex7mPeQJDPaui X-Gm-Gg: ASbGncuGyj2mRWRvslXI2oY7H4iLdDOwbVx++lOZ9iSl5Uf1de/nhHnorLfBh05emUQ AbuIYk5GYYm6zNQeEhdmwvvHuup1jMsXFXjsBAAL0n8sGJl2hNCwVnzkX2VbwJ/hoPt5ZkAFKsH 3DUaHVHYfCwL3q/0qdCZixy33Gt8GbHykPud511AKFJ1x/KJGaXXc8sYTMjF+TRnKtCPcaL17Vt EGnMho34KUZAjXtfq9wYdi7MwCLCB2aj15GKnxqIkQ0mt5UN1hniRhqnwo1qVa4yHVwoStn9F1d KaO/TOCcLB4SIsdgqImEaXBe7nj1U76h/XyyTsHMz55DFMQw34z1jrHewkfrC3/XwgpR+QsJdRK TLYQ4EPmIJcZbwDdUlHQeSFJa5bVhUItjBMdcFeBS2/ti/YPy0iPjFaPpQx2G7rhL98PN3kJkls n1GfwEuuP5oLul3EQGoA== X-Google-Smtp-Source: AGHT+IHfToilxDihPAF+e6IlMbKYVG4dZh2XU8lYpWC/85adxFkFY8/ZMNS44ontsF/nLpMQ7bFdpw== X-Received: by 2002:a05:6a00:23c2:b0:780:f758:4133 with SMTP id d2e1a72fcca58-7a274ba91d9mr11356205b3a.10.1761412406107; Sat, 25 Oct 2025 10:13:26 -0700 (PDT) Received: from d.home.yangfl.dn42 ([45.32.227.231]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7a414012bcesm2850481b3a.8.2025.10.25.10.13.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 10:13:25 -0700 (PDT) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org, Dan Carpenter , David Laight Subject: [PATCH net-next v2 1/2] net: dsa: yt921x: Fix MIB overflow wraparound routine Date: Sun, 26 Oct 2025 01:13:10 +0800 Message-ID: <20251025171314.1939608-2-mmyangfl@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251025171314.1939608-1-mmyangfl@gmail.com> References: <20251025171314.1939608-1-mmyangfl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Reported by the following Smatch static checker warning: drivers/net/dsa/yt921x.c:702 yt921x_read_mib() warn: was expecting a 64 bit value instead of '(~0)' Reported-by: Dan Carpenter Closes: https://lore.kernel.org/netdev/aPsjYKQMzpY0nSXm@stanley.mountain/ Suggested-by: David Laight Signed-off-by: David Yang --- drivers/net/dsa/yt921x.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/net/dsa/yt921x.c b/drivers/net/dsa/yt921x.c index ab762ffc4661..97a7eeb4ea15 100644 --- a/drivers/net/dsa/yt921x.c +++ b/drivers/net/dsa/yt921x.c @@ -687,21 +687,22 @@ static int yt921x_read_mib(struct yt921x_priv *priv, int port) const struct yt921x_mib_desc *desc = &yt921x_mib_descs[i]; u32 reg = YT921X_MIBn_DATA0(port) + desc->offset; u64 *valp = &((u64 *)mib)[i]; - u64 val = *valp; + u64 val; u32 val0; - u32 val1; res = yt921x_reg_read(priv, reg, &val0); if (res) break; if (desc->size <= 1) { - if (val < (u32)val) - /* overflow */ - val += (u64)U32_MAX + 1; - val &= ~U32_MAX; - val |= val0; + u64 old_val = *valp; + + val = (old_val & ~(u64)U32_MAX) | val0; + if (val < old_val) + val += 1ull << 32; } else { + u32 val1; + res = yt921x_reg_read(priv, reg + 4, &val1); if (res) break; -- 2.51.0