From: Borislav Petkov <bp@alien8.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: x86@kernel.org, "Leyvi Rose" <leyvirose@gmail.com>,
"Samuel Holland" <samuel.holland@sifive.com>,
"Christian König" <christian.koenig@amd.com>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: x86: Disable SSE4A
Date: Mon, 27 Oct 2025 13:40:49 +0100 [thread overview]
Message-ID: <20251027124049.GAaP9oUaUtzzHUK4j4@fat_crate.local> (raw)
In-Reply-To: <20251027114059.GJ3245006@noisy.programming.kicks-ass.net>
On Mon, Oct 27, 2025 at 12:40:59PM +0100, Peter Zijlstra wrote:
> Leyvi Rose reported that his X86_NATIVE_CPU=y build is failing because
> our instruction decoder doesn't support SSE4A and the AMDGPU code seems
> to be generating those with his compiler of choice (CLANG+LTO).
>
> Now, our normal build flags disable SSE MMX SSE2 3DNOW AVX, but then
> CC_FLAGS_FPU re-enable SSE SSE2.
>
> Since nothing mentions SSE3 or SSE4, I'm assuming that -msse (or its
> negative) control all SSE variants -- but why then explicitly enumerate
> SSE2 ?
>
> Anyway, until the instruction decoder gets fixed, explicitly disallow
> SSE4A (an AMD specific SSE4 extension).
>
> Fixes: ea1dcca1de12 ("x86/kbuild/64: Add the CONFIG_X86_NATIVE_CPU option to locally optimize the kernel with '-march=native'")
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> ---
>
> diff --git a/arch/x86/Makefile b/arch/x86/Makefile
> index 4db7e4bf69f5..8fbff3106c56 100644
> --- a/arch/x86/Makefile
> +++ b/arch/x86/Makefile
> @@ -75,7 +75,7 @@ export BITS
> #
> # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53383
> #
> -KBUILD_CFLAGS += -mno-sse -mno-mmx -mno-sse2 -mno-3dnow -mno-avx
> +KBUILD_CFLAGS += -mno-sse -mno-mmx -mno-sse2 -mno-3dnow -mno-avx -mno-sse4a
> KBUILD_RUSTFLAGS += --target=$(objtree)/scripts/target.json
> KBUILD_RUSTFLAGS += -Ctarget-feature=-sse,-sse2,-sse3,-ssse3,-sse4.1,-sse4.2,-avx,-avx2
Acked-by: Borislav Petkov (AMD) <bp@alien8.de>
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next parent reply other threads:[~2025-10-27 12:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20251027114059.GJ3245006@noisy.programming.kicks-ass.net>
2025-10-27 12:40 ` Borislav Petkov [this message]
2025-10-28 4:19 ` Arisu Tachibana
2025-10-28 8:32 ` Christian König
2025-10-28 15:37 ` Harry Wentland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251027124049.GAaP9oUaUtzzHUK4j4@fat_crate.local \
--to=bp@alien8.de \
--cc=christian.koenig@amd.com \
--cc=leyvirose@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=peterz@infradead.org \
--cc=samuel.holland@sifive.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®