From: Caleb James DeLisle <cjd@cjdns.fr>
To: nbd@nbd.name, lorenzo@kernel.org
Cc: ryder.lee@mediatek.com, shayne.chen@mediatek.com,
sean.wang@mediatek.com, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org,
Caleb James DeLisle <cjd@cjdns.fr>
Subject: [PATCH] wifi: mt76: mmio_(read|write)_copy byte swap when on Big Endian
Date: Mon, 27 Oct 2025 17:17:59 +0000 [thread overview]
Message-ID: <20251027171759.1484844-1-cjd@cjdns.fr> (raw)
When on a Big Endian machine, PCI swaps words to/from LE when
reading/writing them. This presents a problem when we're trying
to copy an opaque byte array such as firmware or encryption key.
Byte-swapping during copy results in two swaps, but solves the
problem.
Fixes:
mt76x2e 0000:02:00.0: ROM patch build: 20141115060606a
mt76x2e 0000:02:00.0: Firmware Version: 0.0.00
mt76x2e 0000:02:00.0: Build: 1
mt76x2e 0000:02:00.0: Build Time: 201607111443____
mt76x2e 0000:02:00.0: Firmware failed to start
mt76x2e 0000:02:00.0: probe with driver mt76x2e failed with error -145
Signed-off-by: Caleb James DeLisle <cjd@cjdns.fr>
---
drivers/net/wireless/mediatek/mt76/mmio.c | 34 +++++++++++++++++++++++
1 file changed, 34 insertions(+)
diff --git a/drivers/net/wireless/mediatek/mt76/mmio.c b/drivers/net/wireless/mediatek/mt76/mmio.c
index cd2e9737c3bf..776dbaacc8a3 100644
--- a/drivers/net/wireless/mediatek/mt76/mmio.c
+++ b/drivers/net/wireless/mediatek/mt76/mmio.c
@@ -30,15 +30,49 @@ static u32 mt76_mmio_rmw(struct mt76_dev *dev, u32 offset, u32 mask, u32 val)
return val;
}
+static void mt76_mmio_write_copy_portable(void __iomem *dst,
+ const u8 *src, int len)
+{
+ __le32 val;
+ int i = 0;
+
+ for (i = 0; i < ALIGN(len, 4); i += 4) {
+ memcpy(&val, src + i, sizeof(val));
+ writel(cpu_to_le32(val), dst + i);
+ }
+}
+
static void mt76_mmio_write_copy(struct mt76_dev *dev, u32 offset,
const void *data, int len)
{
+ if (IS_ENABLED(CONFIG_CPU_BIG_ENDIAN)) {
+ mt76_mmio_write_copy_portable(dev->mmio.regs + offset, data,
+ len);
+ return;
+ }
__iowrite32_copy(dev->mmio.regs + offset, data, DIV_ROUND_UP(len, 4));
}
+static void mt76_mmio_read_copy_portable(u8 *dst,
+ const void __iomem *src, int len)
+{
+ u32 val;
+ int i;
+
+ for (i = 0; i < ALIGN(len, 4); i += 4) {
+ val = le32_to_cpu(readl(src + i));
+ memcpy(dst + i, &val, sizeof(val));
+ }
+}
+
static void mt76_mmio_read_copy(struct mt76_dev *dev, u32 offset,
void *data, int len)
{
+ if (IS_ENABLED(CONFIG_CPU_BIG_ENDIAN)) {
+ mt76_mmio_read_copy_portable(data, dev->mmio.regs + offset,
+ len);
+ return;
+ }
__ioread32_copy(data, dev->mmio.regs + offset, DIV_ROUND_UP(len, 4));
}
--
2.39.5
next reply other threads:[~2025-10-27 17:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 17:17 Caleb James DeLisle [this message]
2025-10-28 20:19 ` Jonas Gorski
2025-10-28 21:41 ` Caleb James DeLisle
2025-10-29 9:15 ` Jonas Gorski
2025-10-29 15:24 ` Caleb James DeLisle
2025-10-29 18:41 ` [PATCH v2] wifi: mt76: mmio_*_copy fix byte order and alignment Caleb James DeLisle
2025-10-29 20:12 ` [PATCH] wifi: mt76: mmio_(read|write)_copy byte swap when on Big Endian Jonas Gorski
2025-10-29 20:40 ` Caleb James DeLisle
2025-10-29 23:06 ` Caleb James DeLisle
2025-10-31 1:18 ` kernel test robot
2025-10-31 8:22 ` Caleb James DeLisle
2025-11-01 16:25 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251027171759.1484844-1-cjd@cjdns.fr \
--to=cjd@cjdns.fr \
--cc=angelogioacchino.delregno@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=shayne.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®