From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4EB72C0F69 for ; Mon, 27 Oct 2025 23:36:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761608194; cv=none; b=GL83hcoEUM7aIRLn/w47VODv95HOnNWF9bIpnLiHdOZ0R859pRODqv4Ah8QfwTWzgyClVOUkaHuSmHpzvba8qTSG0Id0cs5gNDokKjGIh+tEvCfBbRUsXjtmHNfk+G9ONWR0ASvuX7trJh7k689hcW4+yo4X7hnKeFvbiR1Ffu8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761608194; c=relaxed/simple; bh=qvWAYMr9N/DUBOKfCCTkn13ib5iwybEXtVQwmQA/Lb0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rhiCc3b1TtJB3aObZxImYhFXrvCHdIe9NM6kq3/g/DB6ptKFO7qZ8MrNdFng1T06c2WzLFMKH8ZhbgJDMMZMkipL9YBvK4dsE7YOFraqSJTwDzqxPHQSIt0NHEh6QiFsxTHgoqumHGKPZDR92F8hLIFccPbLwGvJREMxsWN8hf0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=anAEdHVg; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="anAEdHVg" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-b6d676a512eso90436866b.2 for ; Mon, 27 Oct 2025 16:36:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761608190; x=1762212990; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tsJ+yBdg7GO/yeuRN4xr8Rgswci3SrqwbYTUaP0sSpI=; b=anAEdHVgVkwjMttgKJ/nMkINi7cnTnjt+yV9m8gXdqgvE4lC918prkyfh77SKJ9RMv 2wQg3tMhTgh6EPLWpsKTvb7qrB+qPB17tnp622VCQUgYXC5uqzasM601oY9zaXl11ioi RVoqXMaqzcfw6UR0oS23vDRhlTSDs0QgSQDwmOw54KlFD7CMLJf0x/l02ow/O8OhEoNo ZeM5pcNU77xPLPq09ttqjzBEdgzigrbT2Y+IadN5i3Oxj65QwmOfqeGNHZG7GDCPi47p Hn4abvJnYYW13UWoN4qu0jJ9wxJUNXZ6Bosw7IfRS210IyjV26Hn44AZFUnHA6f1GT1Q YN7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761608190; x=1762212990; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tsJ+yBdg7GO/yeuRN4xr8Rgswci3SrqwbYTUaP0sSpI=; b=Y4BTPpwNYzFlXkZaNNDkFW32lkVE9MCIi6Yoox/vHhVLrjlU2Ooz9Lds9U6DUkTJNy 4+eC8J7aZGhqt2CBOVFZ8wTiSTpUPxQNo/XP/miayiHKM7NOyjabgNai9GXUQwRwi8+D MeVNV2hAwQuKswblgHsoYALOYkrV2sWD6fvEjUIiVpGkqh+EtPjEhO1Ew4EuwMNMQcQH DLgtkkNI26RoK/sCcIBFSjV6KIa8oAYxTPmojCnosmWA8N2Q5JJeC2xA6gWqz16nWr8p zR3A/LF+ySHntZp2tZDxLWRNha7NSFcPFgJ2p1tfOpLRrNNNgtYcksjily+M292xw60U bdWQ== X-Forwarded-Encrypted: i=1; AJvYcCU+fhittOysAKTn+9R2G/YtwAf4U5Hd3wwnJccfqVEXS0jpIHP1cexLrEEmdFGvpLXfAwi1kn8AfWt9PaU=@vger.kernel.org X-Gm-Message-State: AOJu0Yys2xwusq1V1zBEscEuXXE4mLLYWbR/+Gu5hkp6uHOb3Xz2ytqY fu82PjuBq0yr+3ZnGKmpzXasn1ZJxfmxMMC/joM7nMvg4WXcOQWb+a+v X-Gm-Gg: ASbGnctDgGZdc3ADw8OarCZuBGporYPgKhdAjMkbSxB4FsXtfWzIFhUEM3gfw2fcXd0 /PcllGLaB+OUetRkQONftVkqtKeB+Pl3D/KerJ+ccDvlQt4P1j0EyYIEIEhNNld2x1bBoeJIqD+ FgjiWEsrpmNf0uoUYvsgl0TIYHz9kmQT/AJPCk7QHZsaOQW0cEZRM+hWy0yryIbJDl1qxODTq5m FNBfXL/AEYpKYHiBrwaqCkRHlNuGnZIeZ6qTIzB0Wq0ycuVVOGKt1L+7xGW0vc1IO0QZdWRvBIT 2NgY/wZ45g818gr2nHp1tZI9YhPi8I1OR4JTkRsZiB9Of5smgXFGSst/1tNJGbY1pFW3FsTemN/ pT1ESAOySRp7AhVaw06Ou+Vp03Pt2Bq2lenEmilA6pnW+h0Lfoji0RYA5LprnkLlD02+zmXHY/2 z+ZR8= X-Google-Smtp-Source: AGHT+IFg/lCVtyz/HzS52kOUjJMQdUG7JrftCeugpNASZSGw37VW8nbfhJkVrtxD6rfrgOJBaoHF/w== X-Received: by 2002:a17:907:980b:b0:b6a:382a:1516 with SMTP id a640c23a62f3a-b6dba55aee5mr92721866b.5.1761608189883; Mon, 27 Oct 2025 16:36:29 -0700 (PDT) Received: from skbuf ([2a02:2f04:d406:ee00:3eb9:f316:6516:8b90]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b6d85398439sm902573366b.36.2025.10.27.16.36.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 16:36:29 -0700 (PDT) Date: Tue, 28 Oct 2025 01:36:26 +0200 From: Vladimir Oltean To: Daniel Golle Cc: Hauke Mehrtens , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Simon Horman , Russell King , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Andreas Schirm , Lukas Stockmann , Alexander Sverdlin , Peter Christen , Avinash Jayaraman , Bing tao Xu , Liang Xu , Juraj Povazanec , "Fanni (Fang-Yi) Chan" , "Benny (Ying-Tsan) Weng" , "Livia M. Rosu" , John Crispin Subject: Re: [PATCH net-next v3 09/12] net: dsa: lantiq_gswip: add vendor property to setup MII refclk output Message-ID: <20251027233626.d6vzb45gwcfvvorh@skbuf> References: <869f4ea37de1c54b35eb92f1b8c55a022d125bd3.1761521845.git.daniel@makrotopia.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <869f4ea37de1c54b35eb92f1b8c55a022d125bd3.1761521845.git.daniel@makrotopia.org> On Sun, Oct 26, 2025 at 11:47:21PM +0000, Daniel Golle wrote: > Read boolean Device Tree property "maxlinear,rmii-refclk-out" and switch > the RMII reference clock to be a clock output rather than an input if it > is set. > > Signed-off-by: Daniel Golle > --- > drivers/net/dsa/lantiq/lantiq_gswip_common.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/dsa/lantiq/lantiq_gswip_common.c b/drivers/net/dsa/lantiq/lantiq_gswip_common.c > index 60a83093cd10..bf38ecc13f76 100644 > --- a/drivers/net/dsa/lantiq/lantiq_gswip_common.c > +++ b/drivers/net/dsa/lantiq/lantiq_gswip_common.c > @@ -1442,6 +1442,10 @@ static void gswip_phylink_mac_config(struct phylink_config *config, > return; > } > > + if (of_property_read_bool(dp->dn, "maxlinear,rmii-refclk-out") && > + !(miicfg & GSWIP_MII_CFG_MODE_RGMII)) > + miicfg |= GSWIP_MII_CFG_RMII_CLK; > + What did you mean with the !(miicfg & GSWIP_MII_CFG_MODE_RGMII) test? If the schema says "Only applicable for RMII mode.", what's the purpose of this extra condition? For example, GSWIP_MII_CFG_MODE_GMII also has the "GSWIP_MII_CFG_MODE_RGMII" bit (0x4) unset. Does this have any significance? > gswip_mii_mask_cfg(priv, > GSWIP_MII_CFG_MODE_MASK | GSWIP_MII_CFG_RMII_CLK | > GSWIP_MII_CFG_RGMII_IBS | GSWIP_MII_CFG_LDCLKDIS, > -- > 2.51.1