From: Troy Mitchell <troy.mitchell@linux.spacemit.com>
To: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Yixun Lan <dlan@gentoo.org>,
Jinmei Wei <weijinmei@linux.spacemit.com>
Cc: linux-sound@vger.kernel.org, linux-riscv@lists.infradead.org,
spacemit@lists.linux.dev, linux-kernel@vger.kernel.org,
Troy Mitchell <troy.mitchell@linux.spacemit.com>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: [PATCH v2 2/2] ASoC: spacemit: use `depends on` instead of `select`
Date: Tue, 28 Oct 2025 09:32:10 +0800 [thread overview]
Message-ID: <20251028-fix-k1-i2s-v2-2-a547c15ed5c3@linux.spacemit.com> (raw)
In-Reply-To: <20251028-fix-k1-i2s-v2-0-a547c15ed5c3@linux.spacemit.com>
Selecting DMA_CMA directly bypasses its dependency chain.
This can cause build warnings or errors if the required
dependencies are not enabled.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Closes: https://lore.kernel.org/all/20251022141705.714b19b5@canb.auug.org.au/
Fixes: fce217449075 ("ASoC: spacemit: add i2s support for K1 SoC")
Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
---
Changelog in v2:
- this patch is introduced in v2
---
sound/soc/spacemit/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/sound/soc/spacemit/Kconfig b/sound/soc/spacemit/Kconfig
index 2179f94f3f179c54cd06e6ced5523ed3f5225cf4..e11f600a327f58681ce46df6e0e7a70f5f1d1234 100644
--- a/sound/soc/spacemit/Kconfig
+++ b/sound/soc/spacemit/Kconfig
@@ -6,8 +6,7 @@ menu "SpacemiT"
config SND_SOC_K1_I2S
tristate "K1 I2S Device Driver"
select SND_SOC_GENERIC_DMAENGINE_PCM
- select CMA
- select DMA_CMA
+ depends on DMA_CMA
help
Say Y or M if you want to add support for I2S driver for
K1 I2S controller. The device supports up to maximum of
--
2.51.1
next prev parent reply other threads:[~2025-10-28 1:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 1:32 [PATCH v2 0/2] ASoC: spacemit: fix build warning and error Troy Mitchell
2025-10-28 1:32 ` [PATCH v2 1/2] ASoC: spacemit: add failure check for spacemit_i2s_init_dai() Troy Mitchell
2025-10-28 1:32 ` Troy Mitchell [this message]
2025-10-28 14:27 ` [PATCH v2 0/2] ASoC: spacemit: fix build warning and error Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251028-fix-k1-i2s-v2-2-a547c15ed5c3@linux.spacemit.com \
--to=troy.mitchell@linux.spacemit.com \
--cc=broonie@kernel.org \
--cc=dlan@gentoo.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sfr@canb.auug.org.au \
--cc=spacemit@lists.linux.dev \
--cc=tiwai@suse.com \
--cc=weijinmei@linux.spacemit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®