mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [PATCH] perf/x86: Add cond_resched() when allocate/release DS buffers
Date: Tue, 28 Oct 2025 20:04:22 +0100	[thread overview]
Message-ID: <20251028190422.GE3419281@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <aQETYiqpEo5IcTXN@google.com>

On Tue, Oct 28, 2025 at 12:02:58PM -0700, Namhyung Kim wrote:
> Hi Peter,
> 
> On Tue, Oct 28, 2025 at 04:27:47PM +0100, Peter Zijlstra wrote:
> > On Tue, Oct 28, 2025 at 03:15:18PM +0100, Peter Zijlstra wrote:
> > > On Mon, Oct 27, 2025 at 02:27:24PM -0700, Namhyung Kim wrote:
> > > > On large systems, it's possible to trigger sched latency warning during
> > > > the DS buffer allocation or release.  Add cond_resched() to avoid it.
> > > 
> > > We're >.< close to deleting cond_resched(), it makes absolutely no sense
> > > adding more.
> > 
> > Specifically, IIRC the plan was to do something like the below after the
> > next LTS release, and then continue to remove VOLUNTARY in subsequent
> > releases, leaving NONE the only option for the legacy architectures that
> > do not support preemption.
> 
> Thanks for your review!
> 
> I haven't followed the work in this area so was not aware of the
> PREEMPT_LAZY.  Looks great!  I hope it'll work well on server platforms
> with many batch jobs and interactive tasks.
> 
> I will drop my patch then.

Well, we've been trying to get people to test things... But
realistically people will only test once you force them. So we'll see.

  reply	other threads:[~2025-10-28 19:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-27 21:27 Namhyung Kim
2025-10-28 14:15 ` Peter Zijlstra
2025-10-28 15:27   ` Peter Zijlstra
2025-10-28 19:02     ` Namhyung Kim
2025-10-28 19:04       ` Peter Zijlstra [this message]
2025-10-28 20:13         ` Sebastian Andrzej Siewior
2025-10-29  9:07           ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251028190422.GE3419281@noisy.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=bigeasy@linutronix.de \
    --cc=edumazet@google.com \
    --cc=irogers@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®