From: Horatiu Vultur <horatiu.vultur@microchip.com>
To: <andrew@lunn.ch>, <hkallweit1@gmail.com>, <linux@armlinux.org.uk>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Horatiu Vultur <horatiu.vultur@microchip.com>
Subject: [PATCH net v2 2/2] net: phy: micrel: lan8842 errata
Date: Wed, 29 Oct 2025 08:24:56 +0100 [thread overview]
Message-ID: <20251029072456.392969-3-horatiu.vultur@microchip.com> (raw)
In-Reply-To: <20251029072456.392969-1-horatiu.vultur@microchip.com>
Add errata for lan8842. The errata document can be found here [1].
This is fixing the module 7 ("1000BASE-T PMA EEE TX wake PHY-side shorted
center taps")
[1] https://ww1.microchip.com/downloads/aemDocuments/documents/UNG/ProductDocuments/Errata/LAN8842-Errata-DS80001172.pdf
Fixes: 5a774b64cd6a ("net: phy: micrel: Add support for lan8842")
Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
---
drivers/net/phy/micrel.c | 23 ++++++++++++++++++++---
1 file changed, 20 insertions(+), 3 deletions(-)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 4b526587093c6..d063e77f07f81 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -2835,6 +2835,13 @@ static int ksz886x_cable_test_get_status(struct phy_device *phydev,
*/
#define LAN8814_PAGE_PCS_DIGITAL 2
+/**
+ * LAN8814_PAGE_EEE - Selects Extended Page 3.
+ *
+ * This page contains EEE registers
+ */
+#define LAN8814_PAGE_EEE 3
+
/**
* LAN8814_PAGE_COMMON_REGS - Selects Extended Page 4.
*
@@ -5952,6 +5959,9 @@ static int lan8842_probe(struct phy_device *phydev)
#define LAN8814_POWER_MGMT_VAL5 LAN8814_POWER_MGMT_B_C_D
+#define LAN8814_EEE_WAKE_TX_TIMER 0x0e
+#define LAN8814_EEE_WAKE_TX_TIMER_MAX_VAL 0x1f
+
static int lan8842_erratas(struct phy_device *phydev)
{
int ret;
@@ -6023,9 +6033,16 @@ static int lan8842_erratas(struct phy_device *phydev)
if (ret < 0)
return ret;
- return lanphy_write_page_reg(phydev, LAN8814_PAGE_POWER_REGS,
- LAN8814_POWER_MGMT_MODE_14_100BTX_EEE_TX_RX,
- LAN8814_POWER_MGMT_VAL4);
+ ret = lanphy_write_page_reg(phydev, LAN8814_PAGE_POWER_REGS,
+ LAN8814_POWER_MGMT_MODE_14_100BTX_EEE_TX_RX,
+ LAN8814_POWER_MGMT_VAL4);
+ if (ret < 0)
+ return ret;
+
+ /* Refresh time Waketx timer */
+ return lanphy_write_page_reg(phydev, LAN8814_PAGE_EEE,
+ LAN8814_EEE_WAKE_TX_TIMER,
+ LAN8814_EEE_WAKE_TX_TIMER_MAX_VAL);
}
static int lan8842_config_init(struct phy_device *phydev)
--
2.34.1
next prev parent reply other threads:[~2025-10-29 7:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 7:24 [PATCH net v2 0/2] net: phy: micrel: lan8842 erratas Horatiu Vultur
2025-10-29 7:24 ` [PATCH net v2 1/2] net: phy: micrel: lan8842 errata Horatiu Vultur
2025-10-29 18:39 ` Andrew Lunn
2025-10-29 7:24 ` Horatiu Vultur [this message]
2025-10-29 18:40 ` [PATCH net v2 2/2] " Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251029072456.392969-3-horatiu.vultur@microchip.com \
--to=horatiu.vultur@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®