mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Menglong Dong <menglong8.dong@gmail.com>
Cc: mhiramat@kernel.org, jolsa@kernel.org,
	mathieu.desnoyers@efficios.com, jiang.biao@linux.dev,
	linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing: fprobe: use ftrace if CONFIG_DYNAMIC_FTRACE_WITH_ARGS
Date: Wed, 29 Oct 2025 10:23:04 -0400	[thread overview]
Message-ID: <20251029102304.2db99b7d@gandalf.local.home> (raw)
In-Reply-To: <CADxym3YcR+WYjRv-0+SOiE1yoO85FaqffCF2XbLZ9H7+qHet6w@mail.gmail.com>

On Wed, 29 Oct 2025 22:09:40 +0800
Menglong Dong <menglong8.dong@gmail.com> wrote:

> Hi, it won't fail here, as FTRACE_OPS_FL_SAVE_ARGS has
> following definition:
> 
> #ifndef CONFIG_DYNAMIC_FTRACE_WITH_ARGS
> #define FTRACE_OPS_FL_SAVE_ARGS                        FTRACE_OPS_FL_SAVE_REGS
> #else
> #define FTRACE_OPS_FL_SAVE_ARGS                        0
> #endif

Bah, I should have known that, as I think I requested it :-p

[ chalks this up for a senior moment! ]


> 
> Which means it will fallback to FTRACE_OPS_FL_SAVE_REGS if
> CONFIG_DYNAMIC_FTRACE_WITH_ARGS not defined.
> 
> I have commit a PR to the bpf CI, and all testings passed and no
> building error happens:
>   https://github.com/kernel-patches/bpf/pull/10110

OK, thanks,

-- Steve


  reply	other threads:[~2025-10-29 14:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-29  2:15 Menglong Dong
2025-10-29 14:00 ` Steven Rostedt
2025-10-29 14:09   ` Menglong Dong
2025-10-29 14:23     ` Steven Rostedt [this message]
2025-10-30  0:40 ` Masami Hiramatsu
2025-10-30  2:43   ` Menglong Dong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251029102304.2db99b7d@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=jiang.biao@linux.dev \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=menglong8.dong@gmail.com \
    --cc=mhiramat@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®