Re: [PATCH net-next] net: phy: nxp-c45-tja11xx: config_init restore macsec config

[kernel test robot <lkp@intel.com>]

Hi Andrei,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Andrei-Botila/net-phy-nxp-c45-tja11xx-config_init-restore-macsec-config/20251029-185313
base:   net-next/main
patch link:    https://lore.kernel.org/r/20251029104258.1499069-1-andrei.botila%40oss.nxp.com
patch subject: [PATCH net-next] net: phy: nxp-c45-tja11xx: config_init restore macsec config
config: x86_64-randconfig-076-20251030 (https://download.01.org/0day-ci/archive/20251030/202510301246.x4ua5CJ6-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251030/202510301246.x4ua5CJ6-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202510301246.x4ua5CJ6-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from drivers/net/phy/nxp-c45-tja11xx.c:20:
>> drivers/net/phy/nxp-c45-tja11xx.h:42:6: warning: no previous prototype for function 'nxp_c45_macsec_link_change_notify' [-Wmissing-prototypes]
      42 | void nxp_c45_macsec_link_change_notify(struct phy_device *phydev)
         |      ^
   drivers/net/phy/nxp-c45-tja11xx.h:42:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
      42 | void nxp_c45_macsec_link_change_notify(struct phy_device *phydev)
         | ^
         | static 
   1 warning generated.


vim +/nxp_c45_macsec_link_change_notify +42 drivers/net/phy/nxp-c45-tja11xx.h

    33	
    34	#if IS_ENABLED(CONFIG_MACSEC)
    35	void nxp_c45_macsec_link_change_notify(struct phy_device *phydev);
    36	int nxp_c45_macsec_config_init(struct phy_device *phydev);
    37	int nxp_c45_macsec_probe(struct phy_device *phydev);
    38	void nxp_c45_macsec_remove(struct phy_device *phydev);
    39	void nxp_c45_handle_macsec_interrupt(struct phy_device *phydev,
    40					     irqreturn_t *ret);
    41	#else
  > 42	void nxp_c45_macsec_link_change_notify(struct phy_device *phydev)
    43	{
    44	}
    45	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki