From: Liu Ying <victor.liu@nxp.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
Liu Ying <victor.liu@nxp.com>
Subject: [PATCH 0/2] drm/atomic-helper: Support atomic flush with an optional kthread worker
Date: Fri, 31 Oct 2025 18:21:23 +0800 [thread overview]
Message-ID: <20251031-drm-crtc-flush-worker-v1-0-9edc94da0fb7@nxp.com> (raw)
Hi,
As drm_atomic_helper_commit_planes() calls atomic_flush for CRTCs
sequentially and a driver's atomic_flush callback could be blocking,
the performance for flushing multiple CRTCs in a single atomic commit
could be low, like page flip for multiple CRTCs. A real case is imx8-dc,
which supports two CRTCs and does atomic_flush in a blocking way, i.e.,
waits for a done event for loading shadow registers.
To resolve that, introduce an optional kthread worker to conduct
flush in drm_atomic_helper_commit_planes(), so that flush can run in
parallel for multiple CRTCs.
Drivers should call drmm_crtc_flush_worker_init() to initialize the
kthread worker if they want to use it.
Patch 1 adds the optional kthread worker support.
Patch 2 makes imx8-dc use the kthread worker.
Let me know your thoughts. Thanks.
Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
Liu Ying (2):
drm/atomic-helper: Support atomic flush with an optional kthread worker
drm/imx: dc-crtc: Use flush worker
drivers/gpu/drm/drm_atomic_helper.c | 27 ++++++++++++++++-
drivers/gpu/drm/drm_crtc.c | 59 +++++++++++++++++++++++++++++++++++++
drivers/gpu/drm/imx/dc/dc-crtc.c | 9 +++++-
include/drm/drm_crtc.h | 45 ++++++++++++++++++++++++++++
4 files changed, 138 insertions(+), 2 deletions(-)
---
base-commit: dcb6fa37fd7bc9c3d2b066329b0d27dedf8becaa
change-id: 20251031-drm-crtc-flush-worker-0aac27acf40f
Best regards,
--
Liu Ying <victor.liu@nxp.com>
next reply other threads:[~2025-10-31 10:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 10:21 Liu Ying [this message]
2025-10-31 10:21 ` [PATCH 1/2] " Liu Ying
2025-10-31 10:21 ` [PATCH 2/2] drm/imx: dc-crtc: Use flush worker Liu Ying
2025-12-08 7:38 ` [PATCH 0/2] drm/atomic-helper: Support atomic flush with an optional kthread worker Liu Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251031-drm-crtc-flush-worker-v1-0-9edc94da0fb7@nxp.com \
--to=victor.liu@nxp.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®