From: Hugo Villeneuve <hugo@hugovil.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: biju.das.au <biju.das.au@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
wsa+renesas <wsa+renesas@sang-engineering.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v2 03/13] serial: sh-sci: Drop extra lines
Date: Fri, 31 Oct 2025 10:34:20 -0400 [thread overview]
Message-ID: <20251031103420.e02c11d51e6f8e8871d22b96@hugovil.com> (raw)
In-Reply-To: <TY3PR01MB11346985328E37A14287CB3B986F8A@TY3PR01MB11346.jpnprd01.prod.outlook.com>
On Fri, 31 Oct 2025 07:08:24 +0000
Biju Das <biju.das.jz@bp.renesas.com> wrote:
>
>
> > -----Original Message-----
> > From: Biju Das
> > Sent: 31 October 2025 07:07
> > To: 'Hugo Villeneuve' <hugo@hugovil.com>; biju.das.au <biju.das.au@gmail.com>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Jiri Slaby <jirislaby@kernel.org>; wsa+renesas
> > <wsa+renesas@sang-engineering.com>; Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>;
> > Geert Uytterhoeven <geert+renesas@glider.be>; linux-kernel@vger.kernel.org; linux-
> > serial@vger.kernel.org; linux-renesas-soc@vger.kernel.org
> > Subject: RE: [PATCH v2 03/13] serial: sh-sci: Drop extra lines
> >
> > Hi Hugo,
> >
> > > -----Original Message-----
> > > From: Hugo Villeneuve <hugo@hugovil.com>
> > > Sent: 30 October 2025 20:22
> > > Subject: Re: [PATCH v2 03/13] serial: sh-sci: Drop extra lines
> > >
> > > Hi Biju,
> > >
> > > On Thu, 30 Oct 2025 17:57:51 +0000
> > > Biju <biju.das.au@gmail.com> wrote:
> > >
> > > > From: Biju Das <biju.das.jz@bp.renesas.com>
> > > >
> > > > Shorten the number lines in sci_init_clocks() by fitting the error
> > > > messages within an 100-character length limit.
> > > >
> > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > > > ---
> > > > v1->v2:
> > > > * Updated commit message 80-character->100-character.
> > > > * Increased line limit for error messages to 100-column limit.
> > > > ---
> > > > drivers/tty/serial/sh-sci.c | 13 ++++---------
> > > > 1 file changed, 4 insertions(+), 9 deletions(-)
> > > >
> > > > diff --git a/drivers/tty/serial/sh-sci.c
> > > > b/drivers/tty/serial/sh-sci.c index b33894d0273b..e9345f898224
> > > > 100644
> > > > --- a/drivers/tty/serial/sh-sci.c
> > > > +++ b/drivers/tty/serial/sh-sci.c
> > > > @@ -3008,11 +3008,8 @@ static int sci_init_clocks(struct sci_port *sci_port, struct device *dev)
> > > > return PTR_ERR(clk);
> > > >
> > > > if (!clk && sci_port->type == SCI_PORT_RSCI &&
> > > > - (i == SCI_FCK || i == SCI_BRG_INT)) {
> > > > - return dev_err_probe(dev, -ENODEV,
> > > > - "failed to get %s\n",
> > > > - name);
> > > > - }
> > > > + (i == SCI_FCK || i == SCI_BRG_INT))
> > > > + return dev_err_probe(dev, -ENODEV, "failed to get %s\n", name);
> > > >
> > > > if (!clk && i == SCI_FCK) {
> > > > /*
> > > > @@ -3022,16 +3019,14 @@ static int sci_init_clocks(struct sci_port *sci_port, struct device *dev)
> > > > */
> > > > clk = devm_clk_get(dev, "peripheral_clk");
> > > > if (IS_ERR(clk))
> > > > - return dev_err_probe(dev, PTR_ERR(clk),
> > > > - "failed to get %s\n",
> > > > + return dev_err_probe(dev, PTR_ERR(clk), "failed to get %s\n",
> > > > name);
> > >
> > > This one can also be on one line (99 characters).
> >
> > It is 101 characters.
>
> Sorry, 100 Characters. Let me run checkpatch to see, it generates warning.
Hi Biju,
I already did before replying, it was fine.
Hugo.
next prev parent reply other threads:[~2025-10-31 14:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 17:57 [PATCH v2 00/13] Add RZ/G3E RSCI support Biju
2025-10-30 17:57 ` [PATCH v2 01/13] dt-bindings: serial: renesas,rsci: Document RZ/G3E support Biju
2025-10-30 19:20 ` Conor Dooley
2025-10-30 17:57 ` [PATCH v2 02/13] serial: rsci: Drop rsci_clear_CFC() Biju
2025-10-30 17:57 ` [PATCH v2 03/13] serial: sh-sci: Drop extra lines Biju
2025-10-30 20:21 ` Hugo Villeneuve
2025-10-31 7:06 ` Biju Das
2025-10-31 7:08 ` Biju Das
2025-10-31 14:34 ` Hugo Villeneuve [this message]
2025-10-30 17:57 ` [PATCH v2 04/13] serial: rsci: Drop unused macro DCR Biju
2025-10-30 17:57 ` [PATCH v2 05/13] serial: rsci: Drop unused TDR register Biju
2025-10-30 17:57 ` [PATCH v2 06/13] serial: sh-sci: Use devm_reset_control_array_get_exclusive() Biju
2025-10-30 17:57 ` [PATCH v2 07/13] serial: sh-sci: Add RSCI_PORT_{SCI,SCIF} port IDs Biju
2025-10-30 17:57 ` [PATCH v2 08/13] serial: sh-sci: Add sci_is_rsci_type() Biju
2025-10-30 17:57 ` [PATCH v2 09/13] serial: sh-sci: Add support for RZ/G3E RSCI clks Biju
2025-10-30 17:57 ` [PATCH v2 10/13] serial: sh-sci: Make sci_scbrr_calc() public Biju
2025-10-30 17:57 ` [PATCH v2 11/13] serial: sh-sci: Add finish_console_write() callback Biju
2025-10-30 17:58 ` [PATCH v2 12/13] serial: sh-sci: Add support for RZ/G3E RSCI SCIF Biju
2025-10-31 4:50 ` Jiri Slaby
2025-10-31 7:16 ` Biju Das
2025-10-30 17:58 ` [PATCH v2 13/13] serial: sh-sci: Add support for RZ/G3E RSCI SCI Biju
-- strict thread matches above, loose matches on Subject: below --
2025-10-30 17:55 [PATCH v2 00/13] Add RZ/G3E RSCI support Biju
2025-10-30 17:55 ` [PATCH v2 03/13] serial: sh-sci: Drop extra lines Biju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251031103420.e02c11d51e6f8e8871d22b96@hugovil.com \
--to=hugo@hugovil.com \
--cc=biju.das.au@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®