From: vsshingne <vaibhavshingne66@gmail.com>
To: skhan@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
vsshingne <vaibhavshingne66@gmail.com>
Subject: [PATCH] usb: core: prevent double URB enqueue leading to corruption
Date: Fri, 31 Oct 2025 18:56:51 +0530 [thread overview]
Message-ID: <20251031132651.219859-1-vaibhavshingne66@gmail.com> (raw)
Signed-off-by: vsshingne <vaibhavshingne66@gmail.com>
---
drivers/usb/core/hcd.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index 87fcb78c34a8..66861f372daf 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -1758,16 +1758,15 @@ void usb_hcd_giveback_urb(struct usb_hcd *hcd, struct urb *urb, int status)
pr_warn("usb: URB already linked to bh->head, skipping duplicate addition\n");
return;
}
-
list_add_tail(&urb->urb_list, &bh->head);
running = bh->running;
spin_unlock(&bh->lock);
if (!running) {
- if (bh->high_prio)
- queue_work(system_bh_highpri_wq, &bh->bh);
- else
- queue_work(system_bh_wq, &bh->bh);
+ if (bh->high_prio)
+ queue_work(system_bh_highpri_wq, &bh->bh);
+ else
+ queue_work(system_bh_wq, &bh->bh);
}
}
EXPORT_SYMBOL_GPL(usb_hcd_giveback_urb);
--
2.48.1
next reply other threads:[~2025-10-31 13:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 13:26 vsshingne [this message]
2025-10-31 13:38 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251031132651.219859-1-vaibhavshingne66@gmail.com \
--to=vaibhavshingne66@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®