mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shivendra Pratap <shivendra.pratap@oss.qualcomm.com>
To: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Unnathi Chalicheemala <unnathi.chalicheemala@oss.qualcomm.com>,
	Shivendra Pratap <shivendra.pratap@oss.qualcomm.com>
Subject: [PATCH v8 3/3] firmware: qcom_scm: Check for waitq state in wait_for_wq_completion()
Date: Sun, 02 Nov 2025 13:48:47 +0530	[thread overview]
Message-ID: <20251102-multi_waitq_scm-v8-3-d71ee7b93b62@oss.qualcomm.com> (raw)
In-Reply-To: <20251102-multi_waitq_scm-v8-0-d71ee7b93b62@oss.qualcomm.com>

From: Unnathi Chalicheemala <unnathi.chalicheemala@oss.qualcomm.com>

Modify wait_for_wq_completion() to check if task is in idle state using
wait_for_completion_state().

This allows for detecting when waitq contexts are in idle state and
propagates it to __scm_smc_do(), which is beneficial when task is idle
and waiting for a kick to accept new requests.

Signed-off-by: Unnathi Chalicheemala <unnathi.chalicheemala@oss.qualcomm.com>
Signed-off-by: Shivendra Pratap <shivendra.pratap@oss.qualcomm.com>
---
 drivers/firmware/qcom/qcom_scm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c
index 0b6efa7c2bdc25a3ba152c25d5451d1154779ddd..38c1c8aff9fa3a90eca9dba700611dd12c4d82a5 100644
--- a/drivers/firmware/qcom/qcom_scm.c
+++ b/drivers/firmware/qcom/qcom_scm.c
@@ -2320,7 +2320,7 @@ int qcom_scm_wait_for_wq_completion(u32 wq_ctx)
 	if (IS_ERR(wq))
 		return PTR_ERR(wq);
 
-	wait_for_completion(wq);
+	wait_for_completion_state(wq, TASK_IDLE);
 
 	return 0;
 }

-- 
2.34.1


  parent reply	other threads:[~2025-11-02  8:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-02  8:18 [PATCH v8 0/3] SCM: Support latest version of waitq-aware firmware Shivendra Pratap
2025-11-02  8:18 ` [PATCH v8 1/3] firmware: qcom_scm: Add API to get waitqueue IRQ info Shivendra Pratap
2025-11-02  8:18 ` [PATCH v8 2/3] firmware: qcom_scm: Support multiple waitq contexts Shivendra Pratap
2025-11-03 15:46   ` Bartosz Golaszewski
2025-11-03 16:16     ` Shivendra Pratap
2025-11-03 16:59       ` Bartosz Golaszewski
2025-11-03 17:05         ` Shivendra Pratap
2025-11-02  8:18 ` Shivendra Pratap [this message]
2025-11-03 15:51   ` [PATCH v8 3/3] firmware: qcom_scm: Check for waitq state in wait_for_wq_completion() Bartosz Golaszewski
2025-11-17 18:13     ` Shivendra Pratap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251102-multi_waitq_scm-v8-3-d71ee7b93b62@oss.qualcomm.com \
    --to=shivendra.pratap@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=unnathi.chalicheemala@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®