From: Jonas Gorski <jonas.gorski@gmail.com>
To: Florian Fainelli <florian.fainelli@broadcom.com>,
Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Vivien Didelot <vivien.didelot@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net 0/3] net: dsa: b53: minor fdb related fixes
Date: Sun, 2 Nov 2025 11:07:55 +0100 [thread overview]
Message-ID: <20251102100758.28352-1-jonas.gorski@gmail.com> (raw)
While investigating and fixing/implenting proper ARL support for
bcm63xx, I encountered multiple minor issues in the current ARL
implementation:
* The ARL multicast support was not properly enabled for older chips,
and instead a potentially reserved bit was toggled.
* While traversing the ARL table, "Search done" triggered one final
entry which will be invalid for 4 ARL bin chips, and failed to stop
the search on chips with only one result register.
* For chips where we have only one result register, we only traversed at
most half the maximum entries.
I also had a fix for IVL_SVL_SELECT which is only valid for some chips,
but since this would only have an effect for !vlan_enabled, and we
always have that enabled, it isn't really worth fixing (and rather drop
the !vlan_enabled paths).
Jonas Gorski (3):
net: dsa: b53: fix enabling ip multicast
net: dsa: b53: stop reading ARL entries if search is done
net: dsa: b53: properly bound ARL searches for < 4 ARL bin chips
drivers/net/dsa/b53/b53_common.c | 15 +++++++++------
drivers/net/dsa/b53/b53_regs.h | 3 +--
2 files changed, 10 insertions(+), 8 deletions(-)
base-commit: d7d2fcf7ae31471b4e08b7e448b8fd0ec2e06a1b
--
2.43.0
next reply other threads:[~2025-11-02 10:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-02 10:07 Jonas Gorski [this message]
2025-11-02 10:07 ` [PATCH net 1/3] net: dsa: b53: fix enabling ip multicast Jonas Gorski
2025-11-02 16:53 ` Florian Fainelli
2025-11-02 10:07 ` [PATCH net 2/3] net: dsa: b53: stop reading ARL entries if search is done Jonas Gorski
2025-11-02 16:15 ` Florian Fainelli
2025-11-02 10:07 ` [PATCH net 3/3] net: dsa: b53: properly bound ARL searches for < 4 ARL bin chips Jonas Gorski
2025-11-02 16:18 ` Florian Fainelli
2025-11-04 1:10 ` [PATCH net 0/3] net: dsa: b53: minor fdb related fixes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251102100758.28352-1-jonas.gorski@gmail.com \
--to=jonas.gorski@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®