From: Borislav Petkov <bp@alien8.de>
To: Marc Herbert <marc.herbert@linux.intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/msr: add CPU_OUT_OF_SPEC taint name to "unrecognized" pr_warn(msg)
Date: Sun, 2 Nov 2025 13:09:22 +0100 [thread overview]
Message-ID: <20251102120922.GAaQdJ8noSCgyoTE2F@fat_crate.local> (raw)
In-Reply-To: <m2bjll15q8.fsf@kvalverd-mobl1.amr.corp.intel.com>
Hi,
On Sat, Nov 01, 2025 at 08:19:27PM -0700, Marc Herbert wrote:
> I just struggled to make sense of some unrelated crash logs and that's
> really all from my point of view. I mean all for now at least.
There's the answer to my question! :-)
> pr_warn( "... (pid: %d), tainting CPU_OUT_OF_SPEC.\n",
Right, or simply "tainting kernel" suffices. Like other code does. So that you
can find the word "taint" in the logs and you know where it comes from. As
this is what you want.
> This patch is not "really necessary". Its purpose is only to save hours
> or even days for people trying to make sense of crash logs. In my ideal
> world, it should always be easy to tell "who tainted what when" from the
> logs without an corresponding expert and/or searching the source code.
Yap, makes sense.
> I admit this could harm job security ;-)
Yeah, although there are always other, more interesting things to hack on. :-)
So yeah, v2 with the agreed upon changes sounds good.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2025-11-02 12:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-01 3:10 Marc Herbert
2025-11-01 10:03 ` Borislav Petkov
2025-11-02 3:19 ` Marc Herbert
2025-11-02 12:09 ` Borislav Petkov [this message]
2025-11-01 20:48 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251102120922.GAaQdJ8noSCgyoTE2F@fat_crate.local \
--to=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.herbert@linux.intel.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®